From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA4246D18 for ; Wed, 18 Aug 2021 06:44:03 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id EA5175C0259; Wed, 18 Aug 2021 02:44:02 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 18 Aug 2021 02:44:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=zzoOCl2YreUt7MfN2Ool90MUXMU XImkpZjNooyEe0Ac=; b=qGyZU/e5mtYaTVwX0UHaEohjjaNINhPX+/hEggeB4Ed 6t9xQ0PVlusJV2vv/yQXEAFBLFt8EOutsCmZo+4dPyOB2mA5uTho0w9KqlNc7E3b xUbukQFxgv+ETvU+XhqYsXWcun5+obn7tixApT3CqWT8yINgxTEjrxWuT5Qzl5Im ZTEwwIqaLVszK3b5ZEEK3J3XVXfJoDI081YA48xqhXlSGLkJjAja3wR/1KoPmlwI Jr4EkAb1sV847nRFhYofNoxEJlVxnQ6rI7AJlb+Av6ysLkNJXv+Ix0+IT6Ysr5sV 7s5vSPqMiM2/1v9nd4BufHkFmImLxx1IIXzX39v0MbA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=zzoOCl 2YreUt7MfN2Ool90MUXMUXImkpZjNooyEe0Ac=; b=rPRElJXU3AILQ5wm18OW7G 9phavvnnMqDtV/bKmofjzcay6EJkxWt80+jBwEPS6CpyN+CcEvXb5Niy4hGbGY07 lMZwlnv+b3v80adhb/LhIBi0h9L8KbaDJpIXP8b0PN889ZoAmdOXN6Ffp1izApmj yxHgOX0K+X6aQ6Mf5Y15rLofTMjwCUz5nJVPYQxh4Ajogm1Fb6epwfkbQC6h1jA3 cdntNYeAV3DmNzByZ3A6zYywKXMnS1cIdGkmweVdkJiRG4p4KjJHTbDB7pscGFG8 2/zspNHd+ihkuLSJCp7FGzaKK6SJZTB3OpOskj6OFq6qFnfPcsHmEg5cLrmuyLlg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrleeggddutdejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeevueehje fgfffgiedvudekvdektdelleelgefhleejieeugeegveeuuddukedvteenucevlhhushht vghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgrhgvgheskhhrohgrhh drtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 Aug 2021 02:44:01 -0400 (EDT) Date: Wed, 18 Aug 2021 08:43:58 +0200 From: Greg KH To: Cai Huoqing Cc: dan.carpenter@oracle.com, yangyingliang@huawei.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: r8188eu: Remove unused including Message-ID: References: <20210818063653.2851-1-caihuoqing@baidu.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210818063653.2851-1-caihuoqing@baidu.com> On Wed, Aug 18, 2021 at 02:36:53PM +0800, Cai Huoqing wrote: > Remove including that don't need it > > v1->v2: remove "based on staging-next" from commit message > v2->v3: add changelog to commit message As the documentation states, these lines need to go below the --- line, right? Please fix up and send a v4. thanks, greg k-h