From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5474CC4320E for ; Wed, 1 Sep 2021 16:25:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D92361053 for ; Wed, 1 Sep 2021 16:25:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245386AbhIAQ0k (ORCPT ); Wed, 1 Sep 2021 12:26:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:41102 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229820AbhIAQ0h (ORCPT ); Wed, 1 Sep 2021 12:26:37 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8607F61026; Wed, 1 Sep 2021 16:25:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630513540; bh=6XGIessxCdstb1MMTQL+7eNQhowuUPMqPTFcz8N7HFY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QDReyLgUFD8AGU1OgU1f2rxSgz3EmMgeeN5NXrDXT1Uyo3fvU3H6qs9Ojo8HbzxEL 2OH9CpZzEKNml2BMqKpmgY32xDGerER2vj4mS7CShaJnGpRkkIyO3D6gE8Tl3Zr1Rk XkBKi+SN4u/cjjL7OJzpqrQHOF6zLH06+lH4Ebpb124UrpME9L9pSETdMAZiqxQW5D 0ATeVxhZhs06Aq/TxPOdaamE1BYXHVFrGl1lAxLBgSouTAxjib/usI9//FTIMOFoW7 Ge/oyFpiWDe8boqMg5ZeOfDhDbUtOkS97wgS0zJo8MUrPCnY7nw9tKk0URHJDI0DFj ACwmX2b9Xp9/w== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id C043E4007E; Wed, 1 Sep 2021 13:25:37 -0300 (-03) Date: Wed, 1 Sep 2021 13:25:37 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: James Clark , mathieu.poirier@linaro.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, mike.leach@linaro.org, suzuki.poulose@arm.com, John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 9/9] perf cs-etm: Show a warning for an unknown magic number Message-ID: References: <20210806134109.1182235-1-james.clark@arm.com> <20210806134109.1182235-10-james.clark@arm.com> <20210824083615.GF204566@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Sep 01, 2021 at 01:16:56PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Sep 01, 2021 at 01:07:41PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Sep 01, 2021 at 12:54:34PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Tue, Aug 24, 2021 at 04:36:15PM +0800, Leo Yan escreveu: > > > > On Fri, Aug 06, 2021 at 02:41:09PM +0100, James Clark wrote: > > > > > Currently perf reports "Cannot allocate memory" which isn't very helpful > > > > > for a potentially user facing issue. If we add a new magic number in > > > > > the future, perf will be able to report unrecognised magic numbers. > > > > > > > > > > Signed-off-by: James Clark > > > > > > > > Reviewed-by: Leo Yan > > > > > > Applies cleanly to my tree, test building it now, holler if there is > > > something that prevents it from being merged. > > > > I´m now trying to fix this up, I applied it using 'b4', so no patch > > should have gone missing... > > So its probably related to: > > ⬢[acme@toolbox perf]$ rpm -qa | grep opencsd > opencsd-1.0.0-1.fc34.x86_64 > opencsd-devel-1.0.0-1.fc34.x86_64 > ⬢[acme@toolbox perf]$ > > In which case the usual mechanism is to test if we have what is needed > via tools/build/feature/test-_____.c, lemme check... There is a test and it fails, of course: ⬢[acme@toolbox perf]$ cat /tmp/build/perf/feature/test-libopencsd.make.output test-libopencsd.c:9:2: error: #error "OpenCSD >= 1.1.1 is required" 9 | #error "OpenCSD >= 1.1.1 is required" | ^~~~~ ⬢[acme@toolbox perf]$ But the fact that I ask for CORESIGHT=1 should have the build fail then, i.e. if one explicitely asks for a feature and it can't be built, fail the whole build. - Arnaldo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6D5BC432BE for ; Wed, 1 Sep 2021 16:29:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FD5D61057 for ; Wed, 1 Sep 2021 16:29:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7FD5D61057 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mA1mkPH4hRlrLWsAkaJ0Sa2Vnzn40lixfugMZU/H4JM=; b=UfXpToEHKK2PVl 2SZhnfoqchngTD0JLrZCIXeOSz3hJ1ofMqTvvalu23x2p56QyrIIDXptvDM2LFe3528CdWov0TPph XyEIyAtUdBZ8YLndeAh3tILFbWKHq4cii1+bf/H8L8M4aI6vIU0Cmc7fXiqLWlgcxvDclRNf3vHzg BVh9wq5dK2lB7B5terHPnGTpaq69K4fw/3DB0nIOml+HXH5+I8yBG2zD58vk3MkUqAPmiEpUpiUCA TPuPSElbIWJ8p7OSpo3Ee3GiDXSJKFquDKOSZP34t+mpW5x3cJezReUyN/eRP6TkKLm9qE7AbAT8e 9/gcKy32SG2YYpqObwZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLT5T-006WVy-H3; Wed, 01 Sep 2021 16:27:43 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLT5R-006WVV-Hs for linux-arm-kernel@bombadil.infradead.org; Wed, 01 Sep 2021 16:27:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=CpmpDX9mXyRtxYmLEO2wcaDHh5IcpZ25iZxXjXEgGoo=; b=JP6YbeDBxEC82t6qeO/yCjr0OY VuWo5WaANNWDAmsfkxCJRHrOZL0CvMQA+m8RP8wsqFe/dsWdZ4xzJm0p7k8pe2Bqakszp5UBgZH3F oepH9cZZghtSj6MBg88afpWNd+1PAf6Hq0I8QjPrGIEGlvi6ANV3AzYLnu+0vLRKBvwKuRv03AYiA lwMtjE+FQLZbk7ssMEgF/TuZ3wGLl+AaZU16cRH7pFmX7cw7ATdGC+s2FnyWnP5NyXHbB2a57DMJ5 1cyWhr0gi7UtyP3O5pcOUhhTNyNmC108vt58Y6iBUjvZQTnhWoaBA2uK49RIQ3Lx8ulThm0InrlnR eyj8sIYw==; Received: from [179.97.37.151] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLT3V-002XYW-QF for linux-arm-kernel@lists.infradead.org; Wed, 01 Sep 2021 16:26:07 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id C043E4007E; Wed, 1 Sep 2021 13:25:37 -0300 (-03) Date: Wed, 1 Sep 2021 13:25:37 -0300 From: Arnaldo Carvalho de Melo To: Leo Yan Cc: James Clark , mathieu.poirier@linaro.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, mike.leach@linaro.org, suzuki.poulose@arm.com, John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 9/9] perf cs-etm: Show a warning for an unknown magic number Message-ID: References: <20210806134109.1182235-1-james.clark@arm.com> <20210806134109.1182235-10-james.clark@arm.com> <20210824083615.GF204566@leoy-ThinkPad-X240s> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gV2VkLCBTZXAgMDEsIDIwMjEgYXQgMDE6MTY6NTZQTSAtMDMwMCwgQXJuYWxkbyBDYXJ2YWxo byBkZSBNZWxvIGVzY3JldmV1Ogo+IEVtIFdlZCwgU2VwIDAxLCAyMDIxIGF0IDAxOjA3OjQxUE0g LTAzMDAsIEFybmFsZG8gQ2FydmFsaG8gZGUgTWVsbyBlc2NyZXZldToKPiA+IEVtIFdlZCwgU2Vw IDAxLCAyMDIxIGF0IDEyOjU0OjM0UE0gLTAzMDAsIEFybmFsZG8gQ2FydmFsaG8gZGUgTWVsbyBl c2NyZXZldToKPiA+ID4gRW0gVHVlLCBBdWcgMjQsIDIwMjEgYXQgMDQ6MzY6MTVQTSArMDgwMCwg TGVvIFlhbiBlc2NyZXZldToKPiA+ID4gPiBPbiBGcmksIEF1ZyAwNiwgMjAyMSBhdCAwMjo0MTow OVBNICswMTAwLCBKYW1lcyBDbGFyayB3cm90ZToKPiA+ID4gPiA+IEN1cnJlbnRseSBwZXJmIHJl cG9ydHMgIkNhbm5vdCBhbGxvY2F0ZSBtZW1vcnkiIHdoaWNoIGlzbid0IHZlcnkgaGVscGZ1bAo+ ID4gPiA+ID4gZm9yIGEgcG90ZW50aWFsbHkgdXNlciBmYWNpbmcgaXNzdWUuIElmIHdlIGFkZCBh IG5ldyBtYWdpYyBudW1iZXIgaW4KPiA+ID4gPiA+IHRoZSBmdXR1cmUsIHBlcmYgd2lsbCBiZSBh YmxlIHRvIHJlcG9ydCB1bnJlY29nbmlzZWQgbWFnaWMgbnVtYmVycy4KPiA+ID4gPiA+IAo+ID4g PiA+ID4gU2lnbmVkLW9mZi1ieTogSmFtZXMgQ2xhcmsgPGphbWVzLmNsYXJrQGFybS5jb20+Cj4g PiA+ID4gCj4gPiA+ID4gUmV2aWV3ZWQtYnk6IExlbyBZYW4gPGxlby55YW5AbGluYXJvLm9yZz4K PiA+ID4gCj4gPiA+IEFwcGxpZXMgY2xlYW5seSB0byBteSB0cmVlLCB0ZXN0IGJ1aWxkaW5nIGl0 IG5vdywgaG9sbGVyIGlmIHRoZXJlIGlzCj4gPiA+IHNvbWV0aGluZyB0aGF0IHByZXZlbnRzIGl0 IGZyb20gYmVpbmcgbWVyZ2VkLgo+ID4gCj4gPiBJwrRtIG5vdyB0cnlpbmcgdG8gZml4IHRoaXMg dXAsIEkgYXBwbGllZCBpdCB1c2luZyAnYjQnLCBzbyBubyBwYXRjaAo+ID4gc2hvdWxkIGhhdmUg Z29uZSBtaXNzaW5nLi4uCj4gCj4gU28gaXRzIHByb2JhYmx5IHJlbGF0ZWQgdG86Cj4gCj4g4qyi W2FjbWVAdG9vbGJveCBwZXJmXSQgcnBtIC1xYSB8IGdyZXAgb3BlbmNzZAo+IG9wZW5jc2QtMS4w LjAtMS5mYzM0Lng4Nl82NAo+IG9wZW5jc2QtZGV2ZWwtMS4wLjAtMS5mYzM0Lng4Nl82NAo+IOKs olthY21lQHRvb2xib3ggcGVyZl0kCj4gCj4gSW4gd2hpY2ggY2FzZSB0aGUgdXN1YWwgbWVjaGFu aXNtIGlzIHRvIHRlc3QgaWYgd2UgaGF2ZSB3aGF0IGlzIG5lZWRlZAo+IHZpYSB0b29scy9idWls ZC9mZWF0dXJlL3Rlc3QtX19fX18uYywgbGVtbWUgY2hlY2suLi4KClRoZXJlIGlzIGEgdGVzdCBh bmQgaXQgZmFpbHMsIG9mIGNvdXJzZToKCuKsolthY21lQHRvb2xib3ggcGVyZl0kIGNhdCAvdG1w L2J1aWxkL3BlcmYvZmVhdHVyZS90ZXN0LWxpYm9wZW5jc2QubWFrZS5vdXRwdXQKdGVzdC1saWJv cGVuY3NkLmM6OToyOiBlcnJvcjogI2Vycm9yICJPcGVuQ1NEID49IDEuMS4xIGlzIHJlcXVpcmVk IgogICAgOSB8ICNlcnJvciAiT3BlbkNTRCA+PSAxLjEuMSBpcyByZXF1aXJlZCIKICAgICAgfCAg Xn5+fn4K4qyiW2FjbWVAdG9vbGJveCBwZXJmXSQKCkJ1dCB0aGUgZmFjdCB0aGF0IEkgYXNrIGZv ciBDT1JFU0lHSFQ9MSBzaG91bGQgaGF2ZSB0aGUgYnVpbGQgZmFpbCB0aGVuLAppLmUuIGlmIG9u ZSBleHBsaWNpdGVseSBhc2tzIGZvciBhIGZlYXR1cmUgYW5kIGl0IGNhbid0IGJlIGJ1aWx0LCBm YWlsCnRoZSB3aG9sZSBidWlsZC4KCi0gQXJuYWxkbwoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=