All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Becker <jlbec@evilplan.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Sishuai Gong <sishuai@purdue.edu>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/4] configfs: return -ENAMETOOLONG earlier in configfs_lookup
Date: Tue, 31 Aug 2021 05:50:47 +0000	[thread overview]
Message-ID: <YS3DN6fhJZEhu1Oy@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <20210825064906.1694233-2-hch@lst.de>

Reviewed-by: Joel Becker <jlbec@evilplan.org>

On Wed, Aug 25, 2021 at 08:49:03AM +0200, Christoph Hellwig wrote:
> Just like most other file systems: get the simple checks out of the
> way first.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>  fs/configfs/dir.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
> index ac5e0c0e9181..cf08bbde55f3 100644
> --- a/fs/configfs/dir.c
> +++ b/fs/configfs/dir.c
> @@ -456,6 +456,9 @@ static struct dentry * configfs_lookup(struct inode *dir,
>  	int found = 0;
>  	int err;
>  
> +	if (dentry->d_name.len > NAME_MAX)
> +		return ERR_PTR(-ENAMETOOLONG);
> +
>  	/*
>  	 * Fake invisibility if dir belongs to a group/default groups hierarchy
>  	 * being attached
> @@ -486,8 +489,6 @@ static struct dentry * configfs_lookup(struct inode *dir,
>  		 * If it doesn't exist and it isn't a NOT_PINNED item,
>  		 * it must be negative.
>  		 */
> -		if (dentry->d_name.len > NAME_MAX)
> -			return ERR_PTR(-ENAMETOOLONG);
>  		d_add(dentry, NULL);
>  		return NULL;
>  	}
> -- 
> 2.30.2
> 

-- 

  reply	other threads:[~2021-08-31  5:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25  6:49 configfs lookup race fix Christoph Hellwig
2021-08-25  6:49 ` [PATCH 1/4] configfs: return -ENAMETOOLONG earlier in configfs_lookup Christoph Hellwig
2021-08-31  5:50   ` Joel Becker [this message]
2021-08-31  5:52   ` Joel Becker
2021-08-25  6:49 ` [PATCH 2/4] configfs: simplify the configfs_dirent_is_ready Christoph Hellwig
2021-08-31  5:51   ` Joel Becker
2021-08-25  6:49 ` [PATCH 3/4] configfs: fold configfs_attach_attr into configfs_lookup Christoph Hellwig
2021-08-31  5:52   ` Joel Becker
2021-08-25  6:49 ` [PATCH 4/4] configfs: fix a race in configfs_lookup() Christoph Hellwig
2021-08-31  5:53   ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YS3DN6fhJZEhu1Oy@zeniv-ca.linux.org.uk \
    --to=jlbec@evilplan.org \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sishuai@purdue.edu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.