From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1BB1C432BE for ; Tue, 31 Aug 2021 12:52:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CF6061041 for ; Tue, 31 Aug 2021 12:52:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9CF6061041 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9EC5889C6A; Tue, 31 Aug 2021 12:52:29 +0000 (UTC) Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by gabe.freedesktop.org (Postfix) with ESMTPS id A3AE389C6A for ; Tue, 31 Aug 2021 12:52:28 +0000 (UTC) Received: by mail-wr1-x431.google.com with SMTP id u16so27538865wrn.5 for ; Tue, 31 Aug 2021 05:52:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=z9k9QrM+sqCDh/Z+pKMqcv5ihjAhkGCXXwpSgZA9mSs=; b=hhkTVuBrHU+EtGZff8CsRlrynpmBE9PA/Yj6QvCypfZNJOI2RYB7kRzxFFPjhRrHq5 ThtOQZt1I5wOvjdgP4K7cfBUdK70/Ga41SixNQGjpsAWv2EeimfLkw42ObtJ+qyfZfAv S6j/2lGMKR/s5bZp5hmUq5z4m9Inx4FLfVMjo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=z9k9QrM+sqCDh/Z+pKMqcv5ihjAhkGCXXwpSgZA9mSs=; b=cpv5wSzh92g2bs2CEaIdJtCwU5kFnUcTAbD+XSYgrk5Stl9AAMQEOJI0g4OI/zGGzQ SQy2B4AaHQyMn+yVPlHZMuvnea9VfIOCidXji+T1041BL/IJDwUe55vtnMWSKG4XehQ6 uJVbyX4gQgTeP1bIc/hH52pFzwsiacA3RyPAKBOzeddI1feE4SMHDIgx2AvobgIxLrQr XMMb1igsYqL0qsNP6vrX0zckyeZkm94WHVCCh100H+WqGSJZUlM1pO63TkNK09ASMVOt ZtTTZ32i2M75+HLJVNVv4V3unilghKW+ctp/i9nXwmUvRN0ZMFhDabN/EDmEjbl4wZ+y L3Ow== X-Gm-Message-State: AOAM532icCnIPTb5uRQZCQ7qEdkhUeB274C7j0RexdHLvZml5efad5ZL JDDh0ZGKJkXOX8VLeX+WdtIAOA== X-Google-Smtp-Source: ABdhPJyGld7buZREuKNHWQnrZmTlgqAGRYXVZcC/S3JtEzhtUqTWHGMPwwtl4lnvea2scioroO8aWg== X-Received: by 2002:adf:9d45:: with SMTP id o5mr29570376wre.226.1630414347223; Tue, 31 Aug 2021 05:52:27 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id d6sm16159402wra.5.2021.08.31.05.52.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 05:52:26 -0700 (PDT) Date: Tue, 31 Aug 2021 14:52:24 +0200 From: Daniel Vetter To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: thomas.hellstrom@linux.intel.com, dri-devel@lists.freedesktop.org, andrey.grodzovsky@amd.com Subject: Re: [PATCH 04/12] drm/ttm: add common accounting to the resource mgr Message-ID: References: <20210830085707.209508-1-christian.koenig@amd.com> <20210830085707.209508-4-christian.koenig@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210830085707.209508-4-christian.koenig@amd.com> X-Operating-System: Linux phenom 5.10.0-8-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Aug 30, 2021 at 10:56:59AM +0200, Christian König wrote: > It makes sense to have this in the common manager for debugging and > accounting of how much resources are used. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/ttm/ttm_resource.c | 8 ++++++++ > include/drm/ttm/ttm_resource.h | 18 ++++++++++++++++++ > 2 files changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/ttm/ttm_resource.c b/drivers/gpu/drm/ttm/ttm_resource.c > index a4c495da0040..426e6841fc89 100644 > --- a/drivers/gpu/drm/ttm/ttm_resource.c > +++ b/drivers/gpu/drm/ttm/ttm_resource.c > @@ -33,6 +33,8 @@ void ttm_resource_init(struct ttm_buffer_object *bo, > const struct ttm_place *place, > struct ttm_resource *res) > { > + struct ttm_resource_manager *man; > + > res->start = 0; > res->num_pages = PFN_UP(bo->base.size); > res->mem_type = place->mem_type; > @@ -42,12 +44,16 @@ void ttm_resource_init(struct ttm_buffer_object *bo, > res->bus.is_iomem = false; > res->bus.caching = ttm_cached; > res->bo = bo; > + > + man = ttm_manager_type(bo->bdev, place->mem_type); > + atomic64_add(bo->base.size, &man->usage); > } > EXPORT_SYMBOL(ttm_resource_init); > > void ttm_resource_fini(struct ttm_resource_manager *man, > struct ttm_resource *res) > { > + atomic64_sub(res->bo->base.size, &man->usage); > } > EXPORT_SYMBOL(ttm_resource_fini); > > @@ -100,6 +106,7 @@ void ttm_resource_manager_init(struct ttm_resource_manager *man, > spin_lock_init(&man->move_lock); > man->bdev = bdev; > man->size = p_size; > + atomic64_set(&man->usage, 0); > > for (i = 0; i < TTM_MAX_BO_PRIORITY; ++i) > INIT_LIST_HEAD(&man->lru[i]); > @@ -172,6 +179,7 @@ void ttm_resource_manager_debug(struct ttm_resource_manager *man, > drm_printf(p, " use_type: %d\n", man->use_type); > drm_printf(p, " use_tt: %d\n", man->use_tt); > drm_printf(p, " size: %llu\n", man->size); > + drm_printf(p, " usage: %llu\n", atomic64_read(&man->usage)); > if (man->func->debug) > man->func->debug(man, p); > } > diff --git a/include/drm/ttm/ttm_resource.h b/include/drm/ttm/ttm_resource.h > index e8080192cae4..526fe359c603 100644 > --- a/include/drm/ttm/ttm_resource.h > +++ b/include/drm/ttm/ttm_resource.h > @@ -27,6 +27,7 @@ > > #include > #include > +#include > #include > #include > #include > @@ -110,6 +111,7 @@ struct ttm_resource_manager_func { > * static information. bdev::driver::io_mem_free is never used. > * @lru: The lru list for this memory type. > * @move: The fence of the last pipelined move operation. > + * @usage: How much of the region is used. > * > * This structure is used to identify and manage memory types for a device. > */ > @@ -134,6 +136,9 @@ struct ttm_resource_manager { > * Protected by @move_lock. > */ > struct dma_fence *move; > + > + /* Own protection */ > + atomic64_t usage; Shouldn't we keep track of this together with the lru updates, under the same spinlock? Otherwise this usage here just becomes kinda meaningless I think, and just for some debugging. I really don't like sprinkling random atomic_t around (mostly because i915-gem code has gone totally overboard with them, with complete disregard to complexity of the result). -Daniel > }; > > /** > @@ -260,6 +265,19 @@ ttm_resource_manager_cleanup(struct ttm_resource_manager *man) > man->move = NULL; > } > > +/** > + * ttm_resource_manager_usage > + * > + * @man: A memory manager object. > + * > + * Return how many resources are currently used. > + */ > +static inline uint64_t > +ttm_resource_manager_usage(struct ttm_resource_manager *man) > +{ > + return atomic64_read(&man->usage); > +} > + > void ttm_resource_init(struct ttm_buffer_object *bo, > const struct ttm_place *place, > struct ttm_resource *res); > -- > 2.25.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch