From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53AA6C4320A for ; Tue, 31 Aug 2021 14:56:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 308146101B for ; Tue, 31 Aug 2021 14:56:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238829AbhHaO46 (ORCPT ); Tue, 31 Aug 2021 10:56:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238511AbhHaO45 (ORCPT ); Tue, 31 Aug 2021 10:56:57 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C351C061575; Tue, 31 Aug 2021 07:56:01 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id n18so16955034pgm.12; Tue, 31 Aug 2021 07:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RNp457MB/vxzZEKURYpzK+PHbxVwBG4M79IfgemcDRc=; b=eDsC58O1F1Nbv6+V1Y+NmGiEg8L5nkeOfNp4pqRuRjW5yD2qP/D438x3rsBdqHp+Ne mYQ/J3/KTItVLEzfPnLOrzVA8PhmXuHLWRPKC3w2FAM36tA5ewbByMTkDuAgYw2fQbd4 uAfNEmItehTal7iBkNM2BRB7DIEmV3hjSt8wd1lfIGyoz7R0CqCEJOyuqq4yCnxDRi0N DApe4eCo/ZmMhhlCAUAsifJjSATsOn+aROaN6EixUPgU/lMY5YqK9kauVzQ5ORW3QEoW Ogt4DRQRFOVR+Cajo37IbcJKB0JXivAge9CaLFNZiIVYvEanhlmrVdiSaUD0j8tY/GmI MCEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RNp457MB/vxzZEKURYpzK+PHbxVwBG4M79IfgemcDRc=; b=hajqoawOzzGf7xZCQWbk48Avp4Qwmq9uQe+AjYYvL6riKKvweO7UrWXinN5nflmw1B FR4Tv6ylmdH6lAkrnbovY7acJU3tJn8NUt0oPUY1J1g1p89TCEiUOfgK+CoGCHEnRApP qGM9NCXuDek1frKx1nvY5qsMKAS9262qaqQUptn80W4ZRSoh5SGUbWukfB7qfVxhbdW7 ehXrh0YGz6zxDHF4tLCwhI1Mj/VXEnHuzIu8ivbZVp0J+Sk2VeStJz93p6TCqt0xnVuM SQrR1Cc2w3Lm7g+vebb4hStOD3kYQe+4nQYWgtr1rmk7GfwrNQm07FpwOmxrjSwsy4aK 3ESw== X-Gm-Message-State: AOAM53284M9ENH+hCsrgwSee1WkWByq7R4WsiXV2e5OwyTDQWtUHXr9/ bCZo9k1rOH329xqWIbrer4Y= X-Google-Smtp-Source: ABdhPJz6KuDG5RnjA5Rj0MKW+mijQXIj5E4Xtn0IdEcRtNDO4gG1DjkmYZUvENNfmmXrcxL4yaIB7g== X-Received: by 2002:a63:230f:: with SMTP id j15mr939761pgj.9.1630421761139; Tue, 31 Aug 2021 07:56:01 -0700 (PDT) Received: from shinobu ([156.146.35.76]) by smtp.gmail.com with ESMTPSA id z17sm10544496pfa.125.2021.08.31.07.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 07:56:00 -0700 (PDT) Date: Tue, 31 Aug 2021 23:55:53 +0900 From: William Breathitt Gray To: Fabrice Gasnier Cc: jic23@kernel.org, kamel.bouhara@bootlin.com, gwendal@chromium.org, david@lechnology.com, linux-iio@vger.kernel.org, patrick.havelange@essensium.com, alexandre.belloni@bootlin.com, mcoquelin.stm32@gmail.com, linux-kernel@vger.kernel.org, o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com, Dan Carpenter , kernel@pengutronix.de, fabrice.gasnier@st.com, syednwaris@gmail.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, alexandre.torgue@st.com Subject: Re: [Linux-stm32] [PATCH v16 03/14] counter: Internalize sysfs interface code Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Eu0c7fx1a/C8FgI+" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Eu0c7fx1a/C8FgI+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 31, 2021 at 11:16:59PM +0900, William Breathitt Gray wrote: > On Tue, Aug 31, 2021 at 03:44:04PM +0200, Fabrice Gasnier wrote: > > On 8/27/21 5:47 AM, William Breathitt Gray wrote: > > > This is a reimplementation of the Generic Counter driver interface. > > > There are no modifications to the Counter subsystem userspace interfa= ce, > > > so existing userspace applications should continue to run seamlessly. > > >=20 > > > The purpose of this patch is to internalize the sysfs interface code > > > among the various counter drivers into a shared module. Counter drive= rs > > > pass and take data natively (i.e. u8, u64, etc.) and the shared count= er > > > module handles the translation between the sysfs interface and the > > > device drivers. This guarantees a standard userspace interface for all > > > counter drivers, and helps generalize the Generic Counter driver ABI = in > > > order to support the Generic Counter chrdev interface (introduced in a > > > subsequent patch) without significant changes to the existing counter > > > drivers. > > >=20 > > > Note, Counter device registration is the same as before: drivers > > > populate a struct counter_device with components and callbacks, then > > > pass the structure to the devm_counter_register function. However, > > > what's different now is how the Counter subsystem code handles this > > > registration internally. > > >=20 > > > Whereas before callbacks would interact directly with sysfs data, this > > > interaction is now abstracted and instead callbacks interact with nat= ive > > > C data types. The counter_comp structure forms the basis for Counter > > > extensions. > > >=20 > > > The counter-sysfs.c file contains the code to parse through the > > > counter_device structure and register the requested components and > > > extensions. Attributes are created and populated based on type, with > > > respective translation functions to handle the mapping between sysfs = and > > > the counter driver callbacks. > > >=20 > > > The translation performed for each attribute is straightforward: the > > > attribute type and data is parsed from the counter_attribute structur= e, > > > the respective counter driver read/write callback is called, and sysfs > > > I/O is handled before or after the driver read/write function is call= ed. > > >=20 > > > Cc: Jarkko Nikula > > > Cc: Patrick Havelange > > > Cc: Kamel Bouhara > > > Cc: Fabrice Gasnier > > > Cc: Maxime Coquelin > > > Cc: Alexandre Torgue > > > Cc: Dan Carpenter > > > Acked-by: Syed Nayyar Waris > > > Reviewed-by: David Lechner > > > Tested-by: David Lechner > > > Signed-off-by: William Breathitt Gray > > > --- > > > MAINTAINERS | 1 - > > > drivers/counter/104-quad-8.c | 449 +++---- > > > drivers/counter/Makefile | 1 + > > > drivers/counter/counter-core.c | 142 +++ > > > drivers/counter/counter-sysfs.c | 849 +++++++++++++ > > > drivers/counter/counter-sysfs.h | 13 + > > > drivers/counter/counter.c | 1496 ---------------------= -- > > > drivers/counter/ftm-quaddec.c | 60 +- > > > drivers/counter/intel-qep.c | 144 +-- > > > drivers/counter/interrupt-cnt.c | 62 +- > > > drivers/counter/microchip-tcb-capture.c | 91 +- > > > drivers/counter/stm32-lptimer-cnt.c | 212 ++-- > > > drivers/counter/stm32-timer-cnt.c | 179 ++- > > > drivers/counter/ti-eqep.c | 180 +-- > > > include/linux/counter.h | 658 +++++----- > > > include/linux/counter_enum.h | 45 - > > > 16 files changed, 1949 insertions(+), 2633 deletions(-) > > > create mode 100644 drivers/counter/counter-core.c > > > create mode 100644 drivers/counter/counter-sysfs.c > > > create mode 100644 drivers/counter/counter-sysfs.h > > > delete mode 100644 drivers/counter/counter.c > > > delete mode 100644 include/linux/counter_enum.h > > >=20 > >=20 > > Hi William, > >=20 > > For the STM32 drivers, you can add my: > > Reviewed-by: Fabrice Gasnier > >=20 > > Thanks, > > Fabrice >=20 > Hello Fabrice, >=20 > I noticed the stm32-lptimer-cnt.c function_write() and action_write() > callbacks do not appear to write the desired function/action > configuration to the device. Would you check whether the device actually > supports this functionality or if these callbacks should be removed from > this driver. >=20 > Thanks, >=20 > William Breathitt Gray Nevermind, I see that these configurations are sent to the device via stm32_lptim_setup() when the counter is enabled. So that setup should be fine after all. Thanks, William Breathitt Gray --Eu0c7fx1a/C8FgI+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmEuQssACgkQhvpINdm7 VJKk7xAAle4yE4cmZdHYt/2PVJ1C5dMMRKmZ3HFyB8zckzEqpV1ElqkAGevVyYSw Vf3dKfMeCy+eOGMoOs2f5VFrSwJkqCZMx1RmdRdPZbcUu8kupH/709oaSUZ7UEeK T/oMcnoezNeyLkiqHE7Rvln/huzcoc0pJgtDOjTI1ZsAtr7ft0X/dzAF4rxMABgh nQ1vRTze7+K+ArLAWHZ3dC2b/j+MJN4Z3OoOk0Y2R1vB8aM+Jam2Q8b+QgBFKOyH O7wSx8kCRBYzwGQLlEYqJgUwJKfy1E6fzX3/k16esbEKrbXSvZhFTLtPXc9QvTY5 rHoK4FQZC42vxMq5qeGY2/P4liItgmUPGuK9yk/7uDH5N8VTi4KW1tvv4k1mfe6D RsEsBF0D3m2bek0tyo+jfvp4uPF092aY7JAqxjSLkgJphkXtztol3+bFoff/H6Je JaSsyqgFXfrXkjmXPQNCzHub4y1lTL/uawB6UdaXC9UiBc5GB14t7LspagHF3qHc zWIRT5I6TLoUsoV0fqLWiA+JLgmbOizzCUFxwIeOD3YfBsMT8ntBj5YJc9CEKEAA gdjKV0CEFyCtxeddec/wTHdMX/WzMctyfEo1ePgNKTxIyBh9Xe3Z2jAeng4tlpx8 DDztX70QETwxRwXtOHRc61VJscixJ+lKhwqE9NGpvn4o9YAvI6o= =gyQI -----END PGP SIGNATURE----- --Eu0c7fx1a/C8FgI+-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 549B8C432BE for ; Tue, 31 Aug 2021 14:58:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FB1F6103D for ; Tue, 31 Aug 2021 14:58:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1FB1F6103D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OKl0Pj6r4lPULUIbNRTagAsdYv67GUd5YIGtY6AjqfM=; b=UbYGleK2pzF+2NkgI4mWhsvUZQ vWjHuM9HCcLvo7eO1lxsw+q+7BB1UAmjy4E583r8vWLrg/6hDjzMUeCnTQSWr1uqXenMo8ixXK7tP YstD/+nMVx2hOOQs8EPC5eTaV1BNkyOyC9sWeyA0wP927yiFqFFslo3zld9pFUuXOtds2ZvdbMw8l HqT/ojMfNbNRsxHYN7htYoExKLCNZZoui+xmJI4j6oFSoobwRtyTiGP7czTa8cASJIS4GM38Kxev1 q8DDhTP2ZHgXpAR8Gpc/IMzj9WjnHEkY+61que9QQAnqFDiuhj+gRHcK940xDoLHkhb7C7KHPKYGH SbdeKeYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mL5BG-002aBP-Bx; Tue, 31 Aug 2021 14:56:06 +0000 Received: from mail-pg1-x531.google.com ([2607:f8b0:4864:20::531]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mL5BC-002aAw-5j for linux-arm-kernel@lists.infradead.org; Tue, 31 Aug 2021 14:56:03 +0000 Received: by mail-pg1-x531.google.com with SMTP id q68so16944715pga.9 for ; Tue, 31 Aug 2021 07:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=RNp457MB/vxzZEKURYpzK+PHbxVwBG4M79IfgemcDRc=; b=eDsC58O1F1Nbv6+V1Y+NmGiEg8L5nkeOfNp4pqRuRjW5yD2qP/D438x3rsBdqHp+Ne mYQ/J3/KTItVLEzfPnLOrzVA8PhmXuHLWRPKC3w2FAM36tA5ewbByMTkDuAgYw2fQbd4 uAfNEmItehTal7iBkNM2BRB7DIEmV3hjSt8wd1lfIGyoz7R0CqCEJOyuqq4yCnxDRi0N DApe4eCo/ZmMhhlCAUAsifJjSATsOn+aROaN6EixUPgU/lMY5YqK9kauVzQ5ORW3QEoW Ogt4DRQRFOVR+Cajo37IbcJKB0JXivAge9CaLFNZiIVYvEanhlmrVdiSaUD0j8tY/GmI MCEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=RNp457MB/vxzZEKURYpzK+PHbxVwBG4M79IfgemcDRc=; b=QyTHxmV13p6BYSBmSvP48OpthyS8d9FcOuPbyACBMufJ3rNBGFD+aqVZlHLHaImYVn RvNt9AZS1iHBmCxyZnttHqIoNR7y9dMCNlo0JhjD2UFB2MBgB4YEfGxrFLhlLpRv5HhI rhPjKDqX4r+L1aSVV/VcCHWjEO2J7WcfwIz1poblufydYsnRVBqlv4CurikhwCXA7eTs tOIxlyszjwly54VYlp5/iMopWuKk/VDCqt4yKaoPRwruXCCeLdSlx9IuYGSZFmyISyz0 v0C7Mzi2MwPA6uQaZqXOrMCHxVsaCQNMvn5+gcqkqAoUAehjxJ7cyeQE8yGY0Cy5fv0V Dunw== X-Gm-Message-State: AOAM533ALIjyvEQQEbJ93wCCtHiULL5p9LIjjDNGjHPhq7N7d5WWTEyV qn0/CSC9VYtAO4gajV3z2vGj8czhegPHOg== X-Google-Smtp-Source: ABdhPJz6KuDG5RnjA5Rj0MKW+mijQXIj5E4Xtn0IdEcRtNDO4gG1DjkmYZUvENNfmmXrcxL4yaIB7g== X-Received: by 2002:a63:230f:: with SMTP id j15mr939761pgj.9.1630421761139; Tue, 31 Aug 2021 07:56:01 -0700 (PDT) Received: from shinobu ([156.146.35.76]) by smtp.gmail.com with ESMTPSA id z17sm10544496pfa.125.2021.08.31.07.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 07:56:00 -0700 (PDT) Date: Tue, 31 Aug 2021 23:55:53 +0900 From: William Breathitt Gray To: Fabrice Gasnier Cc: jic23@kernel.org, kamel.bouhara@bootlin.com, gwendal@chromium.org, david@lechnology.com, linux-iio@vger.kernel.org, patrick.havelange@essensium.com, alexandre.belloni@bootlin.com, mcoquelin.stm32@gmail.com, linux-kernel@vger.kernel.org, o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com, Dan Carpenter , kernel@pengutronix.de, fabrice.gasnier@st.com, syednwaris@gmail.com, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, alexandre.torgue@st.com Subject: Re: [Linux-stm32] [PATCH v16 03/14] counter: Internalize sysfs interface code Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210831_075602_276943_90FEDC97 X-CRM114-Status: GOOD ( 37.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1164264264962590480==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1164264264962590480== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Eu0c7fx1a/C8FgI+" Content-Disposition: inline --Eu0c7fx1a/C8FgI+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 31, 2021 at 11:16:59PM +0900, William Breathitt Gray wrote: > On Tue, Aug 31, 2021 at 03:44:04PM +0200, Fabrice Gasnier wrote: > > On 8/27/21 5:47 AM, William Breathitt Gray wrote: > > > This is a reimplementation of the Generic Counter driver interface. > > > There are no modifications to the Counter subsystem userspace interfa= ce, > > > so existing userspace applications should continue to run seamlessly. > > >=20 > > > The purpose of this patch is to internalize the sysfs interface code > > > among the various counter drivers into a shared module. Counter drive= rs > > > pass and take data natively (i.e. u8, u64, etc.) and the shared count= er > > > module handles the translation between the sysfs interface and the > > > device drivers. This guarantees a standard userspace interface for all > > > counter drivers, and helps generalize the Generic Counter driver ABI = in > > > order to support the Generic Counter chrdev interface (introduced in a > > > subsequent patch) without significant changes to the existing counter > > > drivers. > > >=20 > > > Note, Counter device registration is the same as before: drivers > > > populate a struct counter_device with components and callbacks, then > > > pass the structure to the devm_counter_register function. However, > > > what's different now is how the Counter subsystem code handles this > > > registration internally. > > >=20 > > > Whereas before callbacks would interact directly with sysfs data, this > > > interaction is now abstracted and instead callbacks interact with nat= ive > > > C data types. The counter_comp structure forms the basis for Counter > > > extensions. > > >=20 > > > The counter-sysfs.c file contains the code to parse through the > > > counter_device structure and register the requested components and > > > extensions. Attributes are created and populated based on type, with > > > respective translation functions to handle the mapping between sysfs = and > > > the counter driver callbacks. > > >=20 > > > The translation performed for each attribute is straightforward: the > > > attribute type and data is parsed from the counter_attribute structur= e, > > > the respective counter driver read/write callback is called, and sysfs > > > I/O is handled before or after the driver read/write function is call= ed. > > >=20 > > > Cc: Jarkko Nikula > > > Cc: Patrick Havelange > > > Cc: Kamel Bouhara > > > Cc: Fabrice Gasnier > > > Cc: Maxime Coquelin > > > Cc: Alexandre Torgue > > > Cc: Dan Carpenter > > > Acked-by: Syed Nayyar Waris > > > Reviewed-by: David Lechner > > > Tested-by: David Lechner > > > Signed-off-by: William Breathitt Gray > > > --- > > > MAINTAINERS | 1 - > > > drivers/counter/104-quad-8.c | 449 +++---- > > > drivers/counter/Makefile | 1 + > > > drivers/counter/counter-core.c | 142 +++ > > > drivers/counter/counter-sysfs.c | 849 +++++++++++++ > > > drivers/counter/counter-sysfs.h | 13 + > > > drivers/counter/counter.c | 1496 ---------------------= -- > > > drivers/counter/ftm-quaddec.c | 60 +- > > > drivers/counter/intel-qep.c | 144 +-- > > > drivers/counter/interrupt-cnt.c | 62 +- > > > drivers/counter/microchip-tcb-capture.c | 91 +- > > > drivers/counter/stm32-lptimer-cnt.c | 212 ++-- > > > drivers/counter/stm32-timer-cnt.c | 179 ++- > > > drivers/counter/ti-eqep.c | 180 +-- > > > include/linux/counter.h | 658 +++++----- > > > include/linux/counter_enum.h | 45 - > > > 16 files changed, 1949 insertions(+), 2633 deletions(-) > > > create mode 100644 drivers/counter/counter-core.c > > > create mode 100644 drivers/counter/counter-sysfs.c > > > create mode 100644 drivers/counter/counter-sysfs.h > > > delete mode 100644 drivers/counter/counter.c > > > delete mode 100644 include/linux/counter_enum.h > > >=20 > >=20 > > Hi William, > >=20 > > For the STM32 drivers, you can add my: > > Reviewed-by: Fabrice Gasnier > >=20 > > Thanks, > > Fabrice >=20 > Hello Fabrice, >=20 > I noticed the stm32-lptimer-cnt.c function_write() and action_write() > callbacks do not appear to write the desired function/action > configuration to the device. Would you check whether the device actually > supports this functionality or if these callbacks should be removed from > this driver. >=20 > Thanks, >=20 > William Breathitt Gray Nevermind, I see that these configurations are sent to the device via stm32_lptim_setup() when the counter is enabled. So that setup should be fine after all. Thanks, William Breathitt Gray --Eu0c7fx1a/C8FgI+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEk5I4PDJ2w1cDf/bghvpINdm7VJIFAmEuQssACgkQhvpINdm7 VJKk7xAAle4yE4cmZdHYt/2PVJ1C5dMMRKmZ3HFyB8zckzEqpV1ElqkAGevVyYSw Vf3dKfMeCy+eOGMoOs2f5VFrSwJkqCZMx1RmdRdPZbcUu8kupH/709oaSUZ7UEeK T/oMcnoezNeyLkiqHE7Rvln/huzcoc0pJgtDOjTI1ZsAtr7ft0X/dzAF4rxMABgh nQ1vRTze7+K+ArLAWHZ3dC2b/j+MJN4Z3OoOk0Y2R1vB8aM+Jam2Q8b+QgBFKOyH O7wSx8kCRBYzwGQLlEYqJgUwJKfy1E6fzX3/k16esbEKrbXSvZhFTLtPXc9QvTY5 rHoK4FQZC42vxMq5qeGY2/P4liItgmUPGuK9yk/7uDH5N8VTi4KW1tvv4k1mfe6D RsEsBF0D3m2bek0tyo+jfvp4uPF092aY7JAqxjSLkgJphkXtztol3+bFoff/H6Je JaSsyqgFXfrXkjmXPQNCzHub4y1lTL/uawB6UdaXC9UiBc5GB14t7LspagHF3qHc zWIRT5I6TLoUsoV0fqLWiA+JLgmbOizzCUFxwIeOD3YfBsMT8ntBj5YJc9CEKEAA gdjKV0CEFyCtxeddec/wTHdMX/WzMctyfEo1ePgNKTxIyBh9Xe3Z2jAeng4tlpx8 DDztX70QETwxRwXtOHRc61VJscixJ+lKhwqE9NGpvn4o9YAvI6o= =gyQI -----END PGP SIGNATURE----- --Eu0c7fx1a/C8FgI+-- --===============1164264264962590480== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1164264264962590480==--