From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BCA7C432BE for ; Tue, 31 Aug 2021 20:06:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 605876108B for ; Tue, 31 Aug 2021 20:06:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240674AbhHaUHk (ORCPT ); Tue, 31 Aug 2021 16:07:40 -0400 Received: from mail-ot1-f44.google.com ([209.85.210.44]:34639 "EHLO mail-ot1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240791AbhHaUHj (ORCPT ); Tue, 31 Aug 2021 16:07:39 -0400 Received: by mail-ot1-f44.google.com with SMTP id k12-20020a056830150c00b0051abe7f680bso668954otp.1; Tue, 31 Aug 2021 13:06:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=I7AE6JNcfye2uRjCkzeW1VdTKMTfLS0Wyak3wfr5kuo=; b=AatWyIZ7vpjonfzFnE+8Dt+VzIWSjorrqrbVMpbOEy+V75ZQowmJx5lA+0wnxcQ8Xs hp8HnBnaX2FyUoNi0WWMYLuIupHobMSUyg5DppcY+wvc4ehuaVnzJ+yBSLaat+V5qhH7 yBTN5SFdHm2NgU0UfBgwGigJJJlFHBqtnAwqiU86lmg+CBPCLS4VQ1afG/KK9r56wyL/ 7g9vB+zqd/50GaQ3u3wsH7WuQUTxvcz9vzvFzZi1MPW9YuyrNNw/qLatSVbLa4N4SSbo MomIhDRjUGqpTzcCV4poc1XJoxzG/Yyr04Q4mtIit7Mw6Pcc9CaJFoOfVmClF+deoT4e ZLbg== X-Gm-Message-State: AOAM530M67wqmghf0W+RICyUXwCGVM8Z8TUZIJQ7uSkTevURk47xDcIp K92ulHoWgkqWWzp37K6QYNiYkTk/sA== X-Google-Smtp-Source: ABdhPJx45qTlxFXvskqD8CsOdV5Lsk85htt4XAImBruvawSuYM2eiuu+YFIEi+x+X4ZA6xHLMV+wzQ== X-Received: by 2002:a9d:6192:: with SMTP id g18mr26182717otk.314.1630440403216; Tue, 31 Aug 2021 13:06:43 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id 65sm2815782otc.32.2021.08.31.13.06.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 13:06:42 -0700 (PDT) Received: (nullmailer pid 569553 invoked by uid 1000); Tue, 31 Aug 2021 20:06:41 -0000 Date: Tue, 31 Aug 2021 15:06:41 -0500 From: Rob Herring To: Sean Anderson Cc: Shubhrajyoti Datta , Michal Simek , Greg Kroah-Hartman , Peter Korsgaard , devicetree@vger.kernel.org, linux-serial@vger.kernel.org, Alexander Sverdlin , Peter Korsgaard Subject: Re: [PATCH v3 2/4] dt-bindings: serial: uartlite: Add properties for synthesis-time parameters Message-ID: References: <20210826192154.3202269-1-sean.anderson@seco.com> <20210826192154.3202269-3-sean.anderson@seco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210826192154.3202269-3-sean.anderson@seco.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 26 Aug 2021 15:21:52 -0400, Sean Anderson wrote: > The uartlite device is a "soft" device. Many parameters, such as baud > rate, data bits, and the presence of a parity bit are configured before > synthesis and may not be changed (or discovered) at runtime. However, we > must know what these settings are in order to properly calculate the > uart timeout (and to inform the user about the actual baud of the uart). > > These properties are present for out-of-tree bindings generated by > Xilinx's tools. However, they are also (mostly) present in in-tree > bindings. I chose current-speed over xlnx,baudrate primarily because it > seemed to be used by more existing bindings. Although these properties > are marked as "required", note that only current-speed is required by > the driver itself. Hopefully, this will allow for an easier transition. > > Signed-off-by: Sean Anderson > --- > > Changes in v3: > - Removed defaults for required properties > > .../bindings/serial/xlnx,opb-uartlite.yaml | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > Reviewed-by: Rob Herring