From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AADD5C432BE for ; Tue, 31 Aug 2021 22:06:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8461360F6C for ; Tue, 31 Aug 2021 22:06:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237918AbhHaWHB (ORCPT ); Tue, 31 Aug 2021 18:07:01 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:50832 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230085AbhHaWHA (ORCPT ); Tue, 31 Aug 2021 18:07:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=nvErR40qfu1kFHYvqRKQ6/X+/HW+U8tJ8ybWTvE/KVQ=; b=pwBjBgmSmIucoQsPZR0eQWjlXc n1WHhMUfOJJghCBhuolPMcyhyzDZaBjgufGu8tvEU+7H92a3OhbuTs38SwifTtFq7pZs8I7NW7kGg dnG+v+mHgmGIoL+eHjwCoqDKFrh7AO5mXKS/lx7dMHRpZVtZooAy1+m/R6iuw0bf2AQU=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mLBtE-004lbS-9m; Wed, 01 Sep 2021 00:05:56 +0200 Date: Wed, 1 Sep 2021 00:05:56 +0200 From: Andrew Lunn To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Linus Walleij , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Len Brown , Alvin Sipraga , kernel-team@android.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v1 1/2] driver core: fw_devlink: Add support for FWNODE_FLAG_BROKEN_PARENT Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Aug 31, 2021 at 12:26:30PM -0700, Saravana Kannan wrote: > On Tue, Aug 31, 2021 at 6:16 AM Andrew Lunn wrote: > > > > > > I must admit, my main problem at the moment is -rc1 in two weeks > > > > time. It seems like a number of board with Ethernet switches will be > > > > broken, that worked before. phy-handle is not limited to switch > > > > drivers, it is also used for Ethernet drivers. So it could be, a > > > > number of Ethernet drivers are also going to be broken in -rc1? > > > > > > Again, in those cases, based on your FEC example, fw_devlink=on > > > actually improves things. > > > > Debatable. I did some testing. As expected some boards with Ethernet > > switches are now broken. > > To clarify myself, I'm saying the patch to parse "ethernet" [8] will > make things better with fw_devlink=on for FEC. Not sure if you tested > that patch or not. Yes and no. I was tested with the FEC, but because of fw_devlink=on, the switches don't probe correctly. So it is not possible to see if it helped or not, since its plain broken. > Not sure what was the tip of the tree with which you bisected. I manually tested linux-next, v5.14, v5.13 and v5.12 and then bisected: $ git bisect log git bisect start # good: [9f4ad9e425a1d3b6a34617b8ea226d56a119a717] Linux 5.12 git bisect good 9f4ad9e425a1d3b6a34617b8ea226d56a119a717 # bad: [62fb9874f5da54fdb243003b386128037319b219] Linux 5.13 So well away from linux-next which contains the phy-handle parser. I will try to give the two patches a try today or tomorrow. > Thanks for testing it out. And worst case, we'll revert phy-handle > support. Which is not enough to fix these Ethernet switches. Andrew