From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3609C432BE for ; Wed, 1 Sep 2021 13:28:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C642D610A2 for ; Wed, 1 Sep 2021 13:28:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244154AbhIAN3P (ORCPT ); Wed, 1 Sep 2021 09:29:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:37770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244113AbhIAN3O (ORCPT ); Wed, 1 Sep 2021 09:29:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B392461026; Wed, 1 Sep 2021 13:28:16 +0000 (UTC) Date: Wed, 1 Sep 2021 14:28:14 +0100 From: Catalin Marinas To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , linux-kernel@vger.kernel.org, Mark Rutland Subject: Re: [PATCH V2] arm64/mm: Drop Message-ID: References: <1629457516-32306-1-git-send-email-anshuman.khandual@arm.com> <20210820183520.GC23080@arm.com> <84b647b6-9cee-5aad-78f8-7bc253300534@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84b647b6-9cee-5aad-78f8-7bc253300534@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 31, 2021 at 09:15:30AM +0530, Anshuman Khandual wrote: > On 8/21/21 12:05 AM, Catalin Marinas wrote: > > On Fri, Aug 20, 2021 at 04:35:16PM +0530, Anshuman Khandual wrote: > >> PAGE_SHIFT (PAGE_SIZE and PAGE_MASK) which is derived from ARM64_PAGE_SHIFT > >> should be moved into instead like in case for other platforms, > >> and then subsequently can be just dropped off completely. > > > > These were moved to page-def.h as part of commit b6531456ba27 ("arm64: > > factor out PAGE_* and CONT_* definitions") to avoid some circular header > > dependencies. > > > >> diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h > >> index 824a3655dd93..649d26396f9e 100644 > >> --- a/arch/arm64/include/asm/memory.h > >> +++ b/arch/arm64/include/asm/memory.h > >> @@ -12,7 +12,7 @@ > >> > >> #include > >> #include > >> -#include > >> +#include > > > > In 5.14-rc3, asm/page.h still includes asm/memory.h. > > Dropping from does not seem to cause > any problem, will change that. Afterwards build tested it across > page sizes and also with some random configs. Is that circular > dependency still present ? Also wondering why was > included in to begin with ? asm/memory.h is not included by any of the generic files, however it has essential definitions like PAGE_OFFSET, THREAD_SIZE. The expectations from the arch code is to have these defined in asm/page.h (see the asm-generic/page.h), hence the inclusion. It probably gets included by other arch headers and that's why you don't get any errors, but I wouldn't rely on this. I don't remember how we ended up with a separate memory.h file. On arm64 we inherited it from arch/arm. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3783DC432BE for ; Wed, 1 Sep 2021 13:30:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA27761026 for ; Wed, 1 Sep 2021 13:30:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EA27761026 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8go9BoTxY4gXGNQthmwRlSPHPMq53yvijh7WJa77sLY=; b=czvWjQx/re2v6f nswtkywytWcjbqLk9J1jnZIisMwPlvT5l+MrQl6CA3ivdV9enc9gjYtr3bpFjxdkDMD8I4DNvi2+v 40mwmlR1vI1RGgJg9KjP6mIY65/rpMJ0+4RAssyXnxur6LGwcleQmV7NPeTBUanDCdgjfjsaRTniv Q8KlEuzS2+w5LHI5kHKiFJQqviy4xXT28jmS92/T733+hQDITe7evjxevvBsFraXGUUI8EnfJTvO/ Qw/CdcMkJGS7955K/Im8Fz4qfUim5N6PXbstilsMCPT3HC0i8w9C0JA79hsn7QrY1YoAdoE7g5oof MKZQeFOgGyUBUQb6aysQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLQHt-0068Vt-IV; Wed, 01 Sep 2021 13:28:21 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLQHq-0068VG-1R for linux-arm-kernel@lists.infradead.org; Wed, 01 Sep 2021 13:28:19 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B392461026; Wed, 1 Sep 2021 13:28:16 +0000 (UTC) Date: Wed, 1 Sep 2021 14:28:14 +0100 From: Catalin Marinas To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , linux-kernel@vger.kernel.org, Mark Rutland Subject: Re: [PATCH V2] arm64/mm: Drop Message-ID: References: <1629457516-32306-1-git-send-email-anshuman.khandual@arm.com> <20210820183520.GC23080@arm.com> <84b647b6-9cee-5aad-78f8-7bc253300534@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <84b647b6-9cee-5aad-78f8-7bc253300534@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210901_062818_165223_B8E745BE X-CRM114-Status: GOOD ( 19.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 31, 2021 at 09:15:30AM +0530, Anshuman Khandual wrote: > On 8/21/21 12:05 AM, Catalin Marinas wrote: > > On Fri, Aug 20, 2021 at 04:35:16PM +0530, Anshuman Khandual wrote: > >> PAGE_SHIFT (PAGE_SIZE and PAGE_MASK) which is derived from ARM64_PAGE_SHIFT > >> should be moved into instead like in case for other platforms, > >> and then subsequently can be just dropped off completely. > > > > These were moved to page-def.h as part of commit b6531456ba27 ("arm64: > > factor out PAGE_* and CONT_* definitions") to avoid some circular header > > dependencies. > > > >> diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h > >> index 824a3655dd93..649d26396f9e 100644 > >> --- a/arch/arm64/include/asm/memory.h > >> +++ b/arch/arm64/include/asm/memory.h > >> @@ -12,7 +12,7 @@ > >> > >> #include > >> #include > >> -#include > >> +#include > > > > In 5.14-rc3, asm/page.h still includes asm/memory.h. > > Dropping from does not seem to cause > any problem, will change that. Afterwards build tested it across > page sizes and also with some random configs. Is that circular > dependency still present ? Also wondering why was > included in to begin with ? asm/memory.h is not included by any of the generic files, however it has essential definitions like PAGE_OFFSET, THREAD_SIZE. The expectations from the arch code is to have these defined in asm/page.h (see the asm-generic/page.h), hence the inclusion. It probably gets included by other arch headers and that's why you don't get any errors, but I wouldn't rely on this. I don't remember how we ended up with a separate memory.h file. On arm64 we inherited it from arch/arm. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel