From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1544AC43214 for ; Wed, 1 Sep 2021 10:31:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF41E60F90 for ; Wed, 1 Sep 2021 10:31:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235072AbhIAKcj (ORCPT ); Wed, 1 Sep 2021 06:32:39 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:44328 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231612AbhIAKci (ORCPT ); Wed, 1 Sep 2021 06:32:38 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id C2DFD202B3; Wed, 1 Sep 2021 10:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1630492300; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EO3JsQqvzkTHmENKGP7Sv2zsa9Ofobc6JGxvJ/VjjBE=; b=TAZQ9GQ46WKV1lDwWzq/TwKyqgsnYxzNbxk/WDr4KnUScH5O/iNRJkpMy5obw1wL5X2/7/ gzUfhgCX/qs/TY9bn6b8o/2SBA+s0m5gvT8GlrJ2hh63mneZ3HPG3NseoVFX3gwA97wftB ZDl+K3uGckg21CEEEBlDSGeDpU7LOtQ= Received: from suse.cz (unknown [10.100.201.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id DBD4AA3B95; Wed, 1 Sep 2021 10:31:39 +0000 (UTC) Date: Wed, 1 Sep 2021 12:31:36 +0200 From: Michal Hocko To: Oleksandr Natalenko Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Matthew Wilcox , Greg Kroah-Hartman , Miaohe Lin , Mel Gorman , Stephen Rothwell Subject: Re: [RFC PATCH 1/1] mm: provide one common K(x) macro Message-ID: References: <20210901092149.994791-1-oleksandr@natalenko.name> <20210901092149.994791-2-oleksandr@natalenko.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210901092149.994791-2-oleksandr@natalenko.name> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 01-09-21 11:21:49, Oleksandr Natalenko wrote: > There are various places where the K(x) macro is defined. This commit > gets rid of multiple definitions and provides a common one. > > This doesn't solve open-coding this macro in various other places. This > should be addressed by another subsequent commit. Why is this an improvement? You are adding a header file for a single macro which sounds like an overkill. The overall net outcome is added lines of code. It is not like K() or any of its variant is adding a maintenance burden due to code duplication. So why do we want to change the existing state? -- Michal Hocko SUSE Labs