From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F183C4338F for ; Mon, 23 Aug 2021 12:12:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 349376137B for ; Mon, 23 Aug 2021 12:12:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236509AbhHWMNZ (ORCPT ); Mon, 23 Aug 2021 08:13:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:44214 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235095AbhHWMNY (ORCPT ); Mon, 23 Aug 2021 08:13:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A237B6138F; Mon, 23 Aug 2021 12:12:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629720761; bh=yOn8Q96b3ZWPNpYdY73Ssh2UrArfVzWgJCKc29O5j8g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h3GgEMa+cB1Q418qtCyrUcTzEKX36r5L7sd7nCAiC/9ImMWFd0nmCjCukyi1ziZRU HjB886n3odrZKnxNssvJEZ+Mh+uqujyY7PPc5hCD6dhnvbtI3rdTz/J2G3JsNGrKyq PyjavIB4RRcCGvybOt8vHd6yG0zZHquwt5srmzSIkBNL3wHp9TV3leuANMcvnl1hPV lQL2YKNE3hkLCOVok8JUaPAh3Yf6kxWRv+cz1MynkaQu3v5wLw6uu71hvOVLG/1GI5 fsmZS9B3FHukpjwbMYj4uo8OCQc5JJUFmL2KpR2+Do/AzYRCLDKp9+iXdJ9+ZKun86 8X0iK4iUzUVlQ== Date: Mon, 23 Aug 2021 17:42:37 +0530 From: Vinod Koul To: Bard Liao Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, srinivas.kandagatla@linaro.org, rander.wang@linux.intel.com, pierre-louis.bossart@linux.intel.com, sanyog.r.kale@intel.com, bard.liao@intel.com Subject: Re: [PATCH v2 0/3] soundwire: intel: exit clock-stop mode before system suspend Message-ID: References: <20210818024954.16873-1-yung-chuan.liao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210818024954.16873-1-yung-chuan.liao@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18-08-21, 10:49, Bard Liao wrote: > Intel validation reported an issue where the HW_RST self-clearing bit > is not cleared in hardware, which as a ripple effect creates issues > with the clock stop mode. > > This happens is a specific sequence where the Intel manager is > pm_runtime suspended with the clock-stop mode enabled. During the > system suspend, we currently do nothing, which can lead to potential > issues on system resume and the following pm_runtime suspend, > depending on the hardware state. > > This patch suggests a full resume if the clock-stop mode is used. This > may require extra time but will make the suspend/resume flows > completely symmetric. This also removes a race condition where we > could not access SHIM registers if the parent was suspended as > well. Resuming the link also resumes the parent by construction. Applied all, thanks -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FE2CC432BE for ; Mon, 23 Aug 2021 12:13:56 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B607661391 for ; Mon, 23 Aug 2021 12:13:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B607661391 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C254F851; Mon, 23 Aug 2021 14:13:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C254F851 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1629720833; bh=yOn8Q96b3ZWPNpYdY73Ssh2UrArfVzWgJCKc29O5j8g=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=QpR0+AbS0ReFodYxgcCkpBzOM6exShAVi7KDEj1Oya6UL1ww324OHgmvnJ2kbA3w4 5iDgsjIXYk1reYniEPo5Bd3aCjRQ7/JaPhiGfsv1pMEEMPvQJjpHAzGCmWsSxoSdQr U/sFK1vjZ8E4eTu5bLAqBsdPKbrm6aXwD/RfLQtA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 291F8F8016E; Mon, 23 Aug 2021 14:13:03 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B1449F800B6; Mon, 23 Aug 2021 14:12:47 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 55ADFF800B6 for ; Mon, 23 Aug 2021 14:12:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 55ADFF800B6 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="h3GgEMa+" Received: by mail.kernel.org (Postfix) with ESMTPSA id A237B6138F; Mon, 23 Aug 2021 12:12:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629720761; bh=yOn8Q96b3ZWPNpYdY73Ssh2UrArfVzWgJCKc29O5j8g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=h3GgEMa+cB1Q418qtCyrUcTzEKX36r5L7sd7nCAiC/9ImMWFd0nmCjCukyi1ziZRU HjB886n3odrZKnxNssvJEZ+Mh+uqujyY7PPc5hCD6dhnvbtI3rdTz/J2G3JsNGrKyq PyjavIB4RRcCGvybOt8vHd6yG0zZHquwt5srmzSIkBNL3wHp9TV3leuANMcvnl1hPV lQL2YKNE3hkLCOVok8JUaPAh3Yf6kxWRv+cz1MynkaQu3v5wLw6uu71hvOVLG/1GI5 fsmZS9B3FHukpjwbMYj4uo8OCQc5JJUFmL2KpR2+Do/AzYRCLDKp9+iXdJ9+ZKun86 8X0iK4iUzUVlQ== Date: Mon, 23 Aug 2021 17:42:37 +0530 From: Vinod Koul To: Bard Liao Subject: Re: [PATCH v2 0/3] soundwire: intel: exit clock-stop mode before system suspend Message-ID: References: <20210818024954.16873-1-yung-chuan.liao@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210818024954.16873-1-yung-chuan.liao@linux.intel.com> Cc: alsa-devel@alsa-project.org, gregkh@linuxfoundation.org, pierre-louis.bossart@linux.intel.com, linux-kernel@vger.kernel.org, sanyog.r.kale@intel.com, rander.wang@linux.intel.com, bard.liao@intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 18-08-21, 10:49, Bard Liao wrote: > Intel validation reported an issue where the HW_RST self-clearing bit > is not cleared in hardware, which as a ripple effect creates issues > with the clock stop mode. > > This happens is a specific sequence where the Intel manager is > pm_runtime suspended with the clock-stop mode enabled. During the > system suspend, we currently do nothing, which can lead to potential > issues on system resume and the following pm_runtime suspend, > depending on the hardware state. > > This patch suggests a full resume if the clock-stop mode is used. This > may require extra time but will make the suspend/resume flows > completely symmetric. This also removes a race condition where we > could not access SHIM registers if the parent was suspended as > well. Resuming the link also resumes the parent by construction. Applied all, thanks -- ~Vinod