Re: [PATCH v5 10/12] x86/tdx: Add MSR support for TDX guest

From: Borislav Petkov <bp@alien8.de>
To: Kuppuswamy Sathyanarayanan  <sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Andy Lutomirski <luto@kernel.org>, Peter H Anvin <hpa@zytor.com>,
	Dave Hansen <dave.hansen@intel.com>,
	Tony Luck <tony.luck@intel.com>,
	Dan Williams <dan.j.williams@intel.com>,
	Andi Kleen <ak@linux.intel.com>,
	Kirill Shutemov <kirill.shutemov@linux.intel.com>,
	Sean Christopherson <seanjc@google.com>,
	Kuppuswamy Sathyanarayanan <knsathya@kernel.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 10/12] x86/tdx: Add MSR support for TDX guest
Date: Tue, 24 Aug 2021 18:55:05 +0200	[thread overview]
Message-ID: <YSUkaUQtUpqAXCVd@zn.tnic> (raw)
In-Reply-To: <20210804181329.2899708-11-sathyanarayanan.kuppuswamy@linux.intel.com>

On Wed, Aug 04, 2021 at 11:13:27AM -0700, Kuppuswamy Sathyanarayanan wrote:
>  int tdg_handle_virtualization_exception(struct pt_regs *regs,
>  					struct ve_info *ve)
>  {
> +	unsigned long val;
> +	int ret = 0;
> +
>  	switch (ve->exit_reason) {
>  	case EXIT_REASON_HLT:
>  		tdg_halt();
>  		break;
> +	case EXIT_REASON_MSR_READ:
> +		val = tdg_read_msr_safe(regs->cx, (unsigned int *)&ret);
> +		if (!ret) {
> +			regs->ax = val & UINT_MAX;

			regs->ax = (u32)val;

> +			regs->dx = val >> 32;
> +		}
> +		break;
> +	case EXIT_REASON_MSR_WRITE:
> +		ret = tdg_write_msr_safe(regs->cx, regs->ax, regs->dx);
> +		break;
>  	default:
>  		pr_warn("Unexpected #VE: %lld\n", ve->exit_reason);
>  		return -EFAULT;
>  	}
>  
>  	/* After successful #VE handling, move the IP */
> -	regs->ip += ve->instr_len;
> +	if (!ret)
> +		regs->ip += ve->instr_len;
>  
> -	return 0;
> +	return ret;
>  }
>  
>  void __init tdx_early_init(void)
> -- 

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette