Re: [PATCH] USB: serial: iuu_phoenix: Replace symbolic permissions by octal permissions

From: Johan Hovold <johan@kernel.org>
To: Utkarsh Verma <utkarshverma294@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: Re: [PATCH] USB: serial: iuu_phoenix: Replace symbolic permissions by octal permissions
Date: Wed, 25 Aug 2021 11:24:44 +0200	[thread overview]
Message-ID: <YSYMXNvfjk0HdYr3@hovoldconsulting.com> (raw)
In-Reply-To: <20210824191537.GA6181@uver-laptop>

On Wed, Aug 25, 2021 at 12:45:37AM +0530, Utkarsh Verma wrote:
> On Tue, Aug 24, 2021 at 03:55:41PM +0200, Johan Hovold wrote:
> > On Sat, Aug 21, 2021 at 12:33:06AM +0530, Utkarsh Verma wrote:
> > > This fixed the below checkpatch issue:
> > > WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred.
> > > Consider using octal permissions '0644'.
> > 
> > Please do not run checkpatch.pl on code that's already in the tree. Use
> > it for your own patches before submitting them and always use your own
> > judgement when considering its suggestions.
> > 
> 
> Okay, I will not run checkpatch on the code that's already in the tree.
> 
> > This code does not need to be changed.
> 
> But using the octal permission bits makes the code more readable. So I
> made the change.

Then put that in the commit message since that may be a valid motivation
for the change (unlike shutting up checkpatch.pl).

But if you want to do this then do it subsystem wide in one patch rather
than change only one of the seven usb-serial drivers that use the
permission macros.

Johan