From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 563D0C432BE for ; Wed, 25 Aug 2021 23:11:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 396FF610C8 for ; Wed, 25 Aug 2021 23:11:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233332AbhHYXMi (ORCPT ); Wed, 25 Aug 2021 19:12:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233329AbhHYXMi (ORCPT ); Wed, 25 Aug 2021 19:12:38 -0400 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 018A8C0613C1 for ; Wed, 25 Aug 2021 16:11:52 -0700 (PDT) Received: by mail-oi1-x236.google.com with SMTP id w19so1666662oik.10 for ; Wed, 25 Aug 2021 16:11:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=QtXruHF4bnU6OyDGPGjhakaBMSfcI7KwDzUGtKN2MR0=; b=LSQ+Qs6HQ2tLgxADlDiknTiMlunVRVb2oTaqttGBCOLAy9cTuB2yKsogtfZ8PG903O h5M4uHZCfTCPEuGn7ae6aRomz+teFyOfwAahWuOVl0gm1XPoAx+WvuUlkgUfrzsn0Id7 CFrxc8Q0QMTEBu528ANT70QfY/opiUACSIL1COUemir8eKja0ZTWsAzP7Oa07wR0hm1a nLkMWdmsttzoVcCUK3Qb8RLDR6lRWrUQ0Zj9YaiEgYAJ7ztDcSfp5MR4FZhS1DY6ygcR WA5rYjmlAuOugXKoPtKAfIFNkysDmGpBisdF8/Fayee8kQNXGIRAvBgw9C1nOlVy0aO6 +GZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=QtXruHF4bnU6OyDGPGjhakaBMSfcI7KwDzUGtKN2MR0=; b=uBGXnTqasD0AVQnjlo0WKOHhK6l8us7TRVCt2z0l0tVNPxw5F7ZVe1Qv9ONFenApgr RRDTmEG3qiZgMutIH258x2FSIxwICvR4yhIfPqG/+sTNIxziqDh/9VOPDdCfSbUIJIQs 83T7hDuJfdX8jNBSET58MxltalNZ2AQzXdKng/UQCKMutDuQt7/UjkVvJa3/VJns8mYJ u1mjlkkTb11103yfrSnkXEzuUtLZMtx8pSwPN2lM/7S+QKv8CGG2Y3yH8Q9OFpwIkdv/ 65dzpZi9f11iNCFQYJS9F+Z4uTWUYg1FpyL33XMqAKMTsh8Qt079UxGX325W4BXwUk9o Acnw== X-Gm-Message-State: AOAM533IS2KmcRaG1cV16c4fSre1HnPCUnGemeMuYQmCfiRmsAVLoV09 NCjgQjmz/V4Pq1kLN0KSkosamg== X-Google-Smtp-Source: ABdhPJwWtrUIdXOLEe63DVJX0W3pVBZSObgJ/P3jgP1myOd0+jMUDpnSf5bYJKY/guCKP8rvzghCnA== X-Received: by 2002:a05:6808:21a5:: with SMTP id be37mr326536oib.172.1629933111367; Wed, 25 Aug 2021 16:11:51 -0700 (PDT) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id l67sm265529otl.3.2021.08.25.16.11.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Aug 2021 16:11:50 -0700 (PDT) Date: Wed, 25 Aug 2021 18:11:48 -0500 From: Bjorn Andersson To: sbillaka@codeaurora.org Cc: Stephen Boyd , dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, robdclark@gmail.com, seanpaul@chromium.org, kalyan_t@codeaurora.org, abhinavk@codeaurora.org, dianders@chromium.org, khsieh@codeaurora.org, mkrishn@codeaurora.org Subject: Re: [PATCH v1 1/2] drm/msm/dp: Add support for SC7280 eDP Message-ID: References: <1628726882-27841-1-git-send-email-sbillaka@codeaurora.org> <1628726882-27841-2-git-send-email-sbillaka@codeaurora.org> <0b2aa426c8f511a29143f2a1117fe9a2@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0b2aa426c8f511a29143f2a1117fe9a2@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu 12 Aug 19:28 CDT 2021, sbillaka@codeaurora.org wrote: > On 2021-08-12 06:11, Stephen Boyd wrote: > > Quoting Sankeerth Billakanti (2021-08-11 17:08:01) [..] > > > +static int dp_parser_gpio(struct dp_parser *parser) > > > +{ > > > + struct device *dev = &parser->pdev->dev; > > > + int ret; > > > + > > > + parser->panel_bklt_gpio = devm_gpiod_get(dev, "panel-bklt", > > > + GPIOD_OUT_HIGH); > > > + if (IS_ERR(parser->panel_bklt_gpio)) { > > > + ret = PTR_ERR(parser->panel_bklt_gpio); > > > + parser->panel_bklt_gpio = NULL; > > > + DRM_ERROR("%s: cannot get panel-bklt gpio, %d\n", > > > __func__, ret); > > > + goto fail; > > > + } > > > + > > > + parser->panel_pwm_gpio = devm_gpiod_get(dev, "panel-pwm", > > > GPIOD_OUT_HIGH); > > > + if (IS_ERR(parser->panel_pwm_gpio)) { > > > + ret = PTR_ERR(parser->panel_pwm_gpio); > > > + parser->panel_pwm_gpio = NULL; > > > + DRM_ERROR("%s: cannot get panel-pwm gpio, %d\n", > > > __func__, ret); > > > + goto fail; > > > + } > > > + > > > + DRM_INFO("gpio on"); > > > +fail: > > > + return 0; > > > +} > > > > Don't we have pwm backlight drivers like > > drivers/video/backlight/pwm_bl.c to support this? This sort of thing > > doesn't belong in the dp driver. > > Okay. I will explore it. > I proposed that we attach a drm_panel and allow that to control the (pwm-)backlight. Here's the link for the DP patch: https://lore.kernel.org/linux-arm-msm/20210726231351.655302-1-bjorn.andersson@linaro.org/ Regards, Bjorn