From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4728C43216 for ; Thu, 26 Aug 2021 09:14:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9706F610CE for ; Thu, 26 Aug 2021 09:14:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236489AbhHZJPC (ORCPT ); Thu, 26 Aug 2021 05:15:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240933AbhHZJO7 (ORCPT ); Thu, 26 Aug 2021 05:14:59 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB59CC0613CF for ; Thu, 26 Aug 2021 02:14:11 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id f10so1394894wml.2 for ; Thu, 26 Aug 2021 02:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=ubJENgQIOzugIH6aIzu4aa5SOJeA5cH0TBu7UkdkwRo=; b=eWRM7qqism/66evB0/Z4A1uCvrnvkvTzAGwtb+rUwe1sPIN2AMyEYIn4BzeKGJqUoC JGhvessjn+k+1RDfzALVQ7b/43qoTxbHmhrfxabjnYDh33tDAFwtHDmh+cc99/k9KK+t 5e/Btgkaw0RYWxCnueUGZR0K4Rlqxa35b/K5k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=ubJENgQIOzugIH6aIzu4aa5SOJeA5cH0TBu7UkdkwRo=; b=uXXlQk92hdIxvpGlK/MFvand0cqObpQLpr3VPSXDolnxBYYkq06oEh9wtG19UppcpR +sSovio8vtkBuToip8toUPAWqdTxHbfjPbfd9MeUtXb/4cgHsC0ky5TFUCbASI1qIdiN rlJFLpaW7precTCyh8c4psHO8x9De9SPQX1WLxiWyC6puE92FyEO6M8bXYuop9+Nfr5l caoR/4b9r15dBLF0Llfnygc7ogj5/EPpxiudOcLapbY/qc7E/5Mugk3wCQCJrGhn5GAK K6YCcOv+Gm9vohrLhZlBgZVhVMPDuHlW8zzYmbh+dOlfNurcsZiYjVPeSxB5OZ4iAzO8 zZOw== X-Gm-Message-State: AOAM532bGufMcsXDyUaDMzIDCAHrblzV/uvbGIss5txlK3cqHIhS4sB4 nZurcn/LyZitTXeGwU8j6IJh2w== X-Google-Smtp-Source: ABdhPJykiq+3RMvVzHhR2iD4afcW8Q8OoeIr3XVAh723gjD1Rvwc9Ym8gi6QoDtjdhPbP2Ip1lCUVg== X-Received: by 2002:a1c:a903:: with SMTP id s3mr2538905wme.171.1629969250495; Thu, 26 Aug 2021 02:14:10 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id z137sm7917167wmc.14.2021.08.26.02.14.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Aug 2021 02:14:09 -0700 (PDT) Date: Thu, 26 Aug 2021 11:14:07 +0200 From: Daniel Vetter To: Ezequiel Garcia Cc: Daniel Vetter , Yunfei Dong , dri-devel , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Irui Wang , linux-media , devicetree , Linux Kernel Mailing List , linux-arm-kernel , srv_heupstream , "moderated list:ARM/Mediatek SoC support" , Project_Global_Chrome_Upstream_Group@mediatek.com, George Sun Subject: Re: [PATCH v5, 00/15] Using component framework to support multi hardware decode Message-ID: Mail-Followup-To: Ezequiel Garcia , Yunfei Dong , dri-devel , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Irui Wang , linux-media , devicetree , Linux Kernel Mailing List , linux-arm-kernel , srv_heupstream , "moderated list:ARM/Mediatek SoC support" , Project_Global_Chrome_Upstream_Group@mediatek.com, George Sun References: <20210811025801.21597-1-yunfei.dong@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.0-7-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 22, 2021 at 02:57:15PM -0300, Ezequiel Garcia wrote: > On Sun, 22 Aug 2021 at 13:50, Daniel Vetter wrote: > > > > On Wed, Aug 18, 2021 at 4:12 PM Ezequiel Garcia > > wrote: > > > > > > +danvet > > > > > > Hi, > > > > > > On Tue, 10 Aug 2021 at 23:58, Yunfei Dong wrote: > > > > > > > > This series adds support for multi hardware decode into mtk-vcodec, by first > > > > adding component framework to manage each hardware information: interrupt, > > > > clock, register bases and power. Secondly add core thread to deal with core > > > > hardware message, at the same time, add msg queue for different hardware > > > > share messages. Lastly, the architecture of different specs are not the same, > > > > using specs type to separate them. > > > > > > > > > > I don't think it's a good idea to introduce the component API in the > > > media subsystem. It doesn't seem to be maintained, IRC there's not even > > > a maintainer for it, and it has some issues that were never addressed. > > > > Defacto dri-devel folks are maintainer component.c, but also I'm not > > aware of anything missing there? > > > > A while ago, I tried to fix a crash in the Rockchip DRM driver > (I was then told there can be similar issues on the IMX driver too, > but I forgot the details of that). > > I sent a patchset trying to address it and got total silence back. > Although you could argue the issue is in how drivers use the component > API, AFAICR the abuse is spreaded across a few drivers, so it felt > more reasonable to improve the component API itself, instead of changing > all the drivers. > > See below: > > https://patchwork.kernel.org/project/linux-rockchip/cover/20200120170602.3832-1-ezequiel@collabora.com/ Patches get lost on the mailing list, and rockchip is one of the lesser maintained drivers. You need to ping this stuff. For bridge/panel I still think we should work towards removing component.c use from them. > > There has been discussions that in various drm subsystems like > > drm_bridge or drm_panel a few things are missing, which prevent > > drivers from moving _away_ from component.c to the more specific > > solutions for panel/bridges. But nothing that's preventing them from > > using component.c itself. > > > > I'm happy to merge a MAINTAINERS patch to clarify the situation if > > that's needed. > > Indeed, that would be good. Ok I'm going to type something. -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A343CC432BE for ; Thu, 26 Aug 2021 09:14:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73112610A3 for ; Thu, 26 Aug 2021 09:14:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 73112610A3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 909946E58A; Thu, 26 Aug 2021 09:14:13 +0000 (UTC) Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by gabe.freedesktop.org (Postfix) with ESMTPS id DD0946E588 for ; Thu, 26 Aug 2021 09:14:11 +0000 (UTC) Received: by mail-wm1-x330.google.com with SMTP id m25-20020a7bcb99000000b002e751bcb5dbso1730437wmi.5 for ; Thu, 26 Aug 2021 02:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=ubJENgQIOzugIH6aIzu4aa5SOJeA5cH0TBu7UkdkwRo=; b=eWRM7qqism/66evB0/Z4A1uCvrnvkvTzAGwtb+rUwe1sPIN2AMyEYIn4BzeKGJqUoC JGhvessjn+k+1RDfzALVQ7b/43qoTxbHmhrfxabjnYDh33tDAFwtHDmh+cc99/k9KK+t 5e/Btgkaw0RYWxCnueUGZR0K4Rlqxa35b/K5k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=ubJENgQIOzugIH6aIzu4aa5SOJeA5cH0TBu7UkdkwRo=; b=dmj4nARG8IxWZ6vkCGgg9/C18732dF5eqSGFlqi20LMHylpE7i6oIWnnQJo6mm/qWT x0eCwrc/67IiL/0ArBnzxnj/Jj/+9cuuUi5f3sFLUyzMVpuPn2H0s9uU9e6XgQeyajQX wlRbjftKfxLxlaDuAaLcILwNDbNegUfgwxOhdUM3090MPdJDc7tzhLSX5Cfyh73OrRok wgK92Dmv6j5SH9anaUBD9olrNuyEyPR9N25zEdBi2CRCoKmmKj5tcYfqoY71hnrbSGUb O75IPlG/P6EOvyG4msHTM2/uw5VHEIZRT5LlDwaRa9OYVQ5+9h9xIAmN/kIUtxTztz5a Rjiw== X-Gm-Message-State: AOAM530O4ql/eD7mlBgG5RbyFMllrRG1pTFVDvo1kUFhC9Ef5dU6iAmQ bt51jzH/ApdFp+75UCLofyKdORM+mW0Ufw== X-Google-Smtp-Source: ABdhPJykiq+3RMvVzHhR2iD4afcW8Q8OoeIr3XVAh723gjD1Rvwc9Ym8gi6QoDtjdhPbP2Ip1lCUVg== X-Received: by 2002:a1c:a903:: with SMTP id s3mr2538905wme.171.1629969250495; Thu, 26 Aug 2021 02:14:10 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id z137sm7917167wmc.14.2021.08.26.02.14.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Aug 2021 02:14:09 -0700 (PDT) Date: Thu, 26 Aug 2021 11:14:07 +0200 From: Daniel Vetter To: Ezequiel Garcia Cc: Daniel Vetter , Yunfei Dong , dri-devel , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Irui Wang , linux-media , devicetree , Linux Kernel Mailing List , linux-arm-kernel , srv_heupstream , "moderated list:ARM/Mediatek SoC support" , Project_Global_Chrome_Upstream_Group@mediatek.com, George Sun Subject: Re: [PATCH v5, 00/15] Using component framework to support multi hardware decode Message-ID: Mail-Followup-To: Ezequiel Garcia , Yunfei Dong , dri-devel , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Irui Wang , linux-media , devicetree , Linux Kernel Mailing List , linux-arm-kernel , srv_heupstream , "moderated list:ARM/Mediatek SoC support" , Project_Global_Chrome_Upstream_Group@mediatek.com, George Sun References: <20210811025801.21597-1-yunfei.dong@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.0-7-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Aug 22, 2021 at 02:57:15PM -0300, Ezequiel Garcia wrote: > On Sun, 22 Aug 2021 at 13:50, Daniel Vetter wrote: > > > > On Wed, Aug 18, 2021 at 4:12 PM Ezequiel Garcia > > wrote: > > > > > > +danvet > > > > > > Hi, > > > > > > On Tue, 10 Aug 2021 at 23:58, Yunfei Dong wrote: > > > > > > > > This series adds support for multi hardware decode into mtk-vcodec, by first > > > > adding component framework to manage each hardware information: interrupt, > > > > clock, register bases and power. Secondly add core thread to deal with core > > > > hardware message, at the same time, add msg queue for different hardware > > > > share messages. Lastly, the architecture of different specs are not the same, > > > > using specs type to separate them. > > > > > > > > > > I don't think it's a good idea to introduce the component API in the > > > media subsystem. It doesn't seem to be maintained, IRC there's not even > > > a maintainer for it, and it has some issues that were never addressed. > > > > Defacto dri-devel folks are maintainer component.c, but also I'm not > > aware of anything missing there? > > > > A while ago, I tried to fix a crash in the Rockchip DRM driver > (I was then told there can be similar issues on the IMX driver too, > but I forgot the details of that). > > I sent a patchset trying to address it and got total silence back. > Although you could argue the issue is in how drivers use the component > API, AFAICR the abuse is spreaded across a few drivers, so it felt > more reasonable to improve the component API itself, instead of changing > all the drivers. > > See below: > > https://patchwork.kernel.org/project/linux-rockchip/cover/20200120170602.3832-1-ezequiel@collabora.com/ Patches get lost on the mailing list, and rockchip is one of the lesser maintained drivers. You need to ping this stuff. For bridge/panel I still think we should work towards removing component.c use from them. > > There has been discussions that in various drm subsystems like > > drm_bridge or drm_panel a few things are missing, which prevent > > drivers from moving _away_ from component.c to the more specific > > solutions for panel/bridges. But nothing that's preventing them from > > using component.c itself. > > > > I'm happy to merge a MAINTAINERS patch to clarify the situation if > > that's needed. > > Indeed, that would be good. Ok I'm going to type something. -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11E76C432BE for ; Thu, 26 Aug 2021 09:14:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2B686108E for ; Thu, 26 Aug 2021 09:14:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C2B686108E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nhF0Dkklq2toA1TCUCyF6kNbZ8pk328RGaEz10jgh3o=; b=Z2a/WR6hkTBEcn wGEAvkQ7vtq+PpcYnLg/UcMiyOK9huHb8zeMXZWuNGMZ+dJ6Evdf9ypijVEEVK1mRi+G2IlOOUzft QyKVO2q0flF7Io6jhzFveTaGBirkp71xVEify7uE7Uqot1/mT2forwJzZbAAXE7fZGMCxsdTDP62g h6GbUV1wIZaiGp+PiL7Dd53Q6SRnlvGmxybFhlXTN43zaW9kR4ylVc29620uB7djpLsu79VjCyr4R mThEqUG++XDAf0xVf6ikNCfSH3qNMyJtpMX0nvEzJxzAylgs7EE5XJUOQtl5i5UOWO5LbDr/U+VFH LXYYz6QMUrbgKDWCjcHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJBSk-009e1I-Bz; Thu, 26 Aug 2021 09:14:18 +0000 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJBSf-009dyp-F5 for linux-mediatek@lists.infradead.org; Thu, 26 Aug 2021 09:14:17 +0000 Received: by mail-wm1-x332.google.com with SMTP id d22-20020a1c1d16000000b002e7777970f0so6347233wmd.3 for ; Thu, 26 Aug 2021 02:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=ubJENgQIOzugIH6aIzu4aa5SOJeA5cH0TBu7UkdkwRo=; b=eWRM7qqism/66evB0/Z4A1uCvrnvkvTzAGwtb+rUwe1sPIN2AMyEYIn4BzeKGJqUoC JGhvessjn+k+1RDfzALVQ7b/43qoTxbHmhrfxabjnYDh33tDAFwtHDmh+cc99/k9KK+t 5e/Btgkaw0RYWxCnueUGZR0K4Rlqxa35b/K5k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=ubJENgQIOzugIH6aIzu4aa5SOJeA5cH0TBu7UkdkwRo=; b=FNbwmJ8z3wn2ip8Hhcc20+x0tlzhdgvboo8B364W8NkrAweKXaJAIa0jVFFvAW9C9q zHBNZHdFtCHQ6hNvAm2Pu7eHCTIzs6Z5HZFe2BhQnDCU23/8wSeC+uxEdEap1zIeXsWJ oDjXRO3KO+AoycXvsulfgsOjflJpRPGDiMB4crQQ8XBvHPMywSugnqg/KQvw8STPHq1B k3TMEEbT+WujKvqrB0QCSiDXOWdWsw64Ys90dc04Pa80OxLKZY7orkH1WK6n+tLpBUFy DMaXh6PMrmHajV5HA+TOpCuuaRYMjWHk5cpZgIExS6UhiNTPY830NjbIlELaFUt5/3ww Zmlg== X-Gm-Message-State: AOAM532x3EeNKKlYxRNnWCHLVWMeEGVvCHCjVNxYgrBTfoxl8uNnNyq+ omr98AIGMzdtzBydEhv5MQpEow== X-Google-Smtp-Source: ABdhPJykiq+3RMvVzHhR2iD4afcW8Q8OoeIr3XVAh723gjD1Rvwc9Ym8gi6QoDtjdhPbP2Ip1lCUVg== X-Received: by 2002:a1c:a903:: with SMTP id s3mr2538905wme.171.1629969250495; Thu, 26 Aug 2021 02:14:10 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id z137sm7917167wmc.14.2021.08.26.02.14.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Aug 2021 02:14:09 -0700 (PDT) Date: Thu, 26 Aug 2021 11:14:07 +0200 From: Daniel Vetter To: Ezequiel Garcia Cc: Daniel Vetter , Yunfei Dong , dri-devel , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Irui Wang , linux-media , devicetree , Linux Kernel Mailing List , linux-arm-kernel , srv_heupstream , "moderated list:ARM/Mediatek SoC support" , Project_Global_Chrome_Upstream_Group@mediatek.com, George Sun Subject: Re: [PATCH v5, 00/15] Using component framework to support multi hardware decode Message-ID: Mail-Followup-To: Ezequiel Garcia , Yunfei Dong , dri-devel , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Irui Wang , linux-media , devicetree , Linux Kernel Mailing List , linux-arm-kernel , srv_heupstream , "moderated list:ARM/Mediatek SoC support" , Project_Global_Chrome_Upstream_Group@mediatek.com, George Sun References: <20210811025801.21597-1-yunfei.dong@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.0-7-amd64 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210826_021413_560392_11F8F81E X-CRM114-Status: GOOD ( 37.62 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sun, Aug 22, 2021 at 02:57:15PM -0300, Ezequiel Garcia wrote: > On Sun, 22 Aug 2021 at 13:50, Daniel Vetter wrote: > > > > On Wed, Aug 18, 2021 at 4:12 PM Ezequiel Garcia > > wrote: > > > > > > +danvet > > > > > > Hi, > > > > > > On Tue, 10 Aug 2021 at 23:58, Yunfei Dong wrote: > > > > > > > > This series adds support for multi hardware decode into mtk-vcodec, by first > > > > adding component framework to manage each hardware information: interrupt, > > > > clock, register bases and power. Secondly add core thread to deal with core > > > > hardware message, at the same time, add msg queue for different hardware > > > > share messages. Lastly, the architecture of different specs are not the same, > > > > using specs type to separate them. > > > > > > > > > > I don't think it's a good idea to introduce the component API in the > > > media subsystem. It doesn't seem to be maintained, IRC there's not even > > > a maintainer for it, and it has some issues that were never addressed. > > > > Defacto dri-devel folks are maintainer component.c, but also I'm not > > aware of anything missing there? > > > > A while ago, I tried to fix a crash in the Rockchip DRM driver > (I was then told there can be similar issues on the IMX driver too, > but I forgot the details of that). > > I sent a patchset trying to address it and got total silence back. > Although you could argue the issue is in how drivers use the component > API, AFAICR the abuse is spreaded across a few drivers, so it felt > more reasonable to improve the component API itself, instead of changing > all the drivers. > > See below: > > https://patchwork.kernel.org/project/linux-rockchip/cover/20200120170602.3832-1-ezequiel@collabora.com/ Patches get lost on the mailing list, and rockchip is one of the lesser maintained drivers. You need to ping this stuff. For bridge/panel I still think we should work towards removing component.c use from them. > > There has been discussions that in various drm subsystems like > > drm_bridge or drm_panel a few things are missing, which prevent > > drivers from moving _away_ from component.c to the more specific > > solutions for panel/bridges. But nothing that's preventing them from > > using component.c itself. > > > > I'm happy to merge a MAINTAINERS patch to clarify the situation if > > that's needed. > > Indeed, that would be good. Ok I'm going to type something. -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F143C4320E for ; Thu, 26 Aug 2021 09:16:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 300F860524 for ; Thu, 26 Aug 2021 09:16:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 300F860524 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/f1G+ml8ZHLFb6Vs4Bg//6iax9pu6FedDbXoeFlnAYs=; b=eNKhA8swBHUXY1 HFrb2nttXrdk/pobWHR154hrPMZ0zKzsk/yg9/lsMEuqS5tAitwg04t08lNon63u5AYBUZIifRd51 C3gSrhhy6qEt7ytfjYIoRunjlJTisz36aFFm2+TfNhr09wXYZlU5AVKwRLmb2jz6gFHrpc91cISQO 48xNySPQMffN45qaiEki31t5kgvmzJyDdulLiw+W1oFSHv/3YuBSUHttlUludlBi9N9HnnswPwvIf LAiJ6+K2itdlnj1fQFWVNKy+kyPyswXaKIasm3iuTHEZSBZfKsAtqWq+x/1UDOXZ17eE1HoOeXlrd ftvpdY0IeVIsbqaf/OCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJBSm-009e1W-72; Thu, 26 Aug 2021 09:14:20 +0000 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJBSf-009dyq-EM for linux-arm-kernel@lists.infradead.org; Thu, 26 Aug 2021 09:14:17 +0000 Received: by mail-wm1-x32d.google.com with SMTP id f9-20020a05600c1549b029025b0f5d8c6cso6350856wmg.4 for ; Thu, 26 Aug 2021 02:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=ubJENgQIOzugIH6aIzu4aa5SOJeA5cH0TBu7UkdkwRo=; b=eWRM7qqism/66evB0/Z4A1uCvrnvkvTzAGwtb+rUwe1sPIN2AMyEYIn4BzeKGJqUoC JGhvessjn+k+1RDfzALVQ7b/43qoTxbHmhrfxabjnYDh33tDAFwtHDmh+cc99/k9KK+t 5e/Btgkaw0RYWxCnueUGZR0K4Rlqxa35b/K5k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=ubJENgQIOzugIH6aIzu4aa5SOJeA5cH0TBu7UkdkwRo=; b=QjQuoYbAT8o60/HCeny19S6RkIiKZ+gMy0a8H/OTwYscmlaqE0EMi3AjGvesHYFJOL qFqr88PNBW6Xw4Sa7XK6sd4iDrWLwxySxH6kijkZ/kKpayzcVxP/0BfZU4qIpAFxTPBR ZpUkvP9poXELyHvkIN1AaIsOeVSuMOU2IHnqBXJAbl9IOxisZsBYzHpwxAeojHjOPdYl /Fqr36BX5fYWywBjRMyv7JscwJRqHJymUjPUeLq2o/dXSDBJzRbuPjMRVDaiBqAspC1M pn/xbazGP0/Ea/q9Z6MB7lNjbvMmJivZYO0M7ZgeG77McTEBg8JT4AvXXmtv2fs2KKS+ GCwg== X-Gm-Message-State: AOAM5311eZIgf+dX7Dy36AfiiF2b5jVLG5axm3F1+rn163NvIS/xFu/K oXezd+SI6f5UegQAzzT0MEIMXQ== X-Google-Smtp-Source: ABdhPJykiq+3RMvVzHhR2iD4afcW8Q8OoeIr3XVAh723gjD1Rvwc9Ym8gi6QoDtjdhPbP2Ip1lCUVg== X-Received: by 2002:a1c:a903:: with SMTP id s3mr2538905wme.171.1629969250495; Thu, 26 Aug 2021 02:14:10 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id z137sm7917167wmc.14.2021.08.26.02.14.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Aug 2021 02:14:09 -0700 (PDT) Date: Thu, 26 Aug 2021 11:14:07 +0200 From: Daniel Vetter To: Ezequiel Garcia Cc: Daniel Vetter , Yunfei Dong , dri-devel , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Irui Wang , linux-media , devicetree , Linux Kernel Mailing List , linux-arm-kernel , srv_heupstream , "moderated list:ARM/Mediatek SoC support" , Project_Global_Chrome_Upstream_Group@mediatek.com, George Sun Subject: Re: [PATCH v5, 00/15] Using component framework to support multi hardware decode Message-ID: Mail-Followup-To: Ezequiel Garcia , Yunfei Dong , dri-devel , Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Irui Wang , linux-media , devicetree , Linux Kernel Mailing List , linux-arm-kernel , srv_heupstream , "moderated list:ARM/Mediatek SoC support" , Project_Global_Chrome_Upstream_Group@mediatek.com, George Sun References: <20210811025801.21597-1-yunfei.dong@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.10.0-7-amd64 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210826_021413_557088_69C5CF26 X-CRM114-Status: GOOD ( 38.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Aug 22, 2021 at 02:57:15PM -0300, Ezequiel Garcia wrote: > On Sun, 22 Aug 2021 at 13:50, Daniel Vetter wrote: > > > > On Wed, Aug 18, 2021 at 4:12 PM Ezequiel Garcia > > wrote: > > > > > > +danvet > > > > > > Hi, > > > > > > On Tue, 10 Aug 2021 at 23:58, Yunfei Dong wrote: > > > > > > > > This series adds support for multi hardware decode into mtk-vcodec, by first > > > > adding component framework to manage each hardware information: interrupt, > > > > clock, register bases and power. Secondly add core thread to deal with core > > > > hardware message, at the same time, add msg queue for different hardware > > > > share messages. Lastly, the architecture of different specs are not the same, > > > > using specs type to separate them. > > > > > > > > > > I don't think it's a good idea to introduce the component API in the > > > media subsystem. It doesn't seem to be maintained, IRC there's not even > > > a maintainer for it, and it has some issues that were never addressed. > > > > Defacto dri-devel folks are maintainer component.c, but also I'm not > > aware of anything missing there? > > > > A while ago, I tried to fix a crash in the Rockchip DRM driver > (I was then told there can be similar issues on the IMX driver too, > but I forgot the details of that). > > I sent a patchset trying to address it and got total silence back. > Although you could argue the issue is in how drivers use the component > API, AFAICR the abuse is spreaded across a few drivers, so it felt > more reasonable to improve the component API itself, instead of changing > all the drivers. > > See below: > > https://patchwork.kernel.org/project/linux-rockchip/cover/20200120170602.3832-1-ezequiel@collabora.com/ Patches get lost on the mailing list, and rockchip is one of the lesser maintained drivers. You need to ping this stuff. For bridge/panel I still think we should work towards removing component.c use from them. > > There has been discussions that in various drm subsystems like > > drm_bridge or drm_panel a few things are missing, which prevent > > drivers from moving _away_ from component.c to the more specific > > solutions for panel/bridges. But nothing that's preventing them from > > using component.c itself. > > > > I'm happy to merge a MAINTAINERS patch to clarify the situation if > > that's needed. > > Indeed, that would be good. Ok I'm going to type something. -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel