From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB41C432BE for ; Thu, 26 Aug 2021 15:58:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBAE561038 for ; Thu, 26 Aug 2021 15:58:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CBAE561038 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3l5/hQ5qg65XZBz+uLzysmfskIuEavaPzZE0fSg7RUM=; b=tMWuWsJWEGepe3w5xQMG0o/I+z McynYtvHTiq2QcP3wrxp6JZ88G4gNx/+w/5ao0P/F8BN5RXrHbfLmumskp7FBPVmiBYpqBypL3kus lDSX7LAXbujOqwGjzpxzEg7Tgr7CevcBfkRVPRuqI8z8fDE0Naiaj8Elh4wF8tfaqjiq+87sInZDD PN5ZLtn5aPo8iSTsa87Q5ADIKC46I4LUWoS9ZHQEIeT2pbhluOGsiNl+mJGZc/w0hfLcMZjGOWOIW /NMlU7o2p7bIS9WO9MjIycoW92OzKbfw/6BujzKwm6AoNfUkKzHophGeq3d8XxFhoF2kXDFgZnHz/ yFfxyZEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJHk0-00AWFG-H0; Thu, 26 Aug 2021 15:56:32 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJHjx-00AWF6-Nx for linux-arm-kernel@bombadil.infradead.org; Thu, 26 Aug 2021 15:56:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=YpAC7eKIN1Mk1gt9e5fi3Ne1IF3XO4Cc70sDdq2XPuo=; b=rZId7lOp2MXjym/SXNsq874jXF DLhwvjmKFrZQeBlXx5L3IYwuMc0ws8EFnHf7PuUTe4G8jOhoyjkbwZMUw0IEg0Itr1ULnD6/fTXzn MB4xwd4NIay98t4yONOt5htuj4UCvl1tlkN0h3n0a9aAvNhLxBxGrADVQCkgFA/292UiTaPesFOqc lxKNEIyjzvETNENQYG3xdG8Dvz1psJ52MC986Sa630PxMOy6ZiU0/2MyXPFZiLr1h25ITpnJqVrOH yzM6f/ch3BeO3RPOUgYg8W015b6GVuuy3pAMEReEyklNxqXZUxEz7FY/BdPOeNCmIa5ItWOf+Qdt8 XwcKDD/A==; Received: from heliosphere.sirena.org.uk ([172.104.155.198]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJHit-00DROj-VA for linux-arm-kernel@lists.infradead.org; Thu, 26 Aug 2021 15:55:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YpAC7eKIN1Mk1gt9e5fi3Ne1IF3XO4Cc70sDdq2XPuo=; b=Zza36yh1cVUFJ/wznsXo2osjWg qhweHSI/W3yFCGaHmPXuQQW6mCme31KjL5zFck+2gmfVyODZdylB4GOfU05DzYyjnfBF+FiNC1XzH 1J8Rx/0wxfA1WyyLrBq32bP9AJ6+KR3zbRA5QhoCxtpBGHrLC4ZuAbHTtDaflLgQNiLs=; Received: from 94.196.67.80.threembb.co.uk ([94.196.67.80] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mJHiM-00FUXp-QF; Thu, 26 Aug 2021 15:54:51 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id C7C89D01B81; Thu, 26 Aug 2021 16:46:34 +0100 (BST) Date: Thu, 26 Aug 2021 16:46:34 +0100 From: Mark Brown To: madvenka@linux.microsoft.com Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, jthierry@redhat.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v8 2/4] arm64: Reorganize the unwinder code for better consistency and maintenance Message-ID: References: <20210812190603.25326-1-madvenka@linux.microsoft.com> <20210812190603.25326-3-madvenka@linux.microsoft.com> MIME-Version: 1.0 In-Reply-To: <20210812190603.25326-3-madvenka@linux.microsoft.com> X-Cookie: I can relate to that. X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210826_165537_423304_CCD50769 X-CRM114-Status: GOOD ( 13.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0310204059848689953==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0310204059848689953== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="65LKdjdOaAfSQ4/m" Content-Disposition: inline --65LKdjdOaAfSQ4/m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 12, 2021 at 02:06:01PM -0500, madvenka@linux.microsoft.com wrot= e: > Renaming of unwinder functions > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > Rename unwinder functions to unwind_*() similar to other architectures > for naming consistency. More on this below. This feels like it could probably do with splitting up a bit for reviewability, several of these headers you've got in the commit logs look like they could be separate commits. Splitting things up does help with reviewability, having only one change to keep in mind at once is a lot less cognative load. > Replace walk_stackframe() with unwind() > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > walk_stackframe() contains the unwinder loop that walks the stack > frames. Currently, start_backtrace() and walk_stackframe() are called > separately. They should be combined in the same function. Also, the > loop in walk_stackframe() should be simplified and should look like > the unwind loops in other architectures such as X86 and S390. This definitely seems like a separate change. --65LKdjdOaAfSQ4/m Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmEnt1oACgkQJNaLcl1U h9DPnAf9F4laW3vdmWRoJzkB/XwlR1FibFKsnO7ddA+FYMKZuJKT88RuCyy/oIdd /h434cxFWIKloXHHoVJEnN5PsOCbiyeddB+maWA5TNP7zI53+l15rrgHvLxpJ6nW w0hcLJRt4vvlv/1QJsW1q5FqvXkBx9WDlJ142fpX0/yH07rm+oxi4Ib4jX3E7rQL d2R0vgSZNXN4MLoyTaOnNdjX84zz17rFN8l7Gl2iO4dWYj9nLjFWgRY6icoGcVWh OgDIxg2F4D78vOCN41EsPe6ZYtNzBKAp+9DF9KH4qea9uMMiCJlhCJJNzVGWzBN6 wFffVTt+3zbPngMhDDGDSWNO7nkCIw== =cnd8 -----END PGP SIGNATURE----- --65LKdjdOaAfSQ4/m-- --===============0310204059848689953== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0310204059848689953==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7290C432BE for ; Thu, 26 Aug 2021 16:24:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B65A461058 for ; Thu, 26 Aug 2021 16:24:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243096AbhHZQZb (ORCPT ); Thu, 26 Aug 2021 12:25:31 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:45722 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238124AbhHZQZS (ORCPT ); Thu, 26 Aug 2021 12:25:18 -0400 X-Greylist: delayed 1761 seconds by postgrey-1.27 at vger.kernel.org; Thu, 26 Aug 2021 12:25:17 EDT DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=YpAC7eKIN1Mk1gt9e5fi3Ne1IF3XO4Cc70sDdq2XPuo=; b=Zza36yh1cVUFJ/wznsXo2osjWg qhweHSI/W3yFCGaHmPXuQQW6mCme31KjL5zFck+2gmfVyODZdylB4GOfU05DzYyjnfBF+FiNC1XzH 1J8Rx/0wxfA1WyyLrBq32bP9AJ6+KR3zbRA5QhoCxtpBGHrLC4ZuAbHTtDaflLgQNiLs=; Received: from 94.196.67.80.threembb.co.uk ([94.196.67.80] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mJHiM-00FUXp-QF; Thu, 26 Aug 2021 15:54:51 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id C7C89D01B81; Thu, 26 Aug 2021 16:46:34 +0100 (BST) Date: Thu, 26 Aug 2021 16:46:34 +0100 From: Mark Brown To: madvenka@linux.microsoft.com Cc: mark.rutland@arm.com, jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, jthierry@redhat.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v8 2/4] arm64: Reorganize the unwinder code for better consistency and maintenance Message-ID: References: <20210812190603.25326-1-madvenka@linux.microsoft.com> <20210812190603.25326-3-madvenka@linux.microsoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="65LKdjdOaAfSQ4/m" Content-Disposition: inline In-Reply-To: <20210812190603.25326-3-madvenka@linux.microsoft.com> X-Cookie: I can relate to that. Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --65LKdjdOaAfSQ4/m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 12, 2021 at 02:06:01PM -0500, madvenka@linux.microsoft.com wrot= e: > Renaming of unwinder functions > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > Rename unwinder functions to unwind_*() similar to other architectures > for naming consistency. More on this below. This feels like it could probably do with splitting up a bit for reviewability, several of these headers you've got in the commit logs look like they could be separate commits. Splitting things up does help with reviewability, having only one change to keep in mind at once is a lot less cognative load. > Replace walk_stackframe() with unwind() > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > walk_stackframe() contains the unwinder loop that walks the stack > frames. Currently, start_backtrace() and walk_stackframe() are called > separately. They should be combined in the same function. Also, the > loop in walk_stackframe() should be simplified and should look like > the unwind loops in other architectures such as X86 and S390. This definitely seems like a separate change. --65LKdjdOaAfSQ4/m Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmEnt1oACgkQJNaLcl1U h9DPnAf9F4laW3vdmWRoJzkB/XwlR1FibFKsnO7ddA+FYMKZuJKT88RuCyy/oIdd /h434cxFWIKloXHHoVJEnN5PsOCbiyeddB+maWA5TNP7zI53+l15rrgHvLxpJ6nW w0hcLJRt4vvlv/1QJsW1q5FqvXkBx9WDlJ142fpX0/yH07rm+oxi4Ib4jX3E7rQL d2R0vgSZNXN4MLoyTaOnNdjX84zz17rFN8l7Gl2iO4dWYj9nLjFWgRY6icoGcVWh OgDIxg2F4D78vOCN41EsPe6ZYtNzBKAp+9DF9KH4qea9uMMiCJlhCJJNzVGWzBN6 wFffVTt+3zbPngMhDDGDSWNO7nkCIw== =cnd8 -----END PGP SIGNATURE----- --65LKdjdOaAfSQ4/m--