From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20C1DC432BE for ; Thu, 26 Aug 2021 20:53:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F245A61037 for ; Thu, 26 Aug 2021 20:53:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243574AbhHZUyD (ORCPT ); Thu, 26 Aug 2021 16:54:03 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:43772 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243561AbhHZUyD (ORCPT ); Thu, 26 Aug 2021 16:54:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=qC9/a8QwjDtxsvgwRxW0lzbEcViqsOvHK7tcWNdMLbQ=; b=zMzBLIqCfZ/pbHHDZG1oQ6Pt2v HrbBiDt6y4JivV0Gvj8EA/iOEiybhzEbk+LqeG7Es/mHBDe2MtxmetfUgQS0wWsnnBDgehyNvgyC9 p34jvzvu2WpMJGjkvBG2OPZlfGvsW6AW8I/B7J9KdJKWvPXXWB+wf4UC6YV2pRFhu4Ps=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mJMN0-0040b5-3d; Thu, 26 Aug 2021 22:53:06 +0200 Date: Thu, 26 Aug 2021 22:53:06 +0200 From: Andrew Lunn To: Saravana Kannan Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Linus Walleij , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski , Len Brown , Alvin Sipraga , kernel-team@android.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v1 1/2] driver core: fw_devlink: Add support for FWNODE_FLAG_BROKEN_PARENT Message-ID: References: <20210826074526.825517-1-saravanak@google.com> <20210826074526.825517-2-saravanak@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org > The DT node in [2] is probed by realtek_smi_probe() [3]. The call flow is: > realtek_smi_probe() > -> dsa_register_switch() > -> dsa_switch_probe() > -> dsa_tree_setup() > -> dsa_tree_setup_switches() > -> dsa_switch_setup() > -> ds->ops->setup(ds) > -> rtl8366rb_setup() > -> realtek_smi_setup_mdio() > -> of_mdiobus_register() > This scans the MDIO bus/DT and device_add()s the PHYs > -> dsa_port_setup() > -> dsa_port_link_register_of() > -> dsa_port_phylink_register() > -> phylink_of_phy_connect() > -> phylink_fwnode_phy_connect() > -> phy_attach_direct() > This checks if PHY device has already probed (by > checking for dev->driver). If not, it forces the > probe of the PHY using one of the generic PHY > drivers. > > So within dsa_register_switch() the PHY device is added and then > expected to have probed in the same thread/calling context. As stated > earlier, this is not guaranteed by the driver core. Have you looked at: commit 16983507742cbcaa5592af530872a82e82fb9c51 Author: Heiner Kallweit Date: Fri Mar 27 01:00:22 2020 +0100 net: phy: probe PHY drivers synchronously See the full commit message, but the code change is: iff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 3b8f6b0b47b5..d543df282365 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -2577,6 +2577,7 @@ int phy_driver_register(struct phy_driver *new_driver, struct module *owner) new_driver->mdiodrv.driver.probe = phy_probe; new_driver->mdiodrv.driver.remove = phy_remove; new_driver->mdiodrv.driver.owner = owner; + new_driver->mdiodrv.driver.probe_type = PROBE_FORCE_SYNCHRONOUS; retval = driver_register(&new_driver->mdiodrv.driver); if (retval) { How does this add to the overall picture? Andrew