From: Tejun Heo <tj@kernel.org>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: Paolo Valente <paolo.valente@linaro.org>,
Jens Axboe <axboe@kernel.dk>,
linux-block <linux-block@vger.kernel.org>,
Jan Kara <jack@suse.cz>,
cgroups@vger.kernel.org
Subject: Re: BFQ cgroup weights range
Date: Thu, 26 Aug 2021 07:25:24 -1000 [thread overview]
Message-ID: <YSfOhM9+uJ5/FzY2@mtj.duckdns.org> (raw)
In-Reply-To: <20210826131212.GE4520@blackbody.suse.cz>
On Thu, Aug 26, 2021 at 03:12:12PM +0200, Michal Koutný wrote:
> On Tue, Aug 24, 2021 at 02:51:47PM +0200, Paolo Valente <paolo.valente@linaro.org> wrote:
> > BFQ inherited these constants when we forked it from CFQ. I'm ok with
> > increasing max weight to 10000. I only wonder whether this would
> > break some configuration, as the currently maximum weight would not be
> > the maximum weight any longer.
>
> Thanks for the reply. Let me form the idea as a patch (and commit
> message) and discuss based on that if needed (+ccrosspost into cgroups
> ML).
>
> -- >8 --
> From: Michal Koutný <mkoutny@suse.com>
> Subject: [PATCH] block, bfq: Accept symmetric weight adjustments
>
> The allowed range for BFQ weights is currently 1..1000 with 100 being
> the default. There is no apparent reason to not accept weight
> adjustments of same ratio on both sides of the default. This change
> makes the attribute domain consistent with other cgroup (v2) knobs with
> the weight semantics.
>
> This extension of the range does not restrict existing configurations
> (quite the opposite). This may affect setups where weights >1000 were
> attempted to be set but failed with the default 100. Such cgroups would
> attain their intended weight now. This is a changed behavior but it
> rectifies the situation (similar intention to the commit 69d7fde5909b
> ("blkcg: use CGROUP_WEIGHT_* scale for io.weight on the unified
> hierarchy") for CFQ formerly (and v2 only)).
>
> Additionally, the changed range does not imply all IO workloads can be
> really controlled to achieve the widest possible ratio 1:10^4.
>
> Signed-off-by: Michal Koutný <mkoutny@suse.com>
Looks fine to me.
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2021-08-26 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 10:56 BFQ cgroup weights range Michal Koutný
2021-08-24 12:51 ` Paolo Valente
2021-08-26 13:12 ` Michal Koutný
2021-08-26 17:25 ` Tejun Heo [this message]
2021-08-27 8:33 ` Paolo Valente
2021-08-27 8:33 ` Paolo Valente
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSfOhM9+uJ5/FzY2@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-block@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=paolo.valente@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.