From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C234C4320A for ; Thu, 26 Aug 2021 19:09:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D0296103E for ; Thu, 26 Aug 2021 19:09:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243365AbhHZTKg (ORCPT ); Thu, 26 Aug 2021 15:10:36 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:43540 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230442AbhHZTKf (ORCPT ); Thu, 26 Aug 2021 15:10:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=MVp+QqWuQEFRYD0iAeEpQZCFKNbvjGPxk+oixgJjSJA=; b=GgpJ1GK4T+uv58qhsXlC32ncAw 9saJg1q0/Qi/LDCFHGJhBGzlMwfdVGUkul2QNXY1Dmdy2gU6R2cyyF7vbwMqBXuzDjpfzjmeuHyBq GaAulvGWXI45a9gSMuW3V71Id5/OgEcSPZhE/qmnP291QGq+5CyNRZMdsj0l49cE0LjA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mJKkp-003zsA-9c; Thu, 26 Aug 2021 21:09:35 +0200 Date: Thu, 26 Aug 2021 21:09:35 +0200 From: Andrew Lunn To: Sergey Shtylyov Cc: Biju Das , "David S. Miller" , Jakub Kicinski , Prabhakar Mahadev Lad , Geert Uytterhoeven , Adam Ford , Yoshihiro Shimoda , "netdev@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , Chris Paterson , Biju Das Subject: Re: [PATCH net-next 04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info Message-ID: References: <20210825070154.14336-5-biju.das.jz@bp.renesas.com> <777c30b1-e94e-e241-b10c-ecd4d557bc06@omp.ru> <78ff279d-03f1-6932-88d8-1eac83d087ec@omp.ru> <9b0d5bab-e9a2-d9f6-69f7-049bfb072eba@omp.ru> <93dab08c-4b0b-091d-bd47-6e55bce96f8a@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Aug 26, 2021 at 10:02:07PM +0300, Sergey Shtylyov wrote: > On 8/26/21 9:57 PM, Andrew Lunn wrote: > > >>> Do you agree GAC register(gPTP active in Config) bit in AVB-DMAC mode register(CCC) present only in R-Car Gen3? > >> > >> Yes. > >> But you feature naming is totally misguiding, nevertheless... > > > > It can still be changed. > > Thank goodness, yea! We have to live with the first version of this in the git history, but we can add more patches fixing up whatever is broken in the unreviewed code which got merged. > > Just suggest a new name. > > I'd prolly go with 'gptp' for the gPTP support and 'ccc_gac' for the gPTP working also in CONFIG mode > (CCC.GAC controls this feature). Biju, please could you work on a couple of patches to change the names. I also suggest you post further refactoring patches as RFC. We might get a chance to review them then. Andrew