From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DB18C4320A for ; Fri, 27 Aug 2021 17:19:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FE7960EB5 for ; Fri, 27 Aug 2021 17:19:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237006AbhH0RUA (ORCPT ); Fri, 27 Aug 2021 13:20:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236341AbhH0RT7 (ORCPT ); Fri, 27 Aug 2021 13:19:59 -0400 Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D14E9C061796 for ; Fri, 27 Aug 2021 10:19:10 -0700 (PDT) Received: by mail-ot1-x32a.google.com with SMTP id q11-20020a9d4b0b000000b0051acbdb2869so3816765otf.2 for ; Fri, 27 Aug 2021 10:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LUINJeVF8Mv+Qni9gSoxQ0tMUJKZ5DY+dY1yDHy05KU=; b=wXzAoFu3YPB/qKtRMuy9NS/vw+iY8qqKSMhL91DwkH3fx1VFILrLHQtvDJmfVw/vWt u0Gmea/jMmYkBs0l2KLAt0hNR6cljTmPyyig+3a8NslpVjwrpPlq/V5HKevdiWunMVAL 5dYm2M2SZOdSfBVuIJwiptec/K/PECRi7UdwO+40h2rvwcR4JLB8PISkchwuwfkkmICf LMlN97nC/yJnI43xCuUk2ZX2f3sSe5el182ghH6U7YLnuVBQgALrCZERCZN1HTeZtCLz gE/n61OXCM0PdihuljqD6O/yjb8PoVAPYXmmW+ePkLzJ1THBUJhVV9Td6wGBA/sa2z1B Wjtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LUINJeVF8Mv+Qni9gSoxQ0tMUJKZ5DY+dY1yDHy05KU=; b=csF4XEgtt52hQA9KkSUjTTSKK2AlS56zUWfK3z8f1bNbMEzkl8aUo5+rESi5lCkRe0 dNuAXQxghMYfR3f6Wa7z7aIkkcMpfhnALQfg/YA8kL0Ceqi9CckyF2zjJocM8F+/PxEK genum2pU8a9OjSjl6yfJdRQdcDNkOdtLqE2DSbSOT30gdRtDlhAR29+H3HT5WoKrFuhQ FZpnYwjQvI58AxN+bjwKIXjHKZt6yKfouHcHf2YgkMir/q33MFwu1anQkbZZW9tXYjkR gvnFrFb2Brrd7XEGgOj6iDXtSbC47O835DZlosPfEaBNP4f0tHv/mm7eTuLAaRG0X1So 8mKA== X-Gm-Message-State: AOAM530X+OcVyxRy/A/5HJXnr+v3vBsE/UyfLEecJQGZkjMYsTmL0iBH u9Ea1OUA0pddAHrYDtjfqgvBAA== X-Google-Smtp-Source: ABdhPJzpZGHJr2Nwej0U+Rd/3Jh75eu1bT9hRrxL9fP6KKzmFMhs9Syiz/V9cJhMDnuwNkWiUOuqsQ== X-Received: by 2002:a05:6830:314b:: with SMTP id c11mr9064499ots.169.1630084750178; Fri, 27 Aug 2021 10:19:10 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id m20sm1461021oiw.46.2021.08.27.10.19.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Aug 2021 10:19:09 -0700 (PDT) Date: Fri, 27 Aug 2021 10:20:23 -0700 From: Bjorn Andersson To: Kuogee Hsieh Cc: robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org, vkoul@kernel.org, agross@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, abhinavk@codeaurora.org, aravindh@codeaurora.org, mkrishn@codeaurora.org, kalyan_t@codeaurora.org, rajeevny@codeaurora.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64: dts: qcom: sc7280: fix display port phy base address offset Message-ID: References: <1630083316-2028-1-git-send-email-khsieh@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1630083316-2028-1-git-send-email-khsieh@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri 27 Aug 09:55 PDT 2021, Kuogee Hsieh wrote: So the order was mixed up, 0x088eaa00 got the wrong length and you got one hardware block too many in there? > Fixes: 9886e8fd8438 ("arm64: dts: qcom: sc7280: Add USB related nodes") > Signed-off-by: Kuogee Hsieh > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index c29226b..77b0b4e 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -2918,15 +2918,11 @@ > dp_phy: dp-phy@88ea200 { > reg = <0 0x088ea200 0 0x200>, > <0 0x088ea400 0 0x200>, > - <0 0x088eac00 0 0x400>, > + <0 0x088eaa00 0 0x200>, > <0 0x088ea600 0 0x200>, > - <0 0x088ea800 0 0x200>, > - <0 0x088eaa00 0 0x100>; > + <0 0x088ea800 0 0x200>; > #phy-cells = <0>; > #clock-cells = <1>; > - clocks = <&gcc GCC_USB3_PRIM_PHY_PIPE_CLK>; > - clock-names = "pipe0"; > - clock-output-names = "usb3_phy_pipe_clk_src"; This is not "base address offset", please fix $subject. Looking at this makes me feel that the dp-phy node was copy-pasted from the usb3-node and that this patch corrects a copy-paste issue. Seems like this would be an excellent thing to write in a commit message. Thanks, Bjorn > }; > }; > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >