From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 132D2C432BE for ; Sat, 28 Aug 2021 07:05:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CF2E61039 for ; Sat, 28 Aug 2021 07:05:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9CF2E61039 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gibson.dropbear.id.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:52010 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJsOq-0006Sj-9b for qemu-devel@archiver.kernel.org; Sat, 28 Aug 2021 03:05:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:56754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJsJg-0004en-G6; Sat, 28 Aug 2021 02:59:49 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:50679 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJsJZ-0002D1-JO; Sat, 28 Aug 2021 02:59:48 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 4GxSB45GDbz9sX3; Sat, 28 Aug 2021 16:59:24 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1630133964; bh=l1dk7G9ghszAHOGoBCHOic7YBUEC9zDcOEC9XySrK4s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LCmlmHD28uneTFDk70w/s2ISgYJZq7RjChtlo8CVn4XffMQiAx6pf3ZAaXwygLwhI 63DzZyGe6u/W+Y8S/493GE2UyPnxNw7ZwYzyJgkC5nE5nD5haI6aFrvxpCl1TbLS6G 6W6fo++VK9CCJAUe67mEc6SSPjdqsdX7I9j66vz0= Date: Sat, 28 Aug 2021 15:29:57 +1000 From: David Gibson To: BALATON Zoltan Subject: Re: [PATCH] Report any problems with loading the VGA driver for PPC Macintosh targets Message-ID: References: <20210827181429.23609-1-programmingkidx@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="aBGE09KTpPmRUQzN" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=2401:3900:2:1::2; envelope-from=dgibson@ozlabs.org; helo=ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Arbuckle , hsp.cat7@gmail.com, qemu-ppc@nongnu.org, groug@kaod.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --aBGE09KTpPmRUQzN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 27, 2021 at 11:15:26PM +0200, BALATON Zoltan wrote: > On Fri, 27 Aug 2021, John Arbuckle wrote: > > I was having a problem with missing video resolutions in my Mac OS 9 VM= =2E When I > > ran QEMU it gave no indication as to why these resolutions were missing= =2E I found > > out that the OpenFirmware VGA driver was not being loaded. To prevent a= nyone from > > going thru the same trouble I went thru I added messages that the user = can see > > when a problem takes place with loading this driver in the future. > >=20 > > Signed-off-by: John Arbuckle > > --- > > hw/ppc/mac_newworld.c | 6 ++++++ > > hw/ppc/mac_oldworld.c | 6 ++++++ > > 2 files changed, 12 insertions(+) > >=20 > > diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c > > index 7bb7ac3997..c1960452b8 100644 > > --- a/hw/ppc/mac_newworld.c > > +++ b/hw/ppc/mac_newworld.c > > @@ -526,8 +526,14 @@ static void ppc_core99_init(MachineState *machine) > >=20 > > if (g_file_get_contents(filename, &ndrv_file, &ndrv_size, NULL)= ) { > > fw_cfg_add_file(fw_cfg, "ndrv/qemu_vga.ndrv", ndrv_file, nd= rv_size); > > + } else { > > + printf("Warning: failed to load driver %s. This may cause = video" > > + " problems.\n"); >=20 > I think you should use warn_report for these instead of printf and watch = out > if that needs \n or not (some functions add \n while some others may not = and > I always forget which is which but checkpatch should warn for it so you > should get nofified if you leave \n there but it's not needed). Yes, it definitely should be warn_report() rather than a raw printf. Patches for Macintosh should also go to the relevant maintainer Mark Cave-Ayland . --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --aBGE09KTpPmRUQzN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEdfRlhq5hpmzETofcbDjKyiDZs5IFAmEpydMACgkQbDjKyiDZ s5KYMBAAiVJuHC24fYdTfXzkC7T66pLw2OMbmj1meDFoATHm0tMXUKf47k5644Kq 0xRamaqF7BP6YPBgZAW9l+jYU3V0VoGJ+4LpvcWjLXH5Fu6kH9MXnNqmf5uwldtb uJYIucl60cYxi7cxXxfGybT/y5B0s0nb/6lQlc6sbK9elg04VNpeGDJ/IUIj3ByR k/X09LuYpyl/9k4hE5rQ8nUr+vYCGgnaYt8jDtFsL4yN9M+otLHitLRZLMsEAsEd ejgwnvShXlPQdomAE8TF/DBrgTzE+WEXBwvMI0yLg3pSHHRL5uiUETT2ILPvJAEm ZgV2/296uICD1OklyFj753Q10zF83M0LRJL31PeGeZ3lDL3fC1P8jL7A08FbEkvd NnMxMmH2y+h5IZsQvDsJDUYXE5Zfr/gNqw8A0APAEM1Ud0dFr3+ZzRzdgH9XLrhC 1GvMvNSkIzIuqyNecWMhp4sQcAS9VHX/bE8yf1mXAeqp0HXm13y1i/V7ZeRuWvEU p0UizHkuBN5dEOAnv/W5LncUe+07ceUnNIjNl7aXPg60ER34+/AY043e6LCoWaJ8 AENCq+QZurKtGERQevvI3OvIgFnrsu46u6SePSyK6DwLJRPmHGtBtfRH145r7Y9L DC9o0qPAQSr1fRXeRahpkxLwkpIJj5eU5clOMTr/FP/ODdzg1OM= =yGbI -----END PGP SIGNATURE----- --aBGE09KTpPmRUQzN--