From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6B8AC4320A for ; Sat, 28 Aug 2021 22:14:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA33760551 for ; Sat, 28 Aug 2021 22:14:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232548AbhH1WPQ (ORCPT ); Sat, 28 Aug 2021 18:15:16 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:46436 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230253AbhH1WPM (ORCPT ); Sat, 28 Aug 2021 18:15:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ykqrNZ5+xkEdOSCPLKtfepuHL8Oc2+H/B5h3rAqZXGc=; b=IrALU6x5Fkn8ESg+tD7b/KACL8 IKQuwWtI9Zc4Xd7Mn4NRJbqLsKjw8pAJUkmxnlwM0SwbtmQN6hwgMgIbn6HwfXPM924HA+cpE0D1I 2xlkD1h7tNNe5EM86mqUBaezjmlWn6qw6qvOFW80eKcVZPIrRaCCg3IYvEa4mT4RwPyQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mK6af-004KOJ-VM; Sun, 29 Aug 2021 00:14:17 +0200 Date: Sun, 29 Aug 2021 00:14:17 +0200 From: Andrew Lunn To: Matthew Hagan Cc: Florian Fainelli , Rob Herring , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] ARM: dts: NSP: Fix MDIO mux node names Message-ID: References: <20210828112704.2283805-1-mnhagan88@gmail.com> <20210828112704.2283805-3-mnhagan88@gmail.com> <858a86de-c06e-0221-64ea-bb1790db398a@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <858a86de-c06e-0221-64ea-bb1790db398a@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 28, 2021 at 10:52:30PM +0100, Matthew Hagan wrote: > On 28/08/2021 18:07, Andrew Lunn wrote: > > > On Sat, Aug 28, 2021 at 11:27:01AM +0000, Matthew Hagan wrote: > >> This patch fixes the following message by adding "mdio-mux" compatible: > >> compatible: ['mdio-mux-mmioreg'] is too short > > > > Err, what? This sounds like a workaround for a tool problem, not a > > real fix. > > > > What is actually wrong with: > > > > compatible = "mdio-mux-mmioreg"; > > Yes this does work fine either with or without "mdio-mux". The changes > have been made to correspond with those submitted by Rafal Milecki for > the BCM5301X platform[1] and to conform with > Documentation/devicetree/bindings/net/mdio-mux-mmioreg.yaml > which does state both as required items (and hence not a tool problem). Hi Matthew It would be good to expand the commit message a bit, since the error 'is too short' is particularly uninformative, and leads to questions like this if not explained. It would also good to get the tool improved, but that is out of scope for this patch. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20ACDC432BE for ; Sat, 28 Aug 2021 22:16:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D0E01606A5 for ; Sat, 28 Aug 2021 22:16:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D0E01606A5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2zzjiOkBTwmbqvOHOjRGTR2TZqlfOY/KrPUHDUusE8M=; b=AWZF286VrHRTvd qiK+kCTlx0WwzPs9gnFJQdhvrf7bK7YzXX8Eus04+R6AsTWJ7/RYHT/pQ25CZ48CDEctIWA0PA2o+ XO3EhRGeRScKzFRxfYq6fJkqdQDp4doWXfsmL+CI+iErEormhAJvVwnM49Htoh9nsZ1J704prfPCj uasCmvQP4762jeUgejC+pmLRjsfzmLPo51QHBf4wKFpCmanTbANYWpSUieRFTcDFXjc2RGhVlHT/e Jn+NuJQ9MbcNURtdP9Ikrs+qV72bl021/zwioBK4u60bS1cFf0XAEFVRDyWxO/X/Ve6FgMLEuU5tE 2EznvD7l6euuRsW6OaZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mK6ar-00EkzT-3R; Sat, 28 Aug 2021 22:14:29 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mK6ak-00Ekym-B7 for linux-arm-kernel@lists.infradead.org; Sat, 28 Aug 2021 22:14:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=ykqrNZ5+xkEdOSCPLKtfepuHL8Oc2+H/B5h3rAqZXGc=; b=IrALU6x5Fkn8ESg+tD7b/KACL8 IKQuwWtI9Zc4Xd7Mn4NRJbqLsKjw8pAJUkmxnlwM0SwbtmQN6hwgMgIbn6HwfXPM924HA+cpE0D1I 2xlkD1h7tNNe5EM86mqUBaezjmlWn6qw6qvOFW80eKcVZPIrRaCCg3IYvEa4mT4RwPyQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mK6af-004KOJ-VM; Sun, 29 Aug 2021 00:14:17 +0200 Date: Sun, 29 Aug 2021 00:14:17 +0200 From: Andrew Lunn To: Matthew Hagan Cc: Florian Fainelli , Rob Herring , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/5] ARM: dts: NSP: Fix MDIO mux node names Message-ID: References: <20210828112704.2283805-1-mnhagan88@gmail.com> <20210828112704.2283805-3-mnhagan88@gmail.com> <858a86de-c06e-0221-64ea-bb1790db398a@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <858a86de-c06e-0221-64ea-bb1790db398a@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210828_151422_429099_940B17DD X-CRM114-Status: GOOD ( 17.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Aug 28, 2021 at 10:52:30PM +0100, Matthew Hagan wrote: > On 28/08/2021 18:07, Andrew Lunn wrote: > > > On Sat, Aug 28, 2021 at 11:27:01AM +0000, Matthew Hagan wrote: > >> This patch fixes the following message by adding "mdio-mux" compatible: > >> compatible: ['mdio-mux-mmioreg'] is too short > > > > Err, what? This sounds like a workaround for a tool problem, not a > > real fix. > > > > What is actually wrong with: > > > > compatible = "mdio-mux-mmioreg"; > > Yes this does work fine either with or without "mdio-mux". The changes > have been made to correspond with those submitted by Rafal Milecki for > the BCM5301X platform[1] and to conform with > Documentation/devicetree/bindings/net/mdio-mux-mmioreg.yaml > which does state both as required items (and hence not a tool problem). Hi Matthew It would be good to expand the commit message a bit, since the error 'is too short' is particularly uninformative, and leads to questions like this if not explained. It would also good to get the tool improved, but that is out of scope for this patch. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel