From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6CBBC432BE for ; Sat, 28 Aug 2021 22:07:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A36D2604D7 for ; Sat, 28 Aug 2021 22:07:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232823AbhH1WIg (ORCPT ); Sat, 28 Aug 2021 18:08:36 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:46414 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230253AbhH1WIf (ORCPT ); Sat, 28 Aug 2021 18:08:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=Ry4UFAsqdgXS1OY+JsQtiI1dYNVCvwS5fqMYMwi+Tz8=; b=fxS45sDmEpBa3A0o3remtKKXea 1E0BZaiODPWJubR/JDhI78OVQcHr9Hwreg3cG0rA5OCfM4FmD6LoYMtWkPwPwej/HN0ZGZwd7OxIL 3djvQGPBLcRTvgpnw+XEIvTO7nEbBPw5O+QeUwbuDoN2zuFsRVVsiAKKlNqzm/0qbyhs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mK6UJ-004KLR-NZ; Sun, 29 Aug 2021 00:07:43 +0200 Date: Sun, 29 Aug 2021 00:07:43 +0200 From: Andrew Lunn To: Michael Chan Cc: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org, edwin.peer@broadcom.com, gospo@broadcom.com Subject: Re: [PATCH net-next 00/11] bnxt_en: Implement new driver APIs to send FW messages Message-ID: References: <1630187910-22252-1-git-send-email-michael.chan@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1630187910-22252-1-git-send-email-michael.chan@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, Aug 28, 2021 at 05:58:19PM -0400, Michael Chan wrote: > The current driver APIs to send messages to the firmware allow only one > outstanding message in flight. There is only one buffer for the firmware > response for each firmware channel. To send a firmware message, all > callers must take a mutex and it is released after the firmware response > has been read. This scheme does not allow multiple firmware messages > in flight. Firmware may take a long time to respond to some messages > (e.g. NVRAM related ones) and this causes the mutex to be held for > a long time, blocking other callers. > > This patchset intoduces the new driver APIs to address the above > shortcomings. All callers are then updated to use the new APIs. Hi Michael Does the firmware already support this? Or is a firmware upgrade also required. Andrew