From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CC71C432BE for ; Sun, 29 Aug 2021 01:03:56 +0000 (UTC) Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C13106054E for ; Sun, 29 Aug 2021 01:03:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C13106054E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=oss.oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 17SCXIkP031677; Sun, 29 Aug 2021 01:03:54 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3aqbx210f7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 29 Aug 2021 01:03:54 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 17T0xuGt045987; Sun, 29 Aug 2021 01:03:53 GMT Received: from oss.oracle.com (oss-old-reserved.oracle.com [137.254.22.2]) by userp3030.oracle.com with ESMTP id 3aqa8uwccd-1 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO); Sun, 29 Aug 2021 01:03:53 +0000 Received: from localhost ([127.0.0.1] helo=lb-oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1mK9Bj-0003UU-Jc; Sat, 28 Aug 2021 18:00:43 -0700 Received: from userp3030.oracle.com ([156.151.31.80]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1mK9Bh-0003U7-Ih for ocfs2-devel@oss.oracle.com; Sat, 28 Aug 2021 18:00:41 -0700 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 17T0xt48045917 for ; Sun, 29 Aug 2021 01:00:41 GMT Received: from mx0a-00069f01.pphosted.com (mx0a-00069f01.pphosted.com [205.220.165.26]) by userp3030.oracle.com with ESMTP id 3aqa8uw90v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Sun, 29 Aug 2021 01:00:41 +0000 Received: from pps.filterd (m0246574.ppops.net [127.0.0.1]) by mx0b-00069f01.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 17SN2HY8012638 for ; Sun, 29 Aug 2021 01:00:39 GMT Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [142.44.231.140]) by mx0b-00069f01.pphosted.com with ESMTP id 3aqxfbgjqh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Sun, 29 Aug 2021 01:00:39 +0000 Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mK99Q-00Gvaz-Dk; Sun, 29 Aug 2021 00:58:20 +0000 Date: Sun, 29 Aug 2021 00:58:20 +0000 From: Al Viro To: Linus Torvalds Message-ID: References: <20210827164926.1726765-1-agruenba@redhat.com> <20210827164926.1726765-6-agruenba@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Source-IP: 142.44.231.140 X-ServerName: zeniv-ca.linux.org.uk X-Proofpoint-SPF-Result: None X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10090 signatures=668682 X-Proofpoint-Spam-Details: rule=tap_notspam policy=tap score=0 mlxscore=0 adultscore=0 spamscore=0 mlxlogscore=523 malwarescore=0 bulkscore=0 impostorscore=0 clxscore=323 lowpriorityscore=0 priorityscore=351 suspectscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108290004 domainage_hfrom=9159 X-Spam: Clean X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10090 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 spamscore=0 adultscore=0 malwarescore=0 mlxlogscore=594 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108290004 Cc: cluster-devel , Jan Kara , Andreas Gruenbacher , Linux Kernel Mailing List , Christoph Hellwig , linux-fsdevel , ocfs2-devel@oss.oracle.com Subject: Re: [Ocfs2-devel] [PATCH v7 05/19] iov_iter: Introduce fault_in_iov_iter_writeable X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10090 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 bulkscore=0 spamscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108290004 X-Proofpoint-GUID: 0Ji7ur9HZzKdm52KNeB4RXowQ5Ku99o5 X-Proofpoint-ORIG-GUID: 0Ji7ur9HZzKdm52KNeB4RXowQ5Ku99o5 On Fri, Aug 27, 2021 at 09:48:55PM +0000, Al Viro wrote: > So we have 3 callers where we want all-or-nothing semantics - two in > arch/x86/kernel/fpu/signal.c and one in btrfs. HWPOISON will be a problem > for all 3, AFAICS... > > IOW, it looks like we have two different things mixed here - one that wants > to try and fault stuff in, with callers caring only about having _something_ > faulted in (most of the users) and one that wants to make sure we *can* do > stores or loads on each byte in the affected area. > > Just accessing a byte in each page really won't suffice for the second kind. > Neither will g-u-p use, unless we teach it about HWPOISON and other fun > beasts... Looks like we want that thing to be a separate primitive; for > btrfs I'd probably replace fault_in_pages_writeable() with clear_user() > as a quick fix for now... Looks like out of these 3 we have * x86 restoring FPU state on sigreturn: correct, if somewhat obfuscated; HWPOISON is not an issue. We want full fault-in there (1 or 2 pages) * x86 saving FPU state into sigframe: not really needed; we do __clear_user() on any error anyway, and taking it into the caller past the pagefault_enable() will serve just fine instead of fault-in of the same for write. * btrfs search_ioctl(): HWPOISON is not an issue (no #MC on stores), but arm64 side of the things very likely is a problem with MTE; there we can have successful store in some bytes in a page with faults on stores elsewhere in it. With such setups that thing will loop indefinitely. And unlike x86 FPU handling, btrfs is arch-independent. IOW, unless I'm misreading the situation, we have one caller where "all or nothing" semantics is correct and needed, several where fault-in is pointless, one where the current use of fault-in is actively wrong (ppc kvm, patch from ppc folks exists), another place where neither semantics is right (btrfs on arm64) and a bunch where "can we access at least the first byte?" should be fine... _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 435E8C41537 for ; Sun, 29 Aug 2021 01:24:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26A5060EAF for ; Sun, 29 Aug 2021 01:24:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233467AbhH2BBb (ORCPT ); Sat, 28 Aug 2021 21:01:31 -0400 Received: from zeniv-ca.linux.org.uk ([142.44.231.140]:38374 "EHLO zeniv-ca.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229725AbhH2BBa (ORCPT ); Sat, 28 Aug 2021 21:01:30 -0400 Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mK99Q-00Gvaz-Dk; Sun, 29 Aug 2021 00:58:20 +0000 Date: Sun, 29 Aug 2021 00:58:20 +0000 From: Al Viro To: Linus Torvalds Cc: Andreas Gruenbacher , Christoph Hellwig , "Darrick J. Wong" , Jan Kara , Matthew Wilcox , cluster-devel , linux-fsdevel , Linux Kernel Mailing List , ocfs2-devel@oss.oracle.com Subject: Re: [PATCH v7 05/19] iov_iter: Introduce fault_in_iov_iter_writeable Message-ID: References: <20210827164926.1726765-1-agruenba@redhat.com> <20210827164926.1726765-6-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 27, 2021 at 09:48:55PM +0000, Al Viro wrote: > So we have 3 callers where we want all-or-nothing semantics - two in > arch/x86/kernel/fpu/signal.c and one in btrfs. HWPOISON will be a problem > for all 3, AFAICS... > > IOW, it looks like we have two different things mixed here - one that wants > to try and fault stuff in, with callers caring only about having _something_ > faulted in (most of the users) and one that wants to make sure we *can* do > stores or loads on each byte in the affected area. > > Just accessing a byte in each page really won't suffice for the second kind. > Neither will g-u-p use, unless we teach it about HWPOISON and other fun > beasts... Looks like we want that thing to be a separate primitive; for > btrfs I'd probably replace fault_in_pages_writeable() with clear_user() > as a quick fix for now... Looks like out of these 3 we have * x86 restoring FPU state on sigreturn: correct, if somewhat obfuscated; HWPOISON is not an issue. We want full fault-in there (1 or 2 pages) * x86 saving FPU state into sigframe: not really needed; we do __clear_user() on any error anyway, and taking it into the caller past the pagefault_enable() will serve just fine instead of fault-in of the same for write. * btrfs search_ioctl(): HWPOISON is not an issue (no #MC on stores), but arm64 side of the things very likely is a problem with MTE; there we can have successful store in some bytes in a page with faults on stores elsewhere in it. With such setups that thing will loop indefinitely. And unlike x86 FPU handling, btrfs is arch-independent. IOW, unless I'm misreading the situation, we have one caller where "all or nothing" semantics is correct and needed, several where fault-in is pointless, one where the current use of fault-in is actively wrong (ppc kvm, patch from ppc folks exists), another place where neither semantics is right (btrfs on arm64) and a bunch where "can we access at least the first byte?" should be fine... From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Date: Sun, 29 Aug 2021 00:58:20 +0000 Subject: [Cluster-devel] [PATCH v7 05/19] iov_iter: Introduce fault_in_iov_iter_writeable In-Reply-To: References: <20210827164926.1726765-1-agruenba@redhat.com> <20210827164926.1726765-6-agruenba@redhat.com> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Aug 27, 2021 at 09:48:55PM +0000, Al Viro wrote: > So we have 3 callers where we want all-or-nothing semantics - two in > arch/x86/kernel/fpu/signal.c and one in btrfs. HWPOISON will be a problem > for all 3, AFAICS... > > IOW, it looks like we have two different things mixed here - one that wants > to try and fault stuff in, with callers caring only about having _something_ > faulted in (most of the users) and one that wants to make sure we *can* do > stores or loads on each byte in the affected area. > > Just accessing a byte in each page really won't suffice for the second kind. > Neither will g-u-p use, unless we teach it about HWPOISON and other fun > beasts... Looks like we want that thing to be a separate primitive; for > btrfs I'd probably replace fault_in_pages_writeable() with clear_user() > as a quick fix for now... Looks like out of these 3 we have * x86 restoring FPU state on sigreturn: correct, if somewhat obfuscated; HWPOISON is not an issue. We want full fault-in there (1 or 2 pages) * x86 saving FPU state into sigframe: not really needed; we do __clear_user() on any error anyway, and taking it into the caller past the pagefault_enable() will serve just fine instead of fault-in of the same for write. * btrfs search_ioctl(): HWPOISON is not an issue (no #MC on stores), but arm64 side of the things very likely is a problem with MTE; there we can have successful store in some bytes in a page with faults on stores elsewhere in it. With such setups that thing will loop indefinitely. And unlike x86 FPU handling, btrfs is arch-independent. IOW, unless I'm misreading the situation, we have one caller where "all or nothing" semantics is correct and needed, several where fault-in is pointless, one where the current use of fault-in is actively wrong (ppc kvm, patch from ppc folks exists), another place where neither semantics is right (btrfs on arm64) and a bunch where "can we access at least the first byte?" should be fine...