From: "Clément Bœsch" <u@pkh.me>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Willy Liu <willy.liu@realtek.com>,
netdev@vger.kernel.org, linux-sunxi@lists.linux.dev,
devicetree@vger.kernel.org
Subject: Re: sunxi H5 DTB fix for realtek regression
Date: Mon, 30 Aug 2021 17:21:26 +0200 [thread overview]
Message-ID: <YSz3diNr9+awHuSW@ssq0.pkh.me> (raw)
In-Reply-To: <YSzzuDvd1fWXxcAb@lunn.ch>
On Mon, Aug 30, 2021 at 05:05:28PM +0200, Andrew Lunn wrote:
[...]
> You need to add a Signed-off-by: See
>
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
>
Done.
> Patches need to be in the body of the email, not attachments.
>
Sent through git-send-email this time (sorry about the hiccup I messed up
the first call).
> You can use scripts/get_maintainers.pl to get a list of people to send
> it to. I would use To: for
> Maxime Ripard <mripard@kernel.org> (maintainer:ARM/Allwinner sunXi SoC support)
> Chen-Yu Tsai <wens@csie.org> (maintainer:ARM/Allwinner sunXi SoC support)
> Jernej Skrabec <jernej.skrabec@gmail.com> (reviewer:ARM/Allwinner sunXi SoC support)
>
> and Cc: for the rest.
>
> > Note: running `git grep 'phy-mode\s*=\s*"rgmii"' arch` shows that it might
> > affect other hardware as well.
>
> "rgmii" can be correct. So you need to narrow your search.
>
Yeah I understand that, but I don't know if that can be deduced from the
code only, or if someone needs to look at the hardware specs. As said
initially, I don't have much clue about what's going on here.
> > I don't know how one is supposed to check
> > that, but I would guess at least sun50i-a64-nanopi-a64.dts is affected (a
> > quick internet search shows that it's using a RTL8211E¹)
>
> This seems reasonable. You could provide a second patch for this.
I'll leave that to the other maintainers; I don't have the hardware to
test and I'm uncomfortable patching something I don't understand.
Regards,
--
Clément B.
prev parent reply other threads:[~2021-08-30 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 0:52 sunxi H5 DTB fix for realtek regression Clément Bœsch
2021-08-30 13:51 ` Andrew Lunn
2021-08-30 14:35 ` Clément Bœsch
2021-08-30 15:05 ` Andrew Lunn
2021-08-30 15:21 ` Clément Bœsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSz3diNr9+awHuSW@ssq0.pkh.me \
--to=u@pkh.me \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=willy.liu@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.