From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6FFC2FAF for ; Mon, 30 Aug 2021 15:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=bL28JptUtAL4Jouyvz4ajT1BB84wg50lUMYs9+7LAQ8=; b=P5 LbcUcU0pSZph2xB8UOOyvAk+j1U+gMY+is0vQHHJG79odnEogPiUJCWiamoPuaOqQzSNzCnIYdmQo J5XyPUKkepBoCS6OJVjyd75TcIQ/tLeUUWArIfi1EI99mTlupPENa9AoFO7M8qZStIX96B+MyXJL9 VW8SyMx8CLV8s3E=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mKiqm-004aHV-6G; Mon, 30 Aug 2021 17:05:28 +0200 Date: Mon, 30 Aug 2021 17:05:28 +0200 From: Andrew Lunn To: =?utf-8?B?Q2zDqW1lbnQgQsWTc2No?= Cc: Heiner Kallweit , "David S. Miller" , Jakub Kicinski , Rob Herring , Maxime Ripard , Chen-Yu Tsai , Willy Liu , netdev@vger.kernel.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: sunxi H5 DTB fix for realtek regression Message-ID: References: Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: > See attached patch, heavily based on other commits. Looks good. You need to add a Signed-off-by: See https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin Patches need to be in the body of the email, not attachments. You can use scripts/get_maintainers.pl to get a list of people to send it to. I would use To: for Maxime Ripard (maintainer:ARM/Allwinner sunXi SoC support) Chen-Yu Tsai (maintainer:ARM/Allwinner sunXi SoC support) Jernej Skrabec (reviewer:ARM/Allwinner sunXi SoC support) and Cc: for the rest. > Note: running `git grep 'phy-mode\s*=\s*"rgmii"' arch` shows that it might > affect other hardware as well. "rgmii" can be correct. So you need to narrow your search. > I don't know how one is supposed to check > that, but I would guess at least sun50i-a64-nanopi-a64.dts is affected (a > quick internet search shows that it's using a RTL8211Eš) This seems reasonable. You could provide a second patch for this. Andrew