From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E24A0C433EF for ; Mon, 13 Sep 2021 10:43:32 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 631EA60FF2 for ; Mon, 13 Sep 2021 10:43:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 631EA60FF2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52AEE40151; Mon, 13 Sep 2021 12:43:31 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 7B3524014F for ; Mon, 13 Sep 2021 12:43:30 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10105"; a="221685131" X-IronPort-AV: E=Sophos;i="5.85,288,1624345200"; d="scan'208";a="221685131" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Sep 2021 03:43:29 -0700 X-IronPort-AV: E=Sophos;i="5.85,288,1624345200"; d="scan'208";a="543115645" Received: from bricha3-mobl.ger.corp.intel.com ([10.252.30.142]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA; 13 Sep 2021 03:43:28 -0700 Date: Mon, 13 Sep 2021 11:43:25 +0100 From: Bruce Richardson To: David Hunt Cc: dev@dpdk.org, ciara.power@intel.com Message-ID: References: <20210909155625.24581-1-david.hunt@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210909155625.24581-1-david.hunt@intel.com> Subject: Re: [dpdk-dev] [PATCH v1] usertools/telemetry: add non-interactive mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 09, 2021 at 04:56:25PM +0100, David Hunt wrote: > Add non-interactive mode to dpdk-telemetry.py so that a query string > can be supplied on the command line, and script dumps out data and > exits. Handing for calling from scripts. > > Signed-off-by: David Hunt > --- Hi Dave, I'm not sure I like the use of "-q" for adding a query mode - it's more a shortcut parameter for a "quiet" mode. If I may, I'd suggest an alternative approach here might be to improve support for piping the input commands to the script instead so that you can do e.g. "echo /ethdev/stats,0 | dpdk-telemetry.py" and have that work well in a script. I'll do up a patchset for improving that and upstream it for feedback. /Bruce