From: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
To: Maksym Sobolyev via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Matheus Tavares <matheus.bernardino@usp.br>,
Maksym Sobolyev <sobomax@gmail.com>,
Maksym Sobolyev <sobomax@sippysoft.com>
Subject: Re: [PATCH v3] Make ident dynamic, not just a hardcoded value of "$Id".
Date: Thu, 2 Sep 2021 10:40:18 +0700 [thread overview]
Message-ID: <YTBHk+cS7WluKGL2@danh.dev> (raw)
In-Reply-To: <pull.1074.v3.git.git.1630462385587.gitgitgadget@gmail.com>
On 2021-09-01 02:13:05+0000, Maksym Sobolyev via GitGitGadget <gitgitgadget@gmail.com> wrote:
> diff --git a/convert.h b/convert.h
> index 5ee1c322058..2422e289784 100644
> --- a/convert.h
> +++ b/convert.h
> @@ -76,11 +76,16 @@ enum convert_crlf_action {
>
> struct convert_driver;
>
> +struct ident_action {
> + const char *id;
> + size_t id_len;
> +};
Just out of curiousity, can we use strbuf instead of inventing new
structure for this one? This struct is purely a string representation?
--
Danh
prev parent reply other threads:[~2021-09-02 3:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 16:41 [PATCH] Make ident dynamic, not just a hardcoded value of "$Id" Maksym Sobolyev via GitGitGadget
2021-08-23 18:10 ` Junio C Hamano
2021-08-23 18:41 ` Philip Oakley
2021-08-26 4:28 ` [PATCH v2] " Maksym Sobolyev via GitGitGadget
2021-08-26 20:37 ` Matheus Tavares
2021-09-02 0:58 ` Junio C Hamano
2021-09-02 19:04 ` Junio C Hamano
2021-08-27 2:59 ` Junio C Hamano
[not found] ` <CABFYoQC_FzbU_E4hU0kCz-WFJNOLspwL2Gjc01sMXDZosxJWjw@mail.gmail.com>
2021-09-01 5:35 ` Junio C Hamano
2021-09-01 2:13 ` [PATCH v3] " Maksym Sobolyev via GitGitGadget
2021-09-02 3:40 ` Đoàn Trần Công Danh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTBHk+cS7WluKGL2@danh.dev \
--to=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=matheus.bernardino@usp.br \
--cc=sobomax@gmail.com \
--cc=sobomax@sippysoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.