From: "Zhou Ti (x2019cwm)" <x2019cwm@stfx.ca>
To: "fweisbec@gmail.com" <fweisbec@gmail.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@kernel.org" <mingo@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH] fix the issue that the tick_nohz_get_sleep_length() function could return a negative value
Date: Wed, 20 Jan 2021 23:49:38 +0000 [thread overview]
Message-ID: <YTBPR01MB3262A1EAA009500DF6DD2132C4A20@YTBPR01MB3262.CANPRD01.PROD.OUTLOOK.COM> (raw)
Fix the issue that the tick_nohz_get_sleep_length() function could return a
negative value.
The variable "dev->next_event" has a small possibility to be smaller than
the variable "now" during running, which would result in a negative value
of "*delta_next". The variable "next_event" also has a small posibility to
be smaller than the variable "now". Both case could lead to a negative
return of function tick_nohz_get_sleep_length().
Signed-off-by: Ti Zhou <x2019cwm@stfx.ca>
---
--- tip/kernel/time/tick-sched.c.orig 2021-01-20 05:34:25.151325912 -0400
+++ tip/kernel/time/tick-sched.c 2021-01-20 19:44:28.238538380 -0400
@@ -1142,6 +1142,9 @@ ktime_t tick_nohz_get_sleep_length(ktime
*delta_next = ktime_sub(dev->next_event, now);
+ if (unlikely(*delta_next < 0))
+ *delta_next = 0;
+
if (!can_stop_idle_tick(cpu, ts))
return *delta_next;
@@ -1156,6 +1159,9 @@ ktime_t tick_nohz_get_sleep_length(ktime
next_event = min_t(u64, next_event,
hrtimer_next_event_without(&ts->sched_timer));
+ if (unlikely(next_event < now))
+ next_event = now;
+
return ktime_sub(next_event, now);
}
next reply other threads:[~2021-01-21 2:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 23:49 Zhou Ti (x2019cwm) [this message]
2021-02-01 13:47 ` [PATCH] fix the issue that the tick_nohz_get_sleep_length() function could return a negative value Frederic Weisbecker
2021-02-19 12:09 ` Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2021-01-20 18:58 Zhou Ti (x2019cwm)
2021-01-20 22:11 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTBPR01MB3262A1EAA009500DF6DD2132C4A20@YTBPR01MB3262.CANPRD01.PROD.OUTLOOK.COM \
--to=x2019cwm@stfx.ca \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.