From: Peter Xu <peterx@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
David Hildenbrand <david@redhat.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v5 2/2] memory: Have 'info mtree' remove duplicated Address Space information
Date: Thu, 2 Sep 2021 17:55:42 -0400 [thread overview]
Message-ID: <YTFIXrxd0i6GZbtG@t490s> (raw)
In-Reply-To: <20210902062604.182620-3-philmd@redhat.com>
Hi, Phil,
On Thu, Sep 02, 2021 at 08:26:04AM +0200, Philippe Mathieu-Daudé wrote:
> address-space shared 4 times:
I commented on the format of the output, I saw that it's switched back to the
v1. Any reason?
Although I still think what I proposed looks better, I don't have a strong "no"
to this either. Just want to know the motivations.
E.g., for a script parsing this output, it can easily skip and identify
duplications when scanned "address-space:" following another "address-space:".
Now it needs to understand two layouts, and that "N times" looks superfluous.
> - bcm2835-dma-memory
> - bcm2835-fb-memory
> - bcm2835-property-memory
> - dwc2
> 0000000000000000-00000000ffffffff (prio 0, i/o): bcm2835-gpu
> 0000000000000000-000000003fffffff (prio 0, ram): alias bcm2835-gpu-ram-alias[*] @ram 0000000000000000-000000003fffffff
> 0000000040000000-000000007fffffff (prio 0, ram): alias bcm2835-gpu-ram-alias[*] @ram 0000000000000000-000000003fffffff
> 000000007e000000-000000007effffff (prio 1, i/o): alias bcm2835-peripherals @bcm2835-peripherals 0000000000000000-0000000000ffffff
> 0000000080000000-00000000bfffffff (prio 0, ram): alias bcm2835-gpu-ram-alias[*] @ram 0000000000000000-000000003fffffff
> 00000000c0000000-00000000ffffffff (prio 0, ram): alias bcm2835-gpu-ram-alias[*] @ram 0000000000000000-000000003fffffff
>
> address-space: bcm2835-mbox-memory
> 0000000000000000-000000000000008f (prio 0, i/o): bcm2835-mbox
> 0000000000000010-000000000000001f (prio 0, i/o): bcm2835-fb
> 0000000000000080-000000000000008f (prio 0, i/o): bcm2835-property
--
Peter Xu
next prev parent reply other threads:[~2021-09-02 22:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 6:26 [PATCH v5 0/2] memory: Have 'info mtree' remove duplicated Address Space information Philippe Mathieu-Daudé
2021-09-02 6:26 ` [PATCH v5 1/2] memory: Split mtree_info() as mtree_info_flatview() + mtree_info_as() Philippe Mathieu-Daudé
2021-09-02 21:55 ` Peter Xu
2021-09-02 6:26 ` [PATCH v5 2/2] memory: Have 'info mtree' remove duplicated Address Space information Philippe Mathieu-Daudé
2021-09-02 21:55 ` Peter Xu [this message]
2021-09-03 8:40 ` Philippe Mathieu-Daudé
2021-09-03 15:39 ` Peter Xu
2021-09-03 15:53 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTFIXrxd0i6GZbtG@t490s \
--to=peterx@redhat.com \
--cc=david@redhat.com \
--cc=kraxel@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.