From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B058C433EF for ; Thu, 2 Sep 2021 22:03:41 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8405860724 for ; Thu, 2 Sep 2021 22:03:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8405860724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:45942 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mLuo7-0008VM-Nn for qemu-devel@archiver.kernel.org; Thu, 02 Sep 2021 18:03:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLugl-0002Wj-3b for qemu-devel@nongnu.org; Thu, 02 Sep 2021 17:56:04 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:43497) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mLugj-0001jj-4h for qemu-devel@nongnu.org; Thu, 02 Sep 2021 17:56:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630619758; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tD7bp5BZ3luGVqewahNw3+rCRf9Sm+M99Zy9jziyUts=; b=eI1tcQlrHkYtbysNdPb6f+owV6+GZemwPNMkQGNeuuxe5/hrBlnj7YHiwEiae8Lpdj0tk7 aDa5nf9UYNA+DhJzTlD4+bfo5WolSurTgQvL5zrZquT+x70z3OM8sq2tClRUhTPaFqiVbq gdeNqtJk+mYnCEi3eFYfX0X0VcXIQBY= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-XF9o-vDbO72lIxGvBjDVQA-1; Thu, 02 Sep 2021 17:55:55 -0400 X-MC-Unique: XF9o-vDbO72lIxGvBjDVQA-1 Received: by mail-qk1-f200.google.com with SMTP id g73-20020a379d4c000000b003d3ed03ca28so3869915qke.23 for ; Thu, 02 Sep 2021 14:55:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=tD7bp5BZ3luGVqewahNw3+rCRf9Sm+M99Zy9jziyUts=; b=AaHfmBRdfaF7dB+r4DM4f0Xq+HCXE+E4eP/S0rMyIRt8QygQoiY/W/GnHQ3jzHgF6X v8W4TdGGtq9LE1SUECDts6GEFh7UHkeBIXsWoUg2uWbo9ugJedPIyM5ewZ9i34uRMy1u h/xacc0vBewOxr73iM7dqrsQCeIXKUdptiAzKa+C/XS4fQGV6SEnVUAliqDCPft9Z8zD PTnOhsh+t/yavm9EOsw8eMAiinS/kbffiU0pEOo8lzRVi3JLNI7ToVzA48fY4YaKy99m e36Ok3AKan1XgVH3B5F2Gh0ngZ85N1Q7UiGsHE6GmlIKSxPtmI0vM9zJUfi5rKcCnPlw MP2w== X-Gm-Message-State: AOAM530KbYzXK/cPsRB7kbdwba7mb0cgQMVir0KP13vaorQq5S2lbSuG Tml/J/fBBoH0h5Ax9wCaUDGr+B8/+5RjXL7O5lg18Xfo8jZsFd7E+fmJO/52Gbt1GqsveUms2AM UyzPmPAodaNqljmI= X-Received: by 2002:a37:6303:: with SMTP id x3mr282483qkb.214.1630619755401; Thu, 02 Sep 2021 14:55:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxb6ajyVptwc9323PAM5pLNG9+9ob7Mz/Bq+eMoLrAf5YqCiYOJsx8l5C2eqUULF180GadB8g== X-Received: by 2002:a37:6303:: with SMTP id x3mr282467qkb.214.1630619755205; Thu, 02 Sep 2021 14:55:55 -0700 (PDT) Received: from t490s ([2607:fea8:56a3:500::ad7f]) by smtp.gmail.com with ESMTPSA id d20sm1877914qtw.53.2021.09.02.14.55.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 14:55:54 -0700 (PDT) Date: Thu, 2 Sep 2021 17:55:53 -0400 From: Peter Xu To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v5 1/2] memory: Split mtree_info() as mtree_info_flatview() + mtree_info_as() Message-ID: References: <20210902062604.182620-1-philmd@redhat.com> <20210902062604.182620-2-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210902062604.182620-2-philmd@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=peterx@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.39, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , David Hildenbrand , Mark Cave-Ayland , qemu-devel@nongnu.org, Gerd Hoffmann , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Sep 02, 2021 at 08:26:03AM +0200, Philippe Mathieu-Daudé wrote: > While mtree_info() handles both ASes and flatviews cases, > the two cases share basically no code. Split mtree_info() > as mtree_info_flatview() + mtree_info_as() to simplify. > > Suggested-by: Peter Maydell > Reviewed-by: David Hildenbrand > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Xu -- Peter Xu