Re: [PATCH] Fix formatting for file "hsdma-mt7621.c"

Re: [PATCH] Fix formatting for file "hsdma-mt7621.c"

[Greg KH]

On Thu, Sep 02, 2021 at 01:13:39PM +0200, Krish Jain wrote:
> This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.

Please properly line-wrap your changelog text like your editor asked you
to.

Also, your subject line needs work, look at other commits for this
driver with:
	git log --oneline drivers/staging/mt7621-dma/
and notice how they say the driver name and the subsystem.

Please fix up and resend a v2.

thanks,

greg k-h

[PATCH] Fix formatting for file "hsdma-mt7621.c"

[Krish Jain]

This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.

Signed-off-by: Krish Jain <krishjain02939@gmail.com>

---
 drivers/staging/mt7621-dma/hsdma-mt7621.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c
index b0ed935de7ac..89b72a802800 100644
--- a/drivers/staging/mt7621-dma/hsdma-mt7621.c
+++ b/drivers/staging/mt7621-dma/hsdma-mt7621.c
@@ -162,8 +162,7 @@ struct mtk_hsdam_engine {
 	struct mtk_hsdma_chan chan[1];
 };
 
-static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(
-		struct mtk_hsdma_chan *chan)
+static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(struct mtk_hsdma_chan *chan)
 {
 	return container_of(chan->vchan.chan.device, struct mtk_hsdam_engine,
 			ddev);
@@ -174,8 +173,7 @@ static inline struct mtk_hsdma_chan *to_mtk_hsdma_chan(struct dma_chan *c)
 	return container_of(c, struct mtk_hsdma_chan, vchan.chan);
 }
 
-static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(
-		struct virt_dma_desc *vdesc)
+static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(struct virt_dma_desc *vdesc)
 {
 	return container_of(vdesc, struct mtk_hsdma_desc, vdesc);
 }
@@ -457,9 +455,7 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
 	spin_unlock_bh(&chan->vchan.lock);
 }
 
-static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
-		struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
-		size_t len, unsigned long flags)
+static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, size_t len, unsigned long flags)
 {
 	struct mtk_hsdma_chan *chan = to_mtk_hsdma_chan(c);
 	struct mtk_hsdma_desc *desc;
-- 
2.25.1

Re: [PATCH] Fix formatting for file "hsdma-mt7621.c"

[Krish Jain]

Hi, I use nano. I don't see my editor asking me to wrap the changelog
text? What exactly can I do to get it properly line wrapped properly?

Best Regards,

Krish

On Thu, Sep 2, 2021 at 11:09 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Sep 02, 2021 at 01:13:39PM +0200, Krish Jain wrote:
> > This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.
>
> Please properly line-wrap your changelog text like your editor asked you
> to.
>
> Also, your subject line needs work, look at other commits for this
> driver with:
>         git log --oneline drivers/staging/mt7621-dma/
> and notice how they say the driver name and the subsystem.
>
> Please fix up and resend a v2.
>
> thanks,
>
> greg k-h

Re: [PATCH] Fix formatting for file "hsdma-mt7621.c"

[Greg KH]

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Sep 02, 2021 at 10:24:47PM +0200, Krish Jain wrote:
> Hi, I use nano. I don't see my editor asking me to wrap the changelog
> text? What exactly can I do to get it properly line wrapped properly?

If you have an editor that is not set up to wrap your lines at 72
columns, then you need to do it "by hand".

thanks,

greg k-h

Re: [PATCH] Fix formatting for file "hsdma-mt7621.c"

[Krish Jain]

On Fri, Sep 3, 2021 at 8:24 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> A: http://en.wikipedia.org/wiki/Top_post
> Q: Were do I find info about this thing called top-posting?
> A: Because it messes up the order in which people normally read text.
> Q: Why is top-posting such a bad thing?
> A: Top-posting.
> Q: What is the most annoying thing in e-mail?
>
> A: No.
> Q: Should I include quotations after my reply?
>
> http://daringfireball.net/2007/07/on_top
>
> On Thu, Sep 02, 2021 at 10:24:47PM +0200, Krish Jain wrote:
> > Hi, I use nano. I don't see my editor asking me to wrap the changelog
> > text? What exactly can I do to get it properly line wrapped properly?
>
> If you have an editor that is not set up to wrap your lines at 72
> columns, then you need to do it "by hand".
>
> thanks,
>
> greg k-h

Ok, doing that right now. And sorry about top posting, you know it
takes a while till a habit goes away. On autopilot mode, I just am
used to writing on top.


Best Regards

Re: [PATCH] Fix formatting for file "hsdma-mt7621.c"

[Krish Jain]

On Thu, Sep 2, 2021 at 11:09 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Thu, Sep 02, 2021 at 01:13:39PM +0200, Krish Jain wrote:
> > This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.
>
> Please properly line-wrap your changelog text like your editor asked you
> to.
>
> Also, your subject line needs work, look at other commits for this
> driver with:
>         git log --oneline drivers/staging/mt7621-dma/
> and notice how they say the driver name and the subsystem.
>
> Please fix up and resend a v2.
>
> thanks,
>
> greg k-h

Do you mean I should line-wrap (at 72 columns) the entire thing or
only that line? " This patch fixes the format of the code. It properly
formats lines that should not end with a '(' as suggested by
checkpath.pl."

Best Regards

Re: [PATCH] Fix formatting for file "hsdma-mt7621.c"

[Greg KH]

On Fri, Sep 03, 2021 at 05:49:46PM +0200, Krish Jain wrote:
> On Thu, Sep 2, 2021 at 11:09 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Thu, Sep 02, 2021 at 01:13:39PM +0200, Krish Jain wrote:
> > > This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.
> >
> > Please properly line-wrap your changelog text like your editor asked you
> > to.
> >
> > Also, your subject line needs work, look at other commits for this
> > driver with:
> >         git log --oneline drivers/staging/mt7621-dma/
> > and notice how they say the driver name and the subsystem.
> >
> > Please fix up and resend a v2.
> >
> > thanks,
> >
> > greg k-h
> 
> Do you mean I should line-wrap (at 72 columns) the entire thing or
> only that line?

Your whole changelog text needs to be wrapped at 72 columns.

Look at the 'git log' in the kernel tree for hundreds of thousands of
examples :)

thanks,

greg k-h

Re: [PATCH] Fix formatting for file "hsdma-mt7621.c"

[Krish Jain]

On Fri, Sep 3, 2021 at 7:11 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Sep 03, 2021 at 05:49:46PM +0200, Krish Jain wrote:
> > On Thu, Sep 2, 2021 at 11:09 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Thu, Sep 02, 2021 at 01:13:39PM +0200, Krish Jain wrote:
> > > > This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.
> > >
> > > Please properly line-wrap your changelog text like your editor asked you
> > > to.
> > >
> > > Also, your subject line needs work, look at other commits for this
> > > driver with:
> > >         git log --oneline drivers/staging/mt7621-dma/
> > > and notice how they say the driver name and the subsystem.
> > >
> > > Please fix up and resend a v2.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Do you mean I should line-wrap (at 72 columns) the entire thing or
> > only that line?
>
> Your whole changelog text needs to be wrapped at 72 columns.
>
> Look at the 'git log' in the kernel tree for hundreds of thousands of
> examples :)
>
> thanks,
>
> greg k-h

Hi, so you mean only the change-log text (as in the text telling what
changes have been made) needs to be wrapped at 72 columns but the code
itself (the git diff) doesn't, right ? Because then the entire purpose
of my formatting the code will be lost. Sorry for the confusion.
Learning


Best Regards,

Krish

Re: [PATCH] Fix formatting for file "hsdma-mt7621.c"

[Greg KH]

On Fri, Sep 03, 2021 at 08:54:33PM +0200, Krish Jain wrote:
> On Fri, Sep 3, 2021 at 7:11 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> >
> > On Fri, Sep 03, 2021 at 05:49:46PM +0200, Krish Jain wrote:
> > > On Thu, Sep 2, 2021 at 11:09 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > On Thu, Sep 02, 2021 at 01:13:39PM +0200, Krish Jain wrote:
> > > > > This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.
> > > >
> > > > Please properly line-wrap your changelog text like your editor asked you
> > > > to.
> > > >
> > > > Also, your subject line needs work, look at other commits for this
> > > > driver with:
> > > >         git log --oneline drivers/staging/mt7621-dma/
> > > > and notice how they say the driver name and the subsystem.
> > > >
> > > > Please fix up and resend a v2.
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > >
> > > Do you mean I should line-wrap (at 72 columns) the entire thing or
> > > only that line?
> >
> > Your whole changelog text needs to be wrapped at 72 columns.
> >
> > Look at the 'git log' in the kernel tree for hundreds of thousands of
> > examples :)
> >
> > thanks,
> >
> > greg k-h
> 
> Hi, so you mean only the change-log text (as in the text telling what
> changes have been made) needs to be wrapped at 72 columns but the code
> itself (the git diff) doesn't, right ?

Yes, just the text that you add to the commit message.

Re: [PATCH] Fix formatting for file "hsdma-mt7621.c"

[Krish Jain]

On Sat, Sep 4, 2021 at 8:02 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Fri, Sep 03, 2021 at 08:54:33PM +0200, Krish Jain wrote:
> > On Fri, Sep 3, 2021 at 7:11 PM Greg KH <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Fri, Sep 03, 2021 at 05:49:46PM +0200, Krish Jain wrote:
> > > > On Thu, Sep 2, 2021 at 11:09 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> > > > >
> > > > > On Thu, Sep 02, 2021 at 01:13:39PM +0200, Krish Jain wrote:
> > > > > > This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.
> > > > >
> > > > > Please properly line-wrap your changelog text like your editor asked you
> > > > > to.
> > > > >
> > > > > Also, your subject line needs work, look at other commits for this
> > > > > driver with:
> > > > >         git log --oneline drivers/staging/mt7621-dma/
> > > > > and notice how they say the driver name and the subsystem.
> > > > >
> > > > > Please fix up and resend a v2.
> > > > >
> > > > > thanks,
> > > > >
> > > > > greg k-h
> > > >
> > > > Do you mean I should line-wrap (at 72 columns) the entire thing or
> > > > only that line?
> > >
> > > Your whole changelog text needs to be wrapped at 72 columns.
> > >
> > > Look at the 'git log' in the kernel tree for hundreds of thousands of
> > > examples :)
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Hi, so you mean only the change-log text (as in the text telling what
> > changes have been made) needs to be wrapped at 72 columns but the code
> > itself (the git diff) doesn't, right ?
>
> Yes, just the text that you add to the commit message.
>


Oh, wow, thank you. That's rather easy. You'll have it ASAP when I reach home


Best Regards

[PATCH] Fix formatting for file "hsdma-mt7621.c"

[Krish Jain]

From: Krish Jain <krishjain02939@gmail.com>

This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.

Signed-off-by: Krish Jain <krishjain02939@gmail.com>

---
 drivers/staging/mt7621-dma/hsdma-mt7621.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c
index b0ed935de7ac..89b72a802800 100644
--- a/drivers/staging/mt7621-dma/hsdma-mt7621.c
+++ b/drivers/staging/mt7621-dma/hsdma-mt7621.c
@@ -162,8 +162,7 @@ struct mtk_hsdam_engine {
 	struct mtk_hsdma_chan chan[1];
 };
 
-static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(
-		struct mtk_hsdma_chan *chan)
+static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(struct mtk_hsdma_chan *chan)
 {
 	return container_of(chan->vchan.chan.device, struct mtk_hsdam_engine,
 			ddev);
@@ -174,8 +173,7 @@ static inline struct mtk_hsdma_chan *to_mtk_hsdma_chan(struct dma_chan *c)
 	return container_of(c, struct mtk_hsdma_chan, vchan.chan);
 }
 
-static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(
-		struct virt_dma_desc *vdesc)
+static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(struct virt_dma_desc *vdesc)
 {
 	return container_of(vdesc, struct mtk_hsdma_desc, vdesc);
 }
@@ -457,9 +455,7 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
 	spin_unlock_bh(&chan->vchan.lock);
 }
 
-static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
-		struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
-		size_t len, unsigned long flags)
+static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, size_t len, unsigned long flags)
 {
 	struct mtk_hsdma_chan *chan = to_mtk_hsdma_chan(c);
 	struct mtk_hsdma_desc *desc;
-- 
2.25.1

Re: [PATCH] Fix formatting for file "hsdma-mt7621.c"

[Krish Jain]

On Wed, Sep 1, 2021 at 11:36 PM Krish Jain <krishjain02939@gmail.com> wrote:
>
> From: Krish Jain <krishjain02939@gmail.com>
>
> This patch fixes the format of the code. It properly formats lines that should not end with a '(' as suggested by checkpath.pl.
>
> Signed-off-by: Krish Jain <krishjain02939@gmail.com>
>
> ---
>  drivers/staging/mt7621-dma/hsdma-mt7621.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/mt7621-dma/hsdma-mt7621.c b/drivers/staging/mt7621-dma/hsdma-mt7621.c
> index b0ed935de7ac..89b72a802800 100644
> --- a/drivers/staging/mt7621-dma/hsdma-mt7621.c
> +++ b/drivers/staging/mt7621-dma/hsdma-mt7621.c
> @@ -162,8 +162,7 @@ struct mtk_hsdam_engine {
>         struct mtk_hsdma_chan chan[1];
>  };
>
> -static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(
> -               struct mtk_hsdma_chan *chan)
> +static inline struct mtk_hsdam_engine *mtk_hsdma_chan_get_dev(struct mtk_hsdma_chan *chan)
>  {
>         return container_of(chan->vchan.chan.device, struct mtk_hsdam_engine,
>                         ddev);
> @@ -174,8 +173,7 @@ static inline struct mtk_hsdma_chan *to_mtk_hsdma_chan(struct dma_chan *c)
>         return container_of(c, struct mtk_hsdma_chan, vchan.chan);
>  }
>
> -static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(
> -               struct virt_dma_desc *vdesc)
> +static inline struct mtk_hsdma_desc *to_mtk_hsdma_desc(struct virt_dma_desc *vdesc)
>  {
>         return container_of(vdesc, struct mtk_hsdma_desc, vdesc);
>  }
> @@ -457,9 +455,7 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c)
>         spin_unlock_bh(&chan->vchan.lock);
>  }
>
> -static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(
> -               struct dma_chan *c, dma_addr_t dest, dma_addr_t src,
> -               size_t len, unsigned long flags)
> +static struct dma_async_tx_descriptor *mtk_hsdma_prep_dma_memcpy(struct dma_chan *c, dma_addr_t dest, dma_addr_t src, size_t len, unsigned long flags)
>  {
>         struct mtk_hsdma_chan *chan = to_mtk_hsdma_chan(c);
>         struct mtk_hsdma_desc *desc;
> --
> 2.25.1
>


I am messing up on my mail client. Sorry again. Please ignore this mail