From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 863C33FC1 for ; Fri, 3 Sep 2021 16:07:49 +0000 (UTC) Received: by mail-ot1-f45.google.com with SMTP id v33-20020a0568300921b0290517cd06302dso7096808ott.13 for ; Fri, 03 Sep 2021 09:07:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=X9EoctdCi61dxF0sN3RYUh7Sq1ZZ1hgqyk+aajCi77E=; b=L/Ejkoo9uUq0YbY45bt6O59bQm5b2RPiEkU7kpJoevaAkMBlteyEjEFFLsdmex7Ybj 6e4UpP3rTF96gFUE/xcDJSqz2LjTmmGn5MYTvP8WICppavIVRfpFu14qIhUbZQVgMtPz rNFPwiI6WJJnu44l3OXwSiU/bnZI2LsSgLARSAYvT3GT5F5rftHdf3pY30GRa5cU/0+A UGmcXibT4mmeBssqCQm4Pz5UMfD+5oXiCbeQelhWzgHHmZrZgCGSaWCr9ki8S1F1kmT7 Z9A1PRH6IcT1JoXxFhAPXgR/oYE3sJBdrpz3MpxhHQAiM1hTqjRiEHTR9hmafaHi+m8C sOug== X-Gm-Message-State: AOAM533B0oGLWcrV1Xmgc8MVxKyorK3nhuzMdgHtNiXax327bKl1aaTb rvj5FGZQe98QisRg4ZdR3Q== X-Google-Smtp-Source: ABdhPJx6fVy45NUm19V4s1kfkPU3oDPESzTSfZcum5Yriq84uuncy+0f+/TnPB6bRmWPuRaP4J69Ew== X-Received: by 2002:a9d:7006:: with SMTP id k6mr3874778otj.181.1630685268668; Fri, 03 Sep 2021 09:07:48 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id e11sm1090605oiw.18.2021.09.03.09.07.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 09:07:47 -0700 (PDT) Received: (nullmailer pid 3026291 invoked by uid 1000); Fri, 03 Sep 2021 16:07:46 -0000 Date: Fri, 3 Sep 2021 11:07:46 -0500 From: Rob Herring To: Samuel Holland Cc: linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Chen-Yu Tsai , Rob Herring , Wim Van Sebroeck , Icenowy Zheng , linux-watchdog@vger.kernel.org, Maxime Ripard , devicetree@vger.kernel.org, Guenter Roeck , Jernej Skrabec , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/3] dt-bindings: watchdog: sunxi: Add compatibles for R329 Message-ID: References: <20210902225750.29313-1-samuel@sholland.org> <20210902225750.29313-2-samuel@sholland.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210902225750.29313-2-samuel@sholland.org> On Thu, 02 Sep 2021 17:57:48 -0500, Samuel Holland wrote: > On existing SoCs, the watchdog has a single clock input: HOSC (OSC24M) > divided by 750. However, starting with R329, LOSC (OSC32k) is added as > an alternative clock source, with a bit to switch between them. > > Since 24 MHz / 750 == 32 kHz, not 32.768 kHz, the hardware adjusts the > cycle counts to keep the timeouts independent of the clock source. This > keeps the programming interface backward-compatible. > > Furthermore, the R329 has two watchdogs: one for use by the ARM CPUs > at 0x20000a0, and a second one for use by the DSPs at 0x7020400. The > first of these adds two more new registers, to allow software to > immediately assert the SoC reset signal. Add an additional "-reset" > suffix to signify the presence of this feature. > > Signed-off-by: Samuel Holland > --- > Changes v2 to v3: > - Add else case > - Add additional allwinner,sun50i-r329-wdt-reset compatible > Changes v1 to v2: > - Switch clock-names from enum to const > - Add descriptions to "clocks" items > > .../watchdog/allwinner,sun4i-a10-wdt.yaml | 42 ++++++++++++++++++- > 1 file changed, 41 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4544EC433EF for ; Fri, 3 Sep 2021 16:10:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E4B8610CF for ; Fri, 3 Sep 2021 16:10:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0E4B8610CF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TwV16lyRR0bpj5D2aqFRrVxw97/jOlhDr6oqd/vDt+I=; b=iXL0B4ZQglFRVZ z7Kd13IAN7w4/GrIrxe7wRLjUleExnYsRLo4r6RWz4HVnzyybtQnOKtS7qclKiPQNvvJoZs+ALAXp gEVc8mx2xbRFHRNcZSgOkFeDgyGXUaY+NXNSh98wwnwr5t9itbsoAMHVCUd63SfaDTBpbuvzdkZoe g13zK46RDFu1/6TlDAHZVssw9V/VEjsiQh/7qpbcxcvhnvke3PM0sl30O4hK82u2FeGPcMp3zjD2V 1nkz4sOj5UpyvNDVMcH9QDA0DTXZQLxkhvKUEu8zix1KJvX17UK5C8ndMHofN39o0RRhohWqO/Xnd e+9fNqCNEJYUK9dPdIzw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mMBjN-00CNFj-TY; Fri, 03 Sep 2021 16:07:54 +0000 Received: from mail-ot1-f44.google.com ([209.85.210.44]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mMBjK-00CNF0-BK for linux-arm-kernel@lists.infradead.org; Fri, 03 Sep 2021 16:07:51 +0000 Received: by mail-ot1-f44.google.com with SMTP id 107-20020a9d0bf4000000b0051b8be1192fso7105060oth.7 for ; Fri, 03 Sep 2021 09:07:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=X9EoctdCi61dxF0sN3RYUh7Sq1ZZ1hgqyk+aajCi77E=; b=lu5cadT5aS0TYsvrMNxls0nJHqxDt59FzfEgjY+OMTh7SYyzRf6NobOeoZ0CJViNbC FWsMyr7VcOM8Y/PFVda14mj+tLTkG6I+bTopfhR9XpqrHPgvVjL5CWYDcw924kdUVmUa atoNoiqmFmVapfxXI6xMfgAT1J+WBmUnT2Tmyzmyfbs2elVbTQ9Ai6axVoPbX4Z0BZlz 8epufXUnOJXLRmc6+88iaWWCm8J1eDlo7QOyVO+IA5RfIMmegxsN+IYWC72ibTP7efX5 8Sn/dgsZc448cWc90AWro3Yh6RvXRlXM2zEV6Qy6GbBgnl4ImqnyBdKbRhoVd5JgmGcb MbWQ== X-Gm-Message-State: AOAM533Y1vgk8yd4kmZTPw5sSZi3B/EVX6pK5FsLP4X0xj7KYGj12NKj Y2M1r4XY0oqmQkVQutyl/3QB/ZfTmw== X-Google-Smtp-Source: ABdhPJx6fVy45NUm19V4s1kfkPU3oDPESzTSfZcum5Yriq84uuncy+0f+/TnPB6bRmWPuRaP4J69Ew== X-Received: by 2002:a9d:7006:: with SMTP id k6mr3874778otj.181.1630685268668; Fri, 03 Sep 2021 09:07:48 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id e11sm1090605oiw.18.2021.09.03.09.07.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 09:07:47 -0700 (PDT) Received: (nullmailer pid 3026291 invoked by uid 1000); Fri, 03 Sep 2021 16:07:46 -0000 Date: Fri, 3 Sep 2021 11:07:46 -0500 From: Rob Herring To: Samuel Holland Cc: linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Chen-Yu Tsai , Rob Herring , Wim Van Sebroeck , Icenowy Zheng , linux-watchdog@vger.kernel.org, Maxime Ripard , devicetree@vger.kernel.org, Guenter Roeck , Jernej Skrabec , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/3] dt-bindings: watchdog: sunxi: Add compatibles for R329 Message-ID: References: <20210902225750.29313-1-samuel@sholland.org> <20210902225750.29313-2-samuel@sholland.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210902225750.29313-2-samuel@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210903_090750_430434_47E65A66 X-CRM114-Status: GOOD ( 18.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 02 Sep 2021 17:57:48 -0500, Samuel Holland wrote: > On existing SoCs, the watchdog has a single clock input: HOSC (OSC24M) > divided by 750. However, starting with R329, LOSC (OSC32k) is added as > an alternative clock source, with a bit to switch between them. > > Since 24 MHz / 750 == 32 kHz, not 32.768 kHz, the hardware adjusts the > cycle counts to keep the timeouts independent of the clock source. This > keeps the programming interface backward-compatible. > > Furthermore, the R329 has two watchdogs: one for use by the ARM CPUs > at 0x20000a0, and a second one for use by the DSPs at 0x7020400. The > first of these adds two more new registers, to allow software to > immediately assert the SoC reset signal. Add an additional "-reset" > suffix to signify the presence of this feature. > > Signed-off-by: Samuel Holland > --- > Changes v2 to v3: > - Add else case > - Add additional allwinner,sun50i-r329-wdt-reset compatible > Changes v1 to v2: > - Switch clock-names from enum to const > - Add descriptions to "clocks" items > > .../watchdog/allwinner,sun4i-a10-wdt.yaml | 42 ++++++++++++++++++- > 1 file changed, 41 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel