From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CEEBC433EF for ; Sun, 5 Sep 2021 10:20:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFB5B60F6D for ; Sun, 5 Sep 2021 10:20:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237643AbhIEKVb (ORCPT ); Sun, 5 Sep 2021 06:21:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:53194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237602AbhIEKVb (ORCPT ); Sun, 5 Sep 2021 06:21:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9F78260F6D; Sun, 5 Sep 2021 10:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630837228; bh=SUnFrhVsbSr7xhXMvn+ilFPAkoBHg1wZQuj1B8J6If4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uz14KLZnk+VNxm5+LffpjNsTNJLqQuHIbmmkU7oEGWYQFakUovEGcl3LXC69ySUrY GhsEketgZV0J4CO+T2UnSHBu/AJMiwNidAw/oRRc5cEUZu0/5Evlir1G3Z1uLMC2xQ zGzH/z+AFo1OhEkoN/MSa64wdl6VesgSAKGSSC5f3NtEqFG1ijnteDnPecgReXpZjh 8I8fkSCPrpqssRx7VL2dR4uWRHE2h+XUu2lbJtN5rwlfzVWei/w7scDeAhiNs56wQc UYiwxgVzVaoSPVkkzKf0LZRGLQTY3lCDaX9HpRlzQeqTEoG2wSKZvjend41tVARWGk wPq5mTk59aa2Q== Date: Sun, 5 Sep 2021 13:20:24 +0300 From: Leon Romanovsky To: Chaitanya Kulkarni Cc: Max Gurtovoy , hch@infradead.org, mst@redhat.com, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, stefanha@redhat.com, israelr@nvidia.com, nitzanc@nvidia.com, oren@nvidia.com, linux-block@vger.kernel.org, axboe@kernel.dk Subject: Re: [PATCH v3 1/1] virtio-blk: add num_request_queues module parameter Message-ID: References: <20210902204622.54354-1-mgurtovoy@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sun, Sep 05, 2021 at 01:49:46AM -0700, Chaitanya Kulkarni wrote: > > On 9/5/2021 12:46 AM, Leon Romanovsky wrote: > > > +static unsigned int num_request_queues; > > > +module_param_cb(num_request_queues, &queue_count_ops, &num_request_queues, > > > + 0644); > > > +MODULE_PARM_DESC(num_request_queues, > > > + "Number of request queues to use for blk device. Should > 0"); > > > + > > Won't it limit all virtio block devices to the same limit? > > > > It is very common to see multiple virtio-blk devices on the same system > > and they probably need different limits. > > > > Thanks > > > Without looking into the code, that can be done adding a configfs > > interface and overriding a global value (module param) when it is set from > > configfs. So why should we do double work instead of providing one working interface from the beginning? Thanks > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48609C433F5 for ; Sun, 5 Sep 2021 10:20:32 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF28E60FBF for ; Sun, 5 Sep 2021 10:20:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DF28E60FBF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id AF6A880E80; Sun, 5 Sep 2021 10:20:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z9wTW0qtaCKq; Sun, 5 Sep 2021 10:20:31 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 6BA1080E48; Sun, 5 Sep 2021 10:20:30 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 50BB5C0010; Sun, 5 Sep 2021 10:20:30 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 68020C000E for ; Sun, 5 Sep 2021 10:20:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 47F43400F7 for ; Sun, 5 Sep 2021 10:20:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=kernel.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id z12ZWM6xdKwX for ; Sun, 5 Sep 2021 10:20:28 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp2.osuosl.org (Postfix) with ESMTPS id AA8D4400C9 for ; Sun, 5 Sep 2021 10:20:28 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 9F78260F6D; Sun, 5 Sep 2021 10:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1630837228; bh=SUnFrhVsbSr7xhXMvn+ilFPAkoBHg1wZQuj1B8J6If4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uz14KLZnk+VNxm5+LffpjNsTNJLqQuHIbmmkU7oEGWYQFakUovEGcl3LXC69ySUrY GhsEketgZV0J4CO+T2UnSHBu/AJMiwNidAw/oRRc5cEUZu0/5Evlir1G3Z1uLMC2xQ zGzH/z+AFo1OhEkoN/MSa64wdl6VesgSAKGSSC5f3NtEqFG1ijnteDnPecgReXpZjh 8I8fkSCPrpqssRx7VL2dR4uWRHE2h+XUu2lbJtN5rwlfzVWei/w7scDeAhiNs56wQc UYiwxgVzVaoSPVkkzKf0LZRGLQTY3lCDaX9HpRlzQeqTEoG2wSKZvjend41tVARWGk wPq5mTk59aa2Q== Date: Sun, 5 Sep 2021 13:20:24 +0300 From: Leon Romanovsky To: Chaitanya Kulkarni Subject: Re: [PATCH v3 1/1] virtio-blk: add num_request_queues module parameter Message-ID: References: <20210902204622.54354-1-mgurtovoy@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: Max Gurtovoy , linux-block@vger.kernel.org, kvm@vger.kernel.org, mst@redhat.com, israelr@nvidia.com, virtualization@lists.linux-foundation.org, hch@infradead.org, nitzanc@nvidia.com, axboe@kernel.dk, stefanha@redhat.com, oren@nvidia.com X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Sun, Sep 05, 2021 at 01:49:46AM -0700, Chaitanya Kulkarni wrote: > > On 9/5/2021 12:46 AM, Leon Romanovsky wrote: > > > +static unsigned int num_request_queues; > > > +module_param_cb(num_request_queues, &queue_count_ops, &num_request_queues, > > > + 0644); > > > +MODULE_PARM_DESC(num_request_queues, > > > + "Number of request queues to use for blk device. Should > 0"); > > > + > > Won't it limit all virtio block devices to the same limit? > > > > It is very common to see multiple virtio-blk devices on the same system > > and they probably need different limits. > > > > Thanks > > > Without looking into the code, that can be done adding a configfs > > interface and overriding a global value (module param) when it is set from > > configfs. So why should we do double work instead of providing one working interface from the beginning? Thanks > > _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization