All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Schier <nicolas@fjasle.eu>
To: David Howells <dhowells@redhat.com>,
	linux-cachefs@redhat.com, linux-kernel@vger.kernel.org
Cc: Nicolas Schier <nicolas@fjasle.eu>
Subject: [PATCH] [RESEND] fscache: re-match MODULE_PARM_DESC() calls to module parameters
Date: Mon, 6 Sep 2021 13:00:41 +0200	[thread overview]
Message-ID: <YTX02eiVawkpTquX@fjasle.eu> (raw)

Fix calls of MODULE_PARM_DESC() such that the first argument matches the
actual module parameter name.  This changes the 'parm' section in the
output of `modinfo fscache` from:

    parm: defer_lookup:uint
    parm: fscache_defer_lookup:Defer cookie lookup to background thread
    parm: defer_create:uint
    parm: fscache_defer_create:Defer cookie creation to background thread
    parm: debug:uint
    parm: fscache_debug:FS-Cache debugging mask

into:

    parm: defer_lookup:Defer cookie lookup to background thread (uint)
    parm: defer_create:Defer cookie creation to background thread (uint)
    parm: debug:FS-Cache debugging mask (uint)
.

Signed-off-by: Nicolas Schier <nicolas@fjasle.eu>
---
 fs/fscache/main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--
Resend unmodified as list approval for linux-cachefs@r.c timed out.

diff --git a/fs/fscache/main.c b/fs/fscache/main.c
index c1e6cc9091aa..ccb06dc0a6e9 100644
--- a/fs/fscache/main.c
+++ b/fs/fscache/main.c
@@ -22,19 +22,19 @@ MODULE_LICENSE("GPL");
 unsigned fscache_defer_lookup = 1;
 module_param_named(defer_lookup, fscache_defer_lookup, uint,
 		   S_IWUSR | S_IRUGO);
-MODULE_PARM_DESC(fscache_defer_lookup,
+MODULE_PARM_DESC(defer_lookup,
 		 "Defer cookie lookup to background thread");
 
 unsigned fscache_defer_create = 1;
 module_param_named(defer_create, fscache_defer_create, uint,
 		   S_IWUSR | S_IRUGO);
-MODULE_PARM_DESC(fscache_defer_create,
+MODULE_PARM_DESC(defer_create,
 		 "Defer cookie creation to background thread");
 
 unsigned fscache_debug;
 module_param_named(debug, fscache_debug, uint,
 		   S_IWUSR | S_IRUGO);
-MODULE_PARM_DESC(fscache_debug,
+MODULE_PARM_DESC(debug,
 		 "FS-Cache debugging mask");
 
 struct kobject *fscache_root;
-- 
2.30.1

             reply	other threads:[~2021-09-06 11:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-06 11:00 Nicolas Schier [this message]
2021-11-26  7:47 ` [PATCH] [RESEND] fscache: re-match MODULE_PARM_DESC() calls to module parameters Nicolas Schier
2022-05-04 15:13   ` Nicolas Schier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YTX02eiVawkpTquX@fjasle.eu \
    --to=nicolas@fjasle.eu \
    --cc=dhowells@redhat.com \
    --cc=linux-cachefs@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.