From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B727C433EF for ; Mon, 6 Sep 2021 09:34:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E72E6101C for ; Mon, 6 Sep 2021 09:34:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240959AbhIFJf4 (ORCPT ); Mon, 6 Sep 2021 05:35:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241313AbhIFJfz (ORCPT ); Mon, 6 Sep 2021 05:35:55 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 276FAC061575 for ; Mon, 6 Sep 2021 02:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=8q9MWlRvr6SEqGQrCCS/NOcI9yCW1ubL7+wy5Msz4e8=; b=ylimq8MikyKJ9Yh6XDkmFpB+Mo AoolMQ0RpEDR9PvnJ4aEEHuIVamhs2jj7ne6dRRsuMOQAmeQA6VOBGCsd3oki68lKg5r0seWQgMJR gptPoTQcwZgnWVqLGQRLE8HLTGQEUvdPY+4XGwsj5bscUX4DeOZNdvctx7LqEpkYvXfgCVOqyDvZR ofARGiS+Idd1pGmwAUYEs4kGR4PHuORpTugaWQ0yk/BV3Pi8WaLuRocjoTaAaIytgrkRWiEJleWCx 8XdmooFVa4U6BWYvmjS5zcUTBMd/QZIlKgOdpAC7Jl6OJuwLwXkhor4HqE+aRqfJua2NlqhqHo8dY jjHLGOnw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44972) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mNB1R-0001WM-Vk; Mon, 06 Sep 2021 10:34:36 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mNB1M-0003AI-O1; Mon, 06 Sep 2021 10:34:32 +0100 Date: Mon, 6 Sep 2021 10:34:32 +0100 From: "Russell King (Oracle)" To: Joakim Zhang Cc: Andrew Lunn , Vladimir Oltean , "peppe.cavallaro@st.com" , "alexandre.torgue@foss.st.com" , "joabreu@synopsys.com" , "davem@davemloft.net" , "kuba@kernel.org" , "mcoquelin.stm32@gmail.com" , "netdev@vger.kernel.org" , "f.fainelli@gmail.com" , "hkallweit1@gmail.com" , dl-linux-imx Subject: Re: [PATCH] net: stmmac: fix MAC not working when system resume back with WoL enabled Message-ID: References: <20210903080147.GS22278@shell.armlinux.org.uk> <20210903093246.GT22278@shell.armlinux.org.uk> <20210903120127.GW22278@shell.armlinux.org.uk> <20210903201210.GF1350@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, On Mon, Sep 06, 2021 at 02:29:30AM +0000, Joakim Zhang wrote: > Hi Russell, > > > -----Original Message----- > > + /* Re-apply the link parameters so that all the settings get > > + * restored to the MAC. > > + */ > > + phylink_mac_initial_config(pl, true); > > + phylink_enable_and_run_resolve(pl, PHYLINK_DISABLE_MAC_WOL); > > There is no "phylink_enable_and_run_resolve " sysbol, I guess you want do below operations in this function: > clear_bit(PHYLINK_DISABLE_MAC_WOL, &pl->phylink_disable_state); > phylink_run_resolve(pl); Yes, that is correct. Please let me know whether that works for you. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!