From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08D4572 for ; Tue, 7 Sep 2021 05:01:22 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 4176960ED8; Tue, 7 Sep 2021 05:01:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1630990882; bh=+DwFL4bVabNWWgQK1ObX9GwAradwBOrI5qsddr1H0FQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W2eVjaaNzftPCY7XxL4jNzAKsRWFFVwWnbe15Kmf2tzVXxToUIVfFI9WQ+lSLqyJh /Bz0q6SWE5VmnymxbRaYrinS3fDCnQKa8NQHqdpCIilFa/jTk4cjoZNpSg9r4effde bPIbtPwZbzYc1g8iKbM9Zz2h3qW/HCnFBZWG+E9Y= Date: Tue, 7 Sep 2021 07:01:11 +0200 From: Greg Kroah-Hartman To: Pavel Skripkin Cc: "Fabio M. De Francesco" , Larry Finger , Phillip Potter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] staging: r8188eu: remove _io_ops structure Message-ID: References: <20210904220048.12822-1-fmdefrancesco@gmail.com> <20210904220048.12822-2-fmdefrancesco@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Sep 06, 2021 at 08:19:05PM +0300, Pavel Skripkin wrote: > On 9/6/21 16:56, Greg Kroah-Hartman wrote: > > On Sun, Sep 05, 2021 at 12:00:46AM +0200, Fabio M. De Francesco wrote: > > > -void _rtw_read_mem(struct adapter *adapter, u32 addr, u32 cnt, u8 *pmem) > > > -{ > > > - void (*_read_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem); > > > - struct io_priv *pio_priv = &adapter->iopriv; > > > - struct intf_hdl *pintfhdl = &pio_priv->intf; > > > - > > > - > > > - if (adapter->bDriverStopped || adapter->bSurpriseRemoved) > > > - return; > > > - _read_mem = pintfhdl->io_ops._read_mem; > > > - _read_mem(pintfhdl, addr, cnt, pmem); > > > - > > > -} > > > > This is odd, in that it resolves down to usb_read_mem which does > > nothing at all. > > > > And then no one calls this at all either? > > > > How about removing the io ops that are not used at all first, one at a > > time, making it obvious what is happening, and then convert the ones > > that are used one at a time, and when all is done, then removing the > > structure? > > > > Just have started to cut one big patch to smaller ones and does it make > sense to group changes like: one for usb_read*, one for usb_write* and one > for usb_port*? I think, it would be cleaner and series won't be too big. > > > What do you think? I will not know until I see the patches, so no need to ask :)