From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91A11C4332F for ; Tue, 7 Sep 2021 17:54:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7720461130 for ; Tue, 7 Sep 2021 17:54:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229601AbhIGRzT (ORCPT ); Tue, 7 Sep 2021 13:55:19 -0400 Received: from mga02.intel.com ([134.134.136.20]:33561 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233525AbhIGRzS (ORCPT ); Tue, 7 Sep 2021 13:55:18 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10100"; a="207504544" X-IronPort-AV: E=Sophos;i="5.85,274,1624345200"; d="scan'208";a="207504544" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2021 10:54:12 -0700 X-IronPort-AV: E=Sophos;i="5.85,274,1624345200"; d="scan'208";a="449103196" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2021 10:54:07 -0700 Received: from andy by smile with local (Exim 4.95-RC2) (envelope-from ) id 1mNfIK-000zB0-0M; Tue, 07 Sep 2021 20:54:04 +0300 Date: Tue, 7 Sep 2021 20:54:04 +0300 From: Andy Shevchenko To: Chris Morgan Cc: abel.vesa@nxp.com, festevam@gmail.com, heiko@sntech.de, kernel@pengutronix.de, lee.jones@linaro.org, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, mturquette@baylibre.com, rafael.j.wysocki@intel.com, rjw@rjwysocki.net, s.hauer@pengutronix.de, sboyd@kernel.org, shawnguo@kernel.org, zhangqing@rock-chips.com, Chris Morgan Subject: Re: [PATCH v4 1/4] clk: fractional-divider: Export approximation algorithm to the CCF users Message-ID: References: <20210812170025.67074-1-andriy.shevchenko@linux.intel.com> <20210907154400.26656-1-macroalpha82@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210907154400.26656-1-macroalpha82@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Tue, Sep 07, 2021 at 10:44:00AM -0500, Chris Morgan wrote: > From: Chris Morgan > > Unfortunately, I can confirm this breaks the DSI panel on the Rockchip > PX30 (and possibly other SoCs). Tested on my Odroid Go Advance. When > I revert 4e7cf74fa3b2 "clk: fractional-divider: Export approximation > algorithm to the CCF users" and 928f9e268611 "clk: fractional-divider: > Hide clk_fractional_divider_ops from wide audience" the panel begins > working again as expected on the master branch. > > It looks like an assumption is made in the vop_crtc_mode_fixup() > function in the rockchip_drm_vop.c that gets broken with this change. > Specifically, the function says in the comments "When DRM gives us a > mode, we should add 999 Hz to it.". I believe this is no longer true > after this clk change, and when I remove the + 999 from the function > the DSI panel works again. Note that I do not know the implications > of removing this 999 aside from that it fixes the DSI panel on my > PX30 after this change, so I don't know if it's a positive change > or not. > > Thank you. Thank you for the report! I'll check this. Perhaps Heiko can help with testing as well on his side. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB805C433F5 for ; Tue, 7 Sep 2021 17:54:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B764E61100 for ; Tue, 7 Sep 2021 17:54:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B764E61100 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gVyTCllK9/DQaZ2CRB6crH5l7FDsRe51AfswNjE6Ol4=; b=uMqfoU8upYsqLJ NSk1cvvKUp4oUwqb3GsldPFcI0lgaBlOMbjnPzgXv6ideMDpaZ1UX8Vik8DXaWH1YUxm+mHJ5P5hO L+OPLrQk+qFqsRLXxp3CN4mIIoS4+IRUgQRCs1TRvzL5s+hm7aSTo6N7uqzMf+WRutTSrNkbEzweq EUY10SH11p+Oaeurs8GOl8ugCEf7kT4iB99kiEt5/DA43bYiPIRyOqd76oMUFt51ymDaJchJ3KK4S 75AGsLclnUChvZnO4VP1WYDC4Ww50UeL/+Z1Gxtfy8PBvZriXUJOUZmflMTwNZ1FDxCKXmQvtoBWZ qOqZwuLEs70UgXRrpByQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNfIg-004OZr-D4; Tue, 07 Sep 2021 17:54:26 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNfIT-004OWM-FR; Tue, 07 Sep 2021 17:54:14 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10100"; a="200483334" X-IronPort-AV: E=Sophos;i="5.85,274,1624345200"; d="scan'208";a="200483334" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2021 10:54:12 -0700 X-IronPort-AV: E=Sophos;i="5.85,274,1624345200"; d="scan'208";a="449103196" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2021 10:54:07 -0700 Received: from andy by smile with local (Exim 4.95-RC2) (envelope-from ) id 1mNfIK-000zB0-0M; Tue, 07 Sep 2021 20:54:04 +0300 Date: Tue, 7 Sep 2021 20:54:04 +0300 From: Andy Shevchenko To: Chris Morgan Cc: abel.vesa@nxp.com, festevam@gmail.com, heiko@sntech.de, kernel@pengutronix.de, lee.jones@linaro.org, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, mturquette@baylibre.com, rafael.j.wysocki@intel.com, rjw@rjwysocki.net, s.hauer@pengutronix.de, sboyd@kernel.org, shawnguo@kernel.org, zhangqing@rock-chips.com, Chris Morgan Subject: Re: [PATCH v4 1/4] clk: fractional-divider: Export approximation algorithm to the CCF users Message-ID: References: <20210812170025.67074-1-andriy.shevchenko@linux.intel.com> <20210907154400.26656-1-macroalpha82@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210907154400.26656-1-macroalpha82@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_105413_573626_DB5F68A1 X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tue, Sep 07, 2021 at 10:44:00AM -0500, Chris Morgan wrote: > From: Chris Morgan > > Unfortunately, I can confirm this breaks the DSI panel on the Rockchip > PX30 (and possibly other SoCs). Tested on my Odroid Go Advance. When > I revert 4e7cf74fa3b2 "clk: fractional-divider: Export approximation > algorithm to the CCF users" and 928f9e268611 "clk: fractional-divider: > Hide clk_fractional_divider_ops from wide audience" the panel begins > working again as expected on the master branch. > > It looks like an assumption is made in the vop_crtc_mode_fixup() > function in the rockchip_drm_vop.c that gets broken with this change. > Specifically, the function says in the comments "When DRM gives us a > mode, we should add 999 Hz to it.". I believe this is no longer true > after this clk change, and when I remove the + 999 from the function > the DSI panel works again. Note that I do not know the implications > of removing this 999 aside from that it fixes the DSI panel on my > PX30 after this change, so I don't know if it's a positive change > or not. > > Thank you. Thank you for the report! I'll check this. Perhaps Heiko can help with testing as well on his side. -- With Best Regards, Andy Shevchenko _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01374C433F5 for ; Tue, 7 Sep 2021 17:55:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BFA2F6044F for ; Tue, 7 Sep 2021 17:55:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BFA2F6044F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=bks9NnGgUzvxzSz+SyajhpcJyywCYcpU1WHymuI5Sj4=; b=ZhUIrls23NtcXE vjgodi3DvFzD3FqBj/uQUV1VA0GRkt/BeNW38dj3H+usuy7hFcJGx+3aF4EbR9x+VzSw/l5ZTsI0Y ToJfSqtWxs8AjQf4sSV4yp31L9zzoNt8I3V/+U8WMzwDdx05VDJyKlhd4pSDeHoMMuy569YQM/Dzj PqusUEBhXZdduqJlRU3g5UJp33Fu0GxKCO6i6sZo0nGv6Q2j7Y9lvCF512wqL43V2PIGT78rcFlMo IqxlVoDKlLVOCANQpTFmov4RegoY291hGW7Y3j70nedU1IRtdOvty2p464IjVTjMV0slvTlJQBc0z J8LrQJkTtTi01eGtXG/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNfIW-004OXk-Ua; Tue, 07 Sep 2021 17:54:17 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNfIT-004OWM-FR; Tue, 07 Sep 2021 17:54:14 +0000 X-IronPort-AV: E=McAfee;i="6200,9189,10100"; a="200483334" X-IronPort-AV: E=Sophos;i="5.85,274,1624345200"; d="scan'208";a="200483334" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2021 10:54:12 -0700 X-IronPort-AV: E=Sophos;i="5.85,274,1624345200"; d="scan'208";a="449103196" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Sep 2021 10:54:07 -0700 Received: from andy by smile with local (Exim 4.95-RC2) (envelope-from ) id 1mNfIK-000zB0-0M; Tue, 07 Sep 2021 20:54:04 +0300 Date: Tue, 7 Sep 2021 20:54:04 +0300 From: Andy Shevchenko To: Chris Morgan Cc: abel.vesa@nxp.com, festevam@gmail.com, heiko@sntech.de, kernel@pengutronix.de, lee.jones@linaro.org, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, mturquette@baylibre.com, rafael.j.wysocki@intel.com, rjw@rjwysocki.net, s.hauer@pengutronix.de, sboyd@kernel.org, shawnguo@kernel.org, zhangqing@rock-chips.com, Chris Morgan Subject: Re: [PATCH v4 1/4] clk: fractional-divider: Export approximation algorithm to the CCF users Message-ID: References: <20210812170025.67074-1-andriy.shevchenko@linux.intel.com> <20210907154400.26656-1-macroalpha82@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210907154400.26656-1-macroalpha82@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210907_105413_573626_DB5F68A1 X-CRM114-Status: GOOD ( 18.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 07, 2021 at 10:44:00AM -0500, Chris Morgan wrote: > From: Chris Morgan > > Unfortunately, I can confirm this breaks the DSI panel on the Rockchip > PX30 (and possibly other SoCs). Tested on my Odroid Go Advance. When > I revert 4e7cf74fa3b2 "clk: fractional-divider: Export approximation > algorithm to the CCF users" and 928f9e268611 "clk: fractional-divider: > Hide clk_fractional_divider_ops from wide audience" the panel begins > working again as expected on the master branch. > > It looks like an assumption is made in the vop_crtc_mode_fixup() > function in the rockchip_drm_vop.c that gets broken with this change. > Specifically, the function says in the comments "When DRM gives us a > mode, we should add 999 Hz to it.". I believe this is no longer true > after this clk change, and when I remove the + 999 from the function > the DSI panel works again. Note that I do not know the implications > of removing this 999 aside from that it fixes the DSI panel on my > PX30 after this change, so I don't know if it's a positive change > or not. > > Thank you. Thank you for the report! I'll check this. Perhaps Heiko can help with testing as well on his side. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel