From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E66BC433F5 for ; Wed, 8 Sep 2021 06:49:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D2BE61104 for ; Wed, 8 Sep 2021 06:49:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347856AbhIHGur (ORCPT ); Wed, 8 Sep 2021 02:50:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345785AbhIHGuk (ORCPT ); Wed, 8 Sep 2021 02:50:40 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B779DC061575 for ; Tue, 7 Sep 2021 23:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OrzGM9PLHfbyfeiU5N8A74VHnUlyeQDz1745rBQSmpE=; b=JvLbZFDB8IlVYMmqnbPjeH0zpT RS6TMNs3DqCPi4wnv+3RN+BAWH5wMMsH5OIbUJGjC9c+FFCSx0qVUnY9l1pDwbtkGF0v1rdZSeqkv 8XX7xKR06ZiLWC8KJX9Wc5cBfed6lBQRH62JfWIeV4NJjQStpPIefHWmFJFFjudwengFWX7O9+UKm JnPsIv35qqOOxV/brv/0P5TTjFwkO3aGrqtXxjiSYg3zvBlHIJhqDusKynHPkF+9LwnkgJSAZfb8p N72r4r40Aj7RwC/fkxH0CgbUafSPL2d56ee5y/Rj+rPHP+4/dH3Ce027JiYI5/vdK/Awy8PLopLbN sv0vmElA==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mNrNu-008ZoP-Gv; Wed, 08 Sep 2021 06:48:55 +0000 Date: Wed, 8 Sep 2021 07:48:38 +0100 From: Christoph Hellwig To: Jan Beulich Cc: Juergen Gross , Boris Ostrovsky , Stefano Stabellini , lkml , "xen-devel@lists.xenproject.org" Subject: Re: [PATCH 01/12] swiotlb-xen: avoid double free Message-ID: References: <588b3e6d-2682-160c-468e-44ca4867a570@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 07, 2021 at 02:04:25PM +0200, Jan Beulich wrote: > Of the two paths leading to the "error" label in xen_swiotlb_init() one > didn't allocate anything, while the other did already free what was > allocated. > > Fixes: b82776005369 ("xen/swiotlb: Use the swiotlb_late_init_with_tbl to init Xen-SWIOTLB late when PV PCI is used") > Signed-off-by: Jan Beulich > Cc: stable@vger.kernel.org Looks good, Reviewed-by: Christoph Hellwig