From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E79DBC433EF for ; Wed, 8 Sep 2021 14:43:05 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA96C61104 for ; Wed, 8 Sep 2021 14:43:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AA96C61104 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:37492 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNyn2-0005aT-Ui for qemu-devel@archiver.kernel.org; Wed, 08 Sep 2021 10:43:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49620) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNymL-0004ud-CU for qemu-devel@nongnu.org; Wed, 08 Sep 2021 10:42:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:37112) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNymJ-0000ZP-R8 for qemu-devel@nongnu.org; Wed, 08 Sep 2021 10:42:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631112138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=yQkx3NLOU4ujNIw6JZOB+GJCMfNdcNOEvPwbUJAR4nI=; b=cxcI0nYtrG1HA7btPLkTuOWkIpVKfW+s4GjntPUWXfZfDoFZPmY7DnRDkqfXC7EdGnHJng OhXwcBH89eKauZ1Q6zReVBRVKIPWca8aqyieipwZadFdFMo6oijZjN06sjeNgEYktYWod7 EjAvjzdD6qZMQSXsIAQxmqCQAa1nPfg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-560-daBNFcGpPVeYShhvTzc_Ag-1; Wed, 08 Sep 2021 10:42:17 -0400 X-MC-Unique: daBNFcGpPVeYShhvTzc_Ag-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 603C9835DE1 for ; Wed, 8 Sep 2021 14:42:16 +0000 (UTC) Received: from localhost (unknown [10.39.194.211]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0541C1A26A; Wed, 8 Sep 2021 14:42:15 +0000 (UTC) Date: Wed, 8 Sep 2021 15:42:15 +0100 From: Stefan Hajnoczi To: Stefano Garzarella Subject: Re: [PATCH 2/2] iothread: use IOThreadParamInfo in iothread_[set|get]_param() Message-ID: References: <20210727145936.147032-1-sgarzare@redhat.com> <20210727145936.147032-3-sgarzare@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210727145936.147032-3-sgarzare@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=stefanha@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Oi9xz5AIOA89NDND" Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.393, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --Oi9xz5AIOA89NDND Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 27, 2021 at 04:59:36PM +0200, Stefano Garzarella wrote: > Commit 0445409d74 ("iothread: generalize > iothread_set_param/iothread_get_param") moved common code to set and > get IOThread parameters in two new functions. >=20 > These functions are called inside callbacks, so we don't need to use an > opaque pointer. Let's replace `void *opaque` parameter with > `IOThreadParamInfo *info`. >=20 > Suggested-by: Kevin Wolf > Signed-off-by: Stefano Garzarella > --- > iothread.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) Reviewed-by: Stefan Hajnoczi --Oi9xz5AIOA89NDND Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmE4y8cACgkQnKSrs4Gr c8jf/Af/cZKx5pJYkZnoW/sirAT5xmB7PY3ZIPoQsDs7GYu8D1tNiMbUu8XUzKRx iCalJxCyZctObLWTGMpa0A99wkyxDmd2HotoiJUHSR7b0Vz6F7e1nJW03YyHKJpD WBByWLhLDSGaTF6hp2/gisGPcxl2gmp+Cx7E0CwTErPpleD+yyNyHrRohs915wRp 1TSWuIuz8Tb6dTINX3fI9daV35P/Xb0YR+TYENzgjMTrxQCtJJSrAe8zExz4l1hy 5dvsTBsrmaHp4fMf/hz9U4ueK86Ipxzu0Y1mo/S+Ps6LDM27MZqB/QxvAd/lSsvN xXNEtoWrvBWu+K8/EC8emsADppGcCQ== =L/5D -----END PGP SIGNATURE----- --Oi9xz5AIOA89NDND--