* [PATCH] mt76: mt7915: fix WMM index on DBDC cards
@ 2021-09-08 15:58 Felix Fietkau
2021-09-09 8:10 ` Lorenzo Bianconi
0 siblings, 1 reply; 2+ messages in thread
From: Felix Fietkau @ 2021-09-08 15:58 UTC (permalink / raw)
To: linux-wireless
WMM index range needs to be split between both PHYs if a second PHY exists.
The condition for that was accidentally written as checking if the vif PHY
is the secondary one
Signed-off-by: Felix Fietkau <nbd@nbd.name>
---
drivers/net/wireless/mediatek/mt76/mt7915/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/main.c b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
index 748ea70ea12e..a19e68668c65 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/main.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
@@ -215,7 +215,7 @@ static int mt7915_add_interface(struct ieee80211_hw *hw,
mvif->phy = phy;
mvif->band_idx = ext_phy;
- if (ext_phy)
+ if (dev->mt76.phy2)
mvif->wmm_idx = ext_phy * (MT7915_MAX_WMM_SETS / 2) +
mvif->idx % (MT7915_MAX_WMM_SETS / 2);
else
--
2.30.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mt76: mt7915: fix WMM index on DBDC cards
2021-09-08 15:58 [PATCH] mt76: mt7915: fix WMM index on DBDC cards Felix Fietkau
@ 2021-09-09 8:10 ` Lorenzo Bianconi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Bianconi @ 2021-09-09 8:10 UTC (permalink / raw)
To: Felix Fietkau; +Cc: linux-wireless
[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]
> WMM index range needs to be split between both PHYs if a second PHY exists.
> The condition for that was accidentally written as checking if the vif PHY
> is the secondary one
We need to add the following Fixes tag here:
Fixes: e57b7901469fc ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")
Regards,
Lorenzo
>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> ---
> drivers/net/wireless/mediatek/mt76/mt7915/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/main.c b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
> index 748ea70ea12e..a19e68668c65 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/main.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/main.c
> @@ -215,7 +215,7 @@ static int mt7915_add_interface(struct ieee80211_hw *hw,
> mvif->phy = phy;
> mvif->band_idx = ext_phy;
>
> - if (ext_phy)
> + if (dev->mt76.phy2)
> mvif->wmm_idx = ext_phy * (MT7915_MAX_WMM_SETS / 2) +
> mvif->idx % (MT7915_MAX_WMM_SETS / 2);
> else
> --
> 2.30.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-09 8:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-08 15:58 [PATCH] mt76: mt7915: fix WMM index on DBDC cards Felix Fietkau
2021-09-09 8:10 ` Lorenzo Bianconi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.