From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CE9BC433EF for ; Thu, 9 Sep 2021 11:23:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DE4C61104 for ; Thu, 9 Sep 2021 11:23:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235274AbhIILYP (ORCPT ); Thu, 9 Sep 2021 07:24:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234902AbhIILYO (ORCPT ); Thu, 9 Sep 2021 07:24:14 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3ED3FC061575; Thu, 9 Sep 2021 04:23:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=M0gopQrsLr3UAE05SLf2KetoSMl+JUlvHkNklgk7J9I=; b=eKmuEo4gN8a1EQvUGgpk6G4bYV 88f9akYrx4vCinB+HrE5W4fV4xy5i0AZjkMIi4jKkgdOw1jLlLbHHRVOiDTaO/4nNS0K1HLejmpe5 0o5YZQtKGjDkNmcjr5dUaSb2Zmaeo9iUc58oBQEvnfo7jg4ElgxLUgr3ubxQLXr6EYRerwp0qz+3F 1EscQ3c8K7ZiaH+IKihiC/tfZCgXwy8y+PtUSKGxwi2e7V8UgQGIhGToNFsvjT9EHnAOOJEhH5LSz 8xRdQhq1nmn6JpTmQuf9R/LsczQVWETH5dW8lGkfcqPUa0dY7yMLhVllKxsr5hiiX1jo1EOyNT+w7 +VEvjvfQ==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOI6o-009l4w-TK; Thu, 09 Sep 2021 11:20:53 +0000 Date: Thu, 9 Sep 2021 12:20:46 +0100 From: Christoph Hellwig To: Andreas Gruenbacher Cc: Linus Torvalds , Alexander Viro , Christoph Hellwig , "Darrick J. Wong" , Jan Kara , Matthew Wilcox , cluster-devel@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: Re: [PATCH v7 15/19] iomap: Support partial direct I/O on user copy failures Message-ID: References: <20210827164926.1726765-1-agruenba@redhat.com> <20210827164926.1726765-16-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210827164926.1726765-16-agruenba@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 27, 2021 at 06:49:22PM +0200, Andreas Gruenbacher wrote: > In iomap_dio_rw, when iomap_apply returns an -EFAULT error and the > IOMAP_DIO_PARTIAL flag is set, complete the request synchronously and > return a partial result. This allows the caller to deal with the page > fault and retry the remainder of the request. > > Signed-off-by: Andreas Gruenbacher > --- > fs/iomap/direct-io.c | 6 ++++++ > include/linux/iomap.h | 7 +++++++ > 2 files changed, 13 insertions(+) > > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > index 8054f5d6c273..ba88fe51b77a 100644 > --- a/fs/iomap/direct-io.c > +++ b/fs/iomap/direct-io.c > @@ -561,6 +561,12 @@ __iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, > ret = iomap_apply(inode, pos, count, iomap_flags, ops, dio, > iomap_dio_actor); > if (ret <= 0) { > + if (ret == -EFAULT && dio->size && > + (dio_flags & IOMAP_DIO_PARTIAL)) { > + wait_for_completion = true; > + ret = 0; Do we need a NOWAIT check here to skip the wait_for_completion for that case? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5F19C433EF for ; Thu, 9 Sep 2021 11:23:16 +0000 (UTC) Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7B32A61100 for ; Thu, 9 Sep 2021 11:23:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7B32A61100 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=oss.oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 1899CJuB029648; Thu, 9 Sep 2021 11:23:15 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3ayfe90a6s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 09 Sep 2021 11:23:15 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 189BErtq052317; Thu, 9 Sep 2021 11:23:14 GMT Received: from oss.oracle.com (oss-old-reserved.oracle.com [137.254.22.2]) by userp3030.oracle.com with ESMTP id 3axcq2td36-1 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO); Thu, 09 Sep 2021 11:23:14 +0000 Received: from localhost ([127.0.0.1] helo=lb-oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1mOI9B-0002U5-Ac; Thu, 09 Sep 2021 04:23:13 -0700 Received: from aserp3030.oracle.com ([141.146.126.71]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1mOI96-0002Tm-7k for ocfs2-devel@oss.oracle.com; Thu, 09 Sep 2021 04:23:08 -0700 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 189BGGpl147858 for ; Thu, 9 Sep 2021 11:23:08 GMT Received: from mx0a-00069f01.pphosted.com (mx0a-00069f01.pphosted.com [205.220.165.26]) by aserp3030.oracle.com with ESMTP id 3axcpq2tjt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 09 Sep 2021 11:23:07 +0000 Received: from pps.filterd (m0246572.ppops.net [127.0.0.1]) by mx0b-00069f01.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 1898L0QU028499 for ; Thu, 9 Sep 2021 11:23:06 GMT Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by mx0b-00069f01.pphosted.com with ESMTP id 3ay862p3v8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Thu, 09 Sep 2021 11:23:06 +0000 Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOI6o-009l4w-TK; Thu, 09 Sep 2021 11:20:53 +0000 Date: Thu, 9 Sep 2021 12:20:46 +0100 From: Christoph Hellwig To: Andreas Gruenbacher Message-ID: References: <20210827164926.1726765-1-agruenba@redhat.com> <20210827164926.1726765-16-agruenba@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210827164926.1726765-16-agruenba@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Source-IP: 90.155.50.34 X-ServerName: casper.infradead.org X-Proofpoint-SPF-Result: None X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10101 signatures=668682 X-Proofpoint-Spam-Details: rule=tap_notspam policy=tap score=0 bulkscore=0 phishscore=0 clxscore=323 suspectscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 priorityscore=234 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109090069 X-Spam: Clean Cc: cluster-devel@redhat.com, Jan Kara , linux-kernel@vger.kernel.org, Christoph Hellwig , Alexander Viro , linux-fsdevel@vger.kernel.org, Linus Torvalds , ocfs2-devel@oss.oracle.com Subject: Re: [Ocfs2-devel] [PATCH v7 15/19] iomap: Support partial direct I/O on user copy failures X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10101 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 adultscore=0 malwarescore=0 mlxscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109090069 X-Proofpoint-GUID: 2wLx1rnqDGToF32SjihF5kRhQpPBrhJQ X-Proofpoint-ORIG-GUID: 2wLx1rnqDGToF32SjihF5kRhQpPBrhJQ On Fri, Aug 27, 2021 at 06:49:22PM +0200, Andreas Gruenbacher wrote: > In iomap_dio_rw, when iomap_apply returns an -EFAULT error and the > IOMAP_DIO_PARTIAL flag is set, complete the request synchronously and > return a partial result. This allows the caller to deal with the page > fault and retry the remainder of the request. > > Signed-off-by: Andreas Gruenbacher > --- > fs/iomap/direct-io.c | 6 ++++++ > include/linux/iomap.h | 7 +++++++ > 2 files changed, 13 insertions(+) > > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > index 8054f5d6c273..ba88fe51b77a 100644 > --- a/fs/iomap/direct-io.c > +++ b/fs/iomap/direct-io.c > @@ -561,6 +561,12 @@ __iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, > ret = iomap_apply(inode, pos, count, iomap_flags, ops, dio, > iomap_dio_actor); > if (ret <= 0) { > + if (ret == -EFAULT && dio->size && > + (dio_flags & IOMAP_DIO_PARTIAL)) { > + wait_for_completion = true; > + ret = 0; Do we need a NOWAIT check here to skip the wait_for_completion for that case? _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Thu, 9 Sep 2021 12:20:46 +0100 Subject: [Cluster-devel] [PATCH v7 15/19] iomap: Support partial direct I/O on user copy failures In-Reply-To: <20210827164926.1726765-16-agruenba@redhat.com> References: <20210827164926.1726765-1-agruenba@redhat.com> <20210827164926.1726765-16-agruenba@redhat.com> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Aug 27, 2021 at 06:49:22PM +0200, Andreas Gruenbacher wrote: > In iomap_dio_rw, when iomap_apply returns an -EFAULT error and the > IOMAP_DIO_PARTIAL flag is set, complete the request synchronously and > return a partial result. This allows the caller to deal with the page > fault and retry the remainder of the request. > > Signed-off-by: Andreas Gruenbacher > --- > fs/iomap/direct-io.c | 6 ++++++ > include/linux/iomap.h | 7 +++++++ > 2 files changed, 13 insertions(+) > > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > index 8054f5d6c273..ba88fe51b77a 100644 > --- a/fs/iomap/direct-io.c > +++ b/fs/iomap/direct-io.c > @@ -561,6 +561,12 @@ __iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, > ret = iomap_apply(inode, pos, count, iomap_flags, ops, dio, > iomap_dio_actor); > if (ret <= 0) { > + if (ret == -EFAULT && dio->size && > + (dio_flags & IOMAP_DIO_PARTIAL)) { > + wait_for_completion = true; > + ret = 0; Do we need a NOWAIT check here to skip the wait_for_completion for that case?