From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E93F0C433F5 for ; Fri, 10 Sep 2021 07:26:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDB5361059 for ; Fri, 10 Sep 2021 07:26:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231396AbhIJH1e (ORCPT ); Fri, 10 Sep 2021 03:27:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231290AbhIJH13 (ORCPT ); Fri, 10 Sep 2021 03:27:29 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 862FAC061574; Fri, 10 Sep 2021 00:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=087+0CiZqvP07DsW5DSevAPmxX0P+Bu6ZoYX2WEyOJQ=; b=Ik/NbsR162FqLJapnUR/sS8UKy nZsQzTiixipnJnpCTwF1/o3Py4Phj2l/15kz31oxyk0L5dXx6orfQv3hChQpUN5b8GDK3671W7vUO acBpWMQb6GNywBqMIpk84LeLKYiMYjr8Yt4QQ5iRQpktx6mFnEA5lzoOyUje88bqRP3wAZWFZSsxk tLxmEvjTbAFm3GEtoV6AT6euR3S6XjLvRYtcqvH3B2H8ig6IO5dmbxnpvnhei0pPVcekr5pQ14r5v y7Sx/MUn+A3UalVcwDOGV80URjJOxnRosjSO1YHOQB4Z9OJy1MK8JTqi6xEGHe6gs2gT/b45Wxi2E aCK0Wcmg==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOatG-00AmTN-Ld; Fri, 10 Sep 2021 07:24:19 +0000 Date: Fri, 10 Sep 2021 08:24:02 +0100 From: Christoph Hellwig To: Linus Torvalds Cc: Christoph Hellwig , Andreas Gruenbacher , Alexander Viro , "Darrick J. Wong" , Jan Kara , Matthew Wilcox , cluster-devel , linux-fsdevel , Linux Kernel Mailing List , ocfs2-devel@oss.oracle.com Subject: Re: [PATCH v7 17/19] gup: Introduce FOLL_NOFAULT flag to disable page faults Message-ID: References: <20210827164926.1726765-1-agruenba@redhat.com> <20210827164926.1726765-18-agruenba@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 09, 2021 at 10:17:14AM -0700, Linus Torvalds wrote: > So I think we should treat FOLL_FAST_ONLY as a special "internal to > gup.c" flag, and perhaps not really compare it to the new > FOLL_NOFAULT. > > In fact, maybe we could even just make FOLL_FAST_ONLY be the high bit, > and not expose it in and make it entirely private as a > name in gup.c. There are quite a few bits like that. I've been wanting to make them private for 5.16. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8CE8C433EF for ; Fri, 10 Sep 2021 07:32:59 +0000 (UTC) Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39C3A61153 for ; Fri, 10 Sep 2021 07:32:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 39C3A61153 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=oss.oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18A50MfJ029662; Fri, 10 Sep 2021 07:32:58 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3aytk8s140-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 10 Sep 2021 07:32:58 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 18A7QuDs022304; Fri, 10 Sep 2021 07:32:57 GMT Received: from oss.oracle.com (oss-old-reserved.oracle.com [137.254.22.2]) by userp3030.oracle.com with ESMTP id 3aytftj1y1-1; Fri, 10 Sep 2021 07:32:57 +0000 Received: from localhost ([127.0.0.1] helo=lb-oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1mOavm-00053F-9Z; Fri, 10 Sep 2021 00:26:38 -0700 Received: from aserp3020.oracle.com ([141.146.126.70]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1mOavh-00052o-BP for ocfs2-devel@oss.oracle.com; Fri, 10 Sep 2021 00:26:33 -0700 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 18A7QAG2127843 for ; Fri, 10 Sep 2021 07:26:33 GMT Received: from mx0b-00069f01.pphosted.com (mx0b-00069f01.pphosted.com [205.220.177.26]) by aserp3020.oracle.com with ESMTP id 3aytfy03gg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 10 Sep 2021 07:26:32 +0000 Received: from pps.filterd (m0246576.ppops.net [127.0.0.1]) by mx0b-00069f01.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 18A3rlWm030748 for ; Fri, 10 Sep 2021 07:26:32 GMT Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by mx0b-00069f01.pphosted.com with ESMTP id 3aytvd50kp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Fri, 10 Sep 2021 07:26:31 +0000 Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOatG-00AmTN-Ld; Fri, 10 Sep 2021 07:24:19 +0000 Date: Fri, 10 Sep 2021 08:24:02 +0100 From: Christoph Hellwig To: Linus Torvalds Message-ID: References: <20210827164926.1726765-1-agruenba@redhat.com> <20210827164926.1726765-18-agruenba@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html X-Source-IP: 90.155.50.34 X-ServerName: casper.infradead.org X-Proofpoint-SPF-Result: None X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10102 signatures=668682 X-Proofpoint-Spam-Details: rule=tap_notspam policy=tap score=0 clxscore=287 lowpriorityscore=0 adultscore=0 mlxscore=0 bulkscore=0 malwarescore=0 mlxlogscore=487 spamscore=0 phishscore=0 impostorscore=0 suspectscore=0 priorityscore=190 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109100045 X-Spam: Clean Cc: cluster-devel , Jan Kara , Andreas Gruenbacher , Linux Kernel Mailing List , Christoph Hellwig , Alexander Viro , linux-fsdevel , ocfs2-devel@oss.oracle.com Subject: Re: [Ocfs2-devel] [PATCH v7 17/19] gup: Introduce FOLL_NOFAULT flag to disable page faults X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10102 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 bulkscore=0 phishscore=0 spamscore=0 malwarescore=0 suspectscore=0 mlxscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109100045 X-Proofpoint-GUID: VGfFPWl66LtWBiEzmZTO0TEzgP4BM3IX X-Proofpoint-ORIG-GUID: VGfFPWl66LtWBiEzmZTO0TEzgP4BM3IX On Thu, Sep 09, 2021 at 10:17:14AM -0700, Linus Torvalds wrote: > So I think we should treat FOLL_FAST_ONLY as a special "internal to > gup.c" flag, and perhaps not really compare it to the new > FOLL_NOFAULT. > > In fact, maybe we could even just make FOLL_FAST_ONLY be the high bit, > and not expose it in and make it entirely private as a > name in gup.c. There are quite a few bits like that. I've been wanting to make them private for 5.16. _______________________________________________ Ocfs2-devel mailing list Ocfs2-devel@oss.oracle.com https://oss.oracle.com/mailman/listinfo/ocfs2-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Date: Fri, 10 Sep 2021 08:24:02 +0100 Subject: [Cluster-devel] [PATCH v7 17/19] gup: Introduce FOLL_NOFAULT flag to disable page faults In-Reply-To: References: <20210827164926.1726765-1-agruenba@redhat.com> <20210827164926.1726765-18-agruenba@redhat.com> Message-ID: List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Sep 09, 2021 at 10:17:14AM -0700, Linus Torvalds wrote: > So I think we should treat FOLL_FAST_ONLY as a special "internal to > gup.c" flag, and perhaps not really compare it to the new > FOLL_NOFAULT. > > In fact, maybe we could even just make FOLL_FAST_ONLY be the high bit, > and not expose it in and make it entirely private as a > name in gup.c. There are quite a few bits like that. I've been wanting to make them private for 5.16.