From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 684F4C433F5 for ; Fri, 10 Sep 2021 12:12:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C90B611C8 for ; Fri, 10 Sep 2021 12:12:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233109AbhIJMNj (ORCPT ); Fri, 10 Sep 2021 08:13:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233025AbhIJMNi (ORCPT ); Fri, 10 Sep 2021 08:13:38 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC946C061574; Fri, 10 Sep 2021 05:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wfe0wRNwadGuipT2q3vfuqzKoGJ2bWIK7Uw5w2tgJTc=; b=EGI6r5rOor4TTYVJT2LtMloVb3 uaAaLVZkg7VF0gnAd+Efe3guV4pPIj/J6pwSyX+4dJNTyeBg1tFkhH8a9EiKTRVrjv7HQQ8x+ojmf Qkmw8rk5YO5ZXSjUEmP3XHBloWs2RV0ClS+1YFDNXyIYLYiyvpJq71V6uttxDmeFC6My7NBuwzwRC qLHVNIhU//sE3mHPQCPTk36mbmi49QN8W1zM6uAtXW0oHVCGIDbLhQrSMontgY+fEmRtCGJksCRQr Ge4EbGvO04IP5g8z0jByUOXvHNoA5qHXSpkvx/n4R1DABL0qvTg70y3HsTi2J4/onsRTgtPZoXPGY c2Lzj6TQ==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOfMk-00Az2M-HA; Fri, 10 Sep 2021 12:10:58 +0000 Date: Fri, 10 Sep 2021 13:10:46 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: David Airlie , Tony Krowiak , Alex Williamson , Christian Borntraeger , Cornelia Huck , Daniel Vetter , dri-devel@lists.freedesktop.org, Eric Farman , Harald Freudenberger , Vasily Gorbik , Heiko Carstens , intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, Jani Nikula , Jason Herne , Joonas Lahtinen , kvm@vger.kernel.org, Kirti Wankhede , linux-s390@vger.kernel.org, Matthew Rosato , Peter Oberparleiter , Halil Pasic , Rodrigo Vivi , Vineeth Vijayan , Zhenyu Wang , Zhi Wang , Christoph Hellwig Subject: Re: [PATCH v2 5/9] vfio/mdev: Consolidate all the device_api sysfs into the core code Message-ID: References: <0-v2-7d3a384024cf+2060-ccw_mdev_jgg@nvidia.com> <5-v2-7d3a384024cf+2060-ccw_mdev_jgg@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5-v2-7d3a384024cf+2060-ccw_mdev_jgg@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Thu, Sep 09, 2021 at 04:38:45PM -0300, Jason Gunthorpe wrote: > Every driver just emits a static string, simply feed it through the ops > and provide a standard sysfs show function. Looks sensible. But can you make the attribute optional and add a comment marking it deprecated? Because it really is completely useless. We don't version userspace APIs, userspae has to discover new features individually by e.g. finding new sysfs files or just trying new ioctls. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8324C43217 for ; Fri, 10 Sep 2021 12:12:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A363611CA for ; Fri, 10 Sep 2021 12:12:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3A363611CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C3B026E9EE; Fri, 10 Sep 2021 12:12:16 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB2246E9ED; Fri, 10 Sep 2021 12:12:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wfe0wRNwadGuipT2q3vfuqzKoGJ2bWIK7Uw5w2tgJTc=; b=EGI6r5rOor4TTYVJT2LtMloVb3 uaAaLVZkg7VF0gnAd+Efe3guV4pPIj/J6pwSyX+4dJNTyeBg1tFkhH8a9EiKTRVrjv7HQQ8x+ojmf Qkmw8rk5YO5ZXSjUEmP3XHBloWs2RV0ClS+1YFDNXyIYLYiyvpJq71V6uttxDmeFC6My7NBuwzwRC qLHVNIhU//sE3mHPQCPTk36mbmi49QN8W1zM6uAtXW0oHVCGIDbLhQrSMontgY+fEmRtCGJksCRQr Ge4EbGvO04IP5g8z0jByUOXvHNoA5qHXSpkvx/n4R1DABL0qvTg70y3HsTi2J4/onsRTgtPZoXPGY c2Lzj6TQ==; Received: from hch by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOfMk-00Az2M-HA; Fri, 10 Sep 2021 12:10:58 +0000 Date: Fri, 10 Sep 2021 13:10:46 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: David Airlie , Tony Krowiak , Alex Williamson , Christian Borntraeger , Cornelia Huck , Daniel Vetter , dri-devel@lists.freedesktop.org, Eric Farman , Harald Freudenberger , Vasily Gorbik , Heiko Carstens , intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, Jani Nikula , Jason Herne , Joonas Lahtinen , kvm@vger.kernel.org, Kirti Wankhede , linux-s390@vger.kernel.org, Matthew Rosato , Peter Oberparleiter , Halil Pasic , Rodrigo Vivi , Vineeth Vijayan , Zhenyu Wang , Zhi Wang , Christoph Hellwig Message-ID: References: <0-v2-7d3a384024cf+2060-ccw_mdev_jgg@nvidia.com> <5-v2-7d3a384024cf+2060-ccw_mdev_jgg@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5-v2-7d3a384024cf+2060-ccw_mdev_jgg@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Subject: Re: [Intel-gfx] [PATCH v2 5/9] vfio/mdev: Consolidate all the device_api sysfs into the core code X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Sep 09, 2021 at 04:38:45PM -0300, Jason Gunthorpe wrote: > Every driver just emits a static string, simply feed it through the ops > and provide a standard sysfs show function. Looks sensible. But can you make the attribute optional and add a comment marking it deprecated? Because it really is completely useless. We don't version userspace APIs, userspae has to discover new features individually by e.g. finding new sysfs files or just trying new ioctls.