From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D0A2C433F5 for ; Sat, 11 Sep 2021 18:55:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C06961051 for ; Sat, 11 Sep 2021 18:55:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6C06961051 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 243976EC11; Sat, 11 Sep 2021 18:55:06 +0000 (UTC) Received: from mx1.smtp.larsendata.com (mx1.smtp.larsendata.com [91.221.196.215]) by gabe.freedesktop.org (Postfix) with ESMTPS id 684626EC11 for ; Sat, 11 Sep 2021 18:55:04 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx1.smtp.larsendata.com (Halon) with ESMTPS id bd1f5301-1331-11ec-a02a-0050568c148b; Sat, 11 Sep 2021 18:54:48 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id CD92F194B9F; Sat, 11 Sep 2021 20:54:50 +0200 (CEST) Date: Sat, 11 Sep 2021 20:54:56 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Simon Ser Cc: dri-devel@lists.freedesktop.org, Jared Baldridge , Emil Velikov , Daniel Vetter , Hans de Goede Subject: Re: [PATCH] drm/panel-orientation-quirks: add Valve Steam Deck Message-ID: References: <20210911102430.253986-1-contact@emersion.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210911102430.253986-1-contact@emersion.fr> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Simon, On Sat, Sep 11, 2021 at 10:24:40AM +0000, Simon Ser wrote: > Valve's Steam Deck has a 800x1280 LCD screen. > > Signed-off-by: Simon Ser > Cc: Jared Baldridge > Cc: Emil Velikov > Cc: Daniel Vetter > Cc: Hans de Goede The sorting is off - "Valve Steam Deck" comes before "VIOS LTH17" With the sorting fixed: Acked-by: Sam Ravnborg (Not that I know this code, but I wanted to avoid this patch meeting the same fate as the patch from Hans that was left with no feedback for a long time). Sam > --- > drivers/gpu/drm/drm_panel_orientation_quirks.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c > index f6bdec7fa925..3018d1dcd271 100644 > --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c > +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c > @@ -231,6 +231,13 @@ static const struct dmi_system_id orientation_data[] = { > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "LTH17"), > }, > .driver_data = (void *)&lcd800x1280_rightside_up, > + }, { /* Valve Steam Deck */ > + .matches = { > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Valve"), > + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Jupiter"), > + DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "1"), > + }, > + .driver_data = (void *)&lcd800x1280_rightside_up, > }, > {} > }; > -- > 2.33.0 >