From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDB76C433FE for ; Fri, 24 Sep 2021 11:36:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC7CD61242 for ; Fri, 24 Sep 2021 11:36:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343521AbhIXLhp (ORCPT ); Fri, 24 Sep 2021 07:37:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:46936 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244439AbhIXLhn (ORCPT ); Fri, 24 Sep 2021 07:37:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 48BDF61241; Fri, 24 Sep 2021 11:36:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632483370; bh=GVK5jCV+2GJ3l9xXZf3QHWw2lsE24mYjuokUNEhn5jk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U4faQon7fKlxX0nkUG5z8vcWUYqa1p+3n5KLHLD1J69CN72oyLLrlk+q7UBz2pm3X FqZfEJfMat4qISWxH78KWsi9GOQLTKGnLj1Yd/75rlMkhQJkU/ja8bVrTyQxMa/Tts JJqGFTqmryihFozCOEcgOxH4XqXsl38q7B0dWR3g= Date: Fri, 24 Sep 2021 13:36:08 +0200 From: Greg Kroah-Hartman To: Sai Krishna Potthuri Cc: Mark Brown , Rob Herring , Pratyush Yadav , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-spi@vger.kernel.org, git@xilinx.com, saikrishna12468@gmail.com, Arnd Bergmann , Nobuhiro Iwamatsu Subject: Re: [PATCH 1/4] firmware: xilinx: Add OSPI Mux selection support Message-ID: References: <1632478031-12242-1-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> <1632478031-12242-2-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1632478031-12242-2-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 24, 2021 at 03:37:08PM +0530, Sai Krishna Potthuri wrote: > Add OSPI Mux selection API support to select the AXI interface to OSPI. > > Signed-off-by: Sai Krishna Potthuri > --- > drivers/firmware/xilinx/zynqmp.c | 17 +++++++++++++++++ > include/linux/firmware/xlnx-zynqmp.h | 12 ++++++++++++ > 2 files changed, 29 insertions(+) > > diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c > index 15b138326ecc..43c3b5a9eef7 100644 > --- a/drivers/firmware/xilinx/zynqmp.c > +++ b/drivers/firmware/xilinx/zynqmp.c > @@ -647,6 +647,23 @@ int zynqmp_pm_sd_dll_reset(u32 node_id, u32 type) > } > EXPORT_SYMBOL_GPL(zynqmp_pm_sd_dll_reset); > > +/** > + * zynqmp_pm_ospi_mux_select() - OSPI Mux selection > + * > + * @dev_id: Device Id of the OSPI device. > + * @select: OSPI Mux select value. > + * > + * This function select the OSPI Mux. > + * > + * Return: Returns status, either success or error+reason > + */ > +int zynqmp_pm_ospi_mux_select(u32 dev_id, u32 select) > +{ > + return zynqmp_pm_invoke_fn(PM_IOCTL, dev_id, IOCTL_OSPI_MUX_SELECT, > + select, 0, NULL); > +} > +EXPORT_SYMBOL_GPL(zynqmp_pm_ospi_mux_select); > + > /** > * zynqmp_pm_write_ggs() - PM API for writing global general storage (ggs) > * @index: GGS register index > diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h > index 9d1a5c175065..6979a79f553a 100644 > --- a/include/linux/firmware/xlnx-zynqmp.h > +++ b/include/linux/firmware/xlnx-zynqmp.h > @@ -119,6 +119,7 @@ enum pm_ioctl_id { > IOCTL_READ_PGGS = 15, > /* Set healthy bit value */ > IOCTL_SET_BOOT_HEALTH_STATUS = 17, > + IOCTL_OSPI_MUX_SELECT = 21, Why the gap? What are the commands in the middle for? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B57BC433EF for ; Fri, 24 Sep 2021 11:38:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2831A60F3A for ; Fri, 24 Sep 2021 11:38:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2831A60F3A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/bj2VAl1Xtqo0dGjxTL55aNdHswsenXntfginqGp0XE=; b=d/BFn3q6CqalPl MNFXLT0aFyyPAcbwxrLNpBWr+P6d5SgRLNr/cvAC5cViOGLE1uMYVk2EsAMLK2guSREhy6s37nlXh 0cGYLJfU9mF4BHKNF3VVuXpIMEpjbXkVGIFNrL7FlWtiuyGeu65TavTqzaDCUYfgxXp03XvlK1eQq e/7OuqOdFysaYORUYJj5BON0kveNjXyP5vVYN1eslvyps3u+SIe39tPtfvxCF6BxlOpkKbpGF7Ajn kZVIiwsF86fvX78m7pgDmOrgQki1BRLiHqzaI0cCbmwAPo/l4aWTWq50ibx8bOr+607lmXTB6dLWu FIIEQDsLzTX8X7HdXm8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTjV0-00EBc5-DC; Fri, 24 Sep 2021 11:36:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mTjUx-00EBbF-3Q for linux-arm-kernel@lists.infradead.org; Fri, 24 Sep 2021 11:36:12 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 48BDF61241; Fri, 24 Sep 2021 11:36:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632483370; bh=GVK5jCV+2GJ3l9xXZf3QHWw2lsE24mYjuokUNEhn5jk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U4faQon7fKlxX0nkUG5z8vcWUYqa1p+3n5KLHLD1J69CN72oyLLrlk+q7UBz2pm3X FqZfEJfMat4qISWxH78KWsi9GOQLTKGnLj1Yd/75rlMkhQJkU/ja8bVrTyQxMa/Tts JJqGFTqmryihFozCOEcgOxH4XqXsl38q7B0dWR3g= Date: Fri, 24 Sep 2021 13:36:08 +0200 From: Greg Kroah-Hartman To: Sai Krishna Potthuri Cc: Mark Brown , Rob Herring , Pratyush Yadav , Michal Simek , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-spi@vger.kernel.org, git@xilinx.com, saikrishna12468@gmail.com, Arnd Bergmann , Nobuhiro Iwamatsu Subject: Re: [PATCH 1/4] firmware: xilinx: Add OSPI Mux selection support Message-ID: References: <1632478031-12242-1-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> <1632478031-12242-2-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1632478031-12242-2-git-send-email-lakshmi.sai.krishna.potthuri@xilinx.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210924_043611_188689_93F6391D X-CRM114-Status: GOOD ( 15.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 24, 2021 at 03:37:08PM +0530, Sai Krishna Potthuri wrote: > Add OSPI Mux selection API support to select the AXI interface to OSPI. > > Signed-off-by: Sai Krishna Potthuri > --- > drivers/firmware/xilinx/zynqmp.c | 17 +++++++++++++++++ > include/linux/firmware/xlnx-zynqmp.h | 12 ++++++++++++ > 2 files changed, 29 insertions(+) > > diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c > index 15b138326ecc..43c3b5a9eef7 100644 > --- a/drivers/firmware/xilinx/zynqmp.c > +++ b/drivers/firmware/xilinx/zynqmp.c > @@ -647,6 +647,23 @@ int zynqmp_pm_sd_dll_reset(u32 node_id, u32 type) > } > EXPORT_SYMBOL_GPL(zynqmp_pm_sd_dll_reset); > > +/** > + * zynqmp_pm_ospi_mux_select() - OSPI Mux selection > + * > + * @dev_id: Device Id of the OSPI device. > + * @select: OSPI Mux select value. > + * > + * This function select the OSPI Mux. > + * > + * Return: Returns status, either success or error+reason > + */ > +int zynqmp_pm_ospi_mux_select(u32 dev_id, u32 select) > +{ > + return zynqmp_pm_invoke_fn(PM_IOCTL, dev_id, IOCTL_OSPI_MUX_SELECT, > + select, 0, NULL); > +} > +EXPORT_SYMBOL_GPL(zynqmp_pm_ospi_mux_select); > + > /** > * zynqmp_pm_write_ggs() - PM API for writing global general storage (ggs) > * @index: GGS register index > diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h > index 9d1a5c175065..6979a79f553a 100644 > --- a/include/linux/firmware/xlnx-zynqmp.h > +++ b/include/linux/firmware/xlnx-zynqmp.h > @@ -119,6 +119,7 @@ enum pm_ioctl_id { > IOCTL_READ_PGGS = 15, > /* Set healthy bit value */ > IOCTL_SET_BOOT_HEALTH_STATUS = 17, > + IOCTL_OSPI_MUX_SELECT = 21, Why the gap? What are the commands in the middle for? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel