From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9950DC433EF for ; Fri, 24 Sep 2021 10:49:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F25961019 for ; Fri, 24 Sep 2021 10:49:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5F25961019 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gerhold.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 03964833DA; Fri, 24 Sep 2021 12:49:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gerhold.net Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gerhold.net header.i=@gerhold.net header.b="Ev/cQS2m"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6570083400; Fri, 24 Sep 2021 12:48:59 +0200 (CEST) Received: from mo4-p00-ob.smtp.rzone.de (mo4-p00-ob.smtp.rzone.de [85.215.255.24]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A6B8F83246 for ; Fri, 24 Sep 2021 12:48:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=gerhold.net Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=stephan@gerhold.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1632480534; s=strato-dkim-0002; d=gerhold.net; h=In-Reply-To:References:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=g3UAIEUblVbEvzN0bQv0p4WOFPRhIRGOo0ugVLxLpaY=; b=Ev/cQS2mEeEmi+6E273Tr5BY8aCfIq2E80ZquzYNTdarPTrjTsHrcSZUwwQeODT9s+ Eup9i+GyC3cKBtC051zctiiNXanWhQ47ZYuClJ3fU7DugmxCGgyx3U6iXX/oJ1xBXRxo qq+Y7zSwnjywi3lx4lhDD2EoUmrEPbdjW5iAoa+bZU/dGsCM9A2U8aiJ/VnpfKYK4xcm PocRjBx2UWlPH4HyogN8q1667U3ADh60p5p3Rz+WI/1GcXvvG4hYzgJXKiBiv4fv4Ozj jspAiT+WmlTi/Zymmv+RpMUs5BNYfmFyWa9X9nwxuObyNuJWDEggPDGH8wllxro6DXsD 7hHg== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":P3gBZUipdd93FF5ZZvYFPugejmSTVR2nRPhVOQ/OcYgojyw4j34+u261EJF5OxJD4pWA8p2M1A==" X-RZG-CLASS-ID: mo00 Received: from gerhold.net by smtp.strato.de (RZmta 47.33.8 DYNA|AUTH) with ESMTPSA id 301038x8OAmsSXx (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Fri, 24 Sep 2021 12:48:54 +0200 (CEST) Date: Fri, 24 Sep 2021 12:48:49 +0200 From: Stephan Gerhold To: dsankouski@gmail.com Cc: u-boot@lists.denx.de, Ramon Fried , Tom Rini Subject: Re: [PATCH 3/6] pinctrl: qcom: add pinctrl and gpio drivers for SDM845 SoC Message-ID: References: <20210923185732.7679-1-dsankouski@gmail.com> <20210923185732.7679-4-dsankouski@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210923185732.7679-4-dsankouski@gmail.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi, On Thu, Sep 23, 2021 at 09:57:29PM +0300, dsankouski@gmail.com wrote: > From: Dzmitry Sankouski > > Signed-off-by: Dzmitry Sankouski > Cc: Ramon Fried > Cc: Tom Rini > --- > arch/arm/mach-snapdragon/pinctrl-sdm845.c | 44 +++++++++++++++++++ > arch/arm/mach-snapdragon/pinctrl-snapdragon.c | 1 + > arch/arm/mach-snapdragon/pinctrl-snapdragon.h | 1 + > drivers/gpio/msm_gpio.c | 1 + > drivers/gpio/pm8916_gpio.c | 8 ++-- > 5 files changed, 52 insertions(+), 3 deletions(-) > create mode 100644 arch/arm/mach-snapdragon/pinctrl-sdm845.c > > diff --git a/arch/arm/mach-snapdragon/pinctrl-sdm845.c b/arch/arm/mach-snapdragon/pinctrl-sdm845.c > new file mode 100644 > index 0000000000..6d66582aa6 > --- /dev/null > +++ b/arch/arm/mach-snapdragon/pinctrl-sdm845.c > @@ -0,0 +1,44 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Qualcomm SDM845 pinctrl > + * > + * (C) Copyright 2021 Dzmitry Sankouski > + * > + */ > + > +#include "pinctrl-snapdragon.h" > +#include > + > +#define MAX_PIN_NAME_LEN 32 > +static char pin_name[MAX_PIN_NAME_LEN]; Since this is used before relocation (when setting up pinctrl for serial) you should really add __section(".data") here. I would expect that you are currently corrupting some random part of your appended DTB and are just lucky enough this does not cause any crashes. :) See: https://source.denx.de/u-boot/u-boot/-/commit/548b89f8ad396d238d594f6f6fa1df902b74a303 Thanks, Stephan