From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2FBCC433FE for ; Fri, 24 Sep 2021 16:42:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFE0F60EE0 for ; Fri, 24 Sep 2021 16:42:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245412AbhIXQnc (ORCPT ); Fri, 24 Sep 2021 12:43:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:40618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233969AbhIXQnb (ORCPT ); Fri, 24 Sep 2021 12:43:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E7C9260EE7; Fri, 24 Sep 2021 16:41:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632501718; bh=H423tEhL4STBIrStMHc+PhfbtwH8UWS0A41glaA+Nl4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AD1A1IDaA7kbGa5je+K+I6q33oR96VpWsUQJmPi4SDadXyUKmTxvCX4wkaXt4Ww0s zcdzOXuqCsfEDdbjhiefCfK6MTXQ49HZyBWn9xERTLwIKUG9nQ+UinMez/YEy4j25j 395etTNWCWl7s3X0+L2NOYf1LaOq1vROR6q7WyafXG9D0k5V6prMgR2mgUHBuqI+N6 sIXFlHulGnT11e3O7BtsIZjyjuS1FdBA8XRWK1VhAl60ER8SKwqfAefbcG7S9J2rh+ VZxpGPgJ1oNDiTiOJWbUUeEduvJ80v4DQ3RVZVuOrIJZl0ron98N8sylPrXCNecj6U 8FBuwO8BD5pJw== Date: Fri, 24 Sep 2021 12:41:56 -0400 From: Sasha Levin To: Florian Fainelli Cc: Alexander Sverdlin , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Steven Rostedt , Ingo Molnar , Russell King , "moderated list:ARM PORT" Subject: Re: [PATCH stable 4.9 v2 0/4] ARM: ftrace MODULE_PLTS warning Message-ID: References: <20210922170246.190499-1-f.fainelli@gmail.com> <34ae79e3-f109-bc4b-341a-f05d95cf15e3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <34ae79e3-f109-bc4b-341a-f05d95cf15e3@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 24, 2021 at 09:11:18AM -0700, Florian Fainelli wrote: >On 9/24/21 8:27 AM, Alexander Sverdlin wrote: >> Hi Sasha, >> >> On 24/09/2021 13:52, Sasha Levin wrote: >>>>> This patch series is present in v5.14 and fixes warnings seen at insmod >>>>> with FTRACE and MODULE_PLTS enabled on ARM/Linux. >>>> >>>> All now queued up, thanks. >>> >>> Looks like 4.19 and older break the build: >>> >>> arch/arm/kernel/ftrace.c: In function 'ftrace_update_ftrace_func': >>> arch/arm/kernel/ftrace.c:157:9: error: too few arguments to function 'ftrace_call_replace' >>>   157 |   new = ftrace_call_replace(pc, (unsigned long)func); >>>       |         ^~~~~~~~~~~~~~~~~~~ >> >> in principle you can add ", true" as a third argument in all these ftrace_call_replace() >> call-sites which still have two args. > >Sasha, what configuration failed to build? I build tested with >mutli_v7_defconfig which does enable FTRACE by default and then ensured >that CONFIG_ARM_MODULE_PLTS was enabled. From there I will re-submit, >sorry about that. allmodconfig seemed to have hit that. -- Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 882FAC433EF for ; Fri, 24 Sep 2021 16:44:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53F9F610C9 for ; Fri, 24 Sep 2021 16:44:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 53F9F610C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KMiQFiBlrf0m5WZUKULjcOUwUAlDh131MvctEon5q5I=; b=MZfNVtTFczBTYbtmn+c2DowjqN Gh6WTy1Y992fjhgK0Ce9FrQ5BYr6IIpwZH4TOI1th1KNaeqgilImgY2MIIKSiREWxWr+5TPgGg7TF RYgWE3/n+4oEGm+bB470EEW4xniQ6kP6ZRKDCdb98ZDjm1+g926+OSFiYEptlKzq9KQPIVD6B5YyL yJ+drCEoqs9u/D7QlP3nSSLmasnseZVsIFOr26S7YFK7wr4LUUVafQP5vzKuTL6iUtDiXq93rpFIZ QCNvge62Y5WigkBdeMWjZ+f+pf9KM3B9FjTovt5VeBYW8OzBt7hprG4v8zW8FY5vvF+TwjuMlspiX 5ZaVfLMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mToGw-00F7SC-6n; Fri, 24 Sep 2021 16:42:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mToGs-00F7RC-JQ for linux-arm-kernel@lists.infradead.org; Fri, 24 Sep 2021 16:41:59 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E7C9260EE7; Fri, 24 Sep 2021 16:41:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632501718; bh=H423tEhL4STBIrStMHc+PhfbtwH8UWS0A41glaA+Nl4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AD1A1IDaA7kbGa5je+K+I6q33oR96VpWsUQJmPi4SDadXyUKmTxvCX4wkaXt4Ww0s zcdzOXuqCsfEDdbjhiefCfK6MTXQ49HZyBWn9xERTLwIKUG9nQ+UinMez/YEy4j25j 395etTNWCWl7s3X0+L2NOYf1LaOq1vROR6q7WyafXG9D0k5V6prMgR2mgUHBuqI+N6 sIXFlHulGnT11e3O7BtsIZjyjuS1FdBA8XRWK1VhAl60ER8SKwqfAefbcG7S9J2rh+ VZxpGPgJ1oNDiTiOJWbUUeEduvJ80v4DQ3RVZVuOrIJZl0ron98N8sylPrXCNecj6U 8FBuwO8BD5pJw== Date: Fri, 24 Sep 2021 12:41:56 -0400 From: Sasha Levin To: Florian Fainelli Cc: Alexander Sverdlin , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Steven Rostedt , Ingo Molnar , Russell King , "moderated list:ARM PORT" Subject: Re: [PATCH stable 4.9 v2 0/4] ARM: ftrace MODULE_PLTS warning Message-ID: References: <20210922170246.190499-1-f.fainelli@gmail.com> <34ae79e3-f109-bc4b-341a-f05d95cf15e3@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <34ae79e3-f109-bc4b-341a-f05d95cf15e3@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210924_094158_679944_B75B236F X-CRM114-Status: GOOD ( 10.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 24, 2021 at 09:11:18AM -0700, Florian Fainelli wrote: >On 9/24/21 8:27 AM, Alexander Sverdlin wrote: >> Hi Sasha, >> >> On 24/09/2021 13:52, Sasha Levin wrote: >>>>> This=A0patch=A0series=A0is=A0present=A0in=A0v5.14=A0and=A0fixes=A0war= nings=A0seen=A0at=A0insmod >>>>> with=A0FTRACE=A0and=A0MODULE_PLTS=A0enabled=A0on=A0ARM/Linux. >>>> >>>> All=A0now=A0queued=A0up,=A0thanks. >>> >>> Looks=A0like=A04.19=A0and=A0older=A0break=A0the=A0build: >>> >>> arch/arm/kernel/ftrace.c:=A0In=A0function=A0'ftrace_update_ftrace_func': >>> arch/arm/kernel/ftrace.c:157:9:=A0error:=A0too=A0few=A0arguments=A0to= =A0function=A0'ftrace_call_replace' >>> =A0=A0157=A0|=A0=A0=A0new=A0=3D=A0ftrace_call_replace(pc,=A0(unsigned= =A0long)func); >>> =A0=A0=A0=A0=A0=A0|=A0=A0=A0=A0=A0=A0=A0=A0=A0^~~~~~~~~~~~~~~~~~~ >> >> in principle you can add ", true" as a third argument in all these ftrac= e_call_replace() >> call-sites which still have two args. > >Sasha, what configuration failed to build? I build tested with >mutli_v7_defconfig which does enable FTRACE by default and then ensured >that CONFIG_ARM_MODULE_PLTS was enabled. From there I will re-submit, >sorry about that. allmodconfig seemed to have hit that. -- = Thanks, Sasha _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel