[LTP] [PATCH 1/2] runtest/smoketest: Remove intermittent failed test case route4-change-dst

[LTP] [PATCH 1/2] runtest/smoketest: Remove intermittent failed test case route4-change-dst

[Naresh Kamboju]

The test case route4-change-dst fails intermittently creating
the problem for smoketest results verdict. route4-change-dst
is a stress test should not be a part of smoketest. because of
these issues removing route4-change-dst from the smoketest.

Suggested-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
---
 runtest/smoketest | 1 -
 1 file changed, 1 deletion(-)

diff --git a/runtest/smoketest b/runtest/smoketest
index 7f395936e..dd689bd6f 100644
--- a/runtest/smoketest
+++ b/runtest/smoketest
@@ -12,5 +12,4 @@ stat04 symlink01 -T stat04
 utime01A symlink01 -T utime01
 rename01A symlink01 -T rename01
 splice02 splice02 -s 20
-route4-change-dst route-change-dst.sh
 shell_test01 echo "SUCCESS" | shell_pipe01.sh
-- 
2.30.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 2/2] runtest/smoketest: Adding ping01 and ping02 test cases

[Naresh Kamboju]

Adding two ping test case to smoketest
ping01 ping01.sh
ping602 ping02.sh -6

Suggested-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
Suggested-by: Petr Vorel <pvorel@suse.cz>
Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
---
 runtest/smoketest | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/runtest/smoketest b/runtest/smoketest
index dd689bd6f..7bebe4a42 100644
--- a/runtest/smoketest
+++ b/runtest/smoketest
@@ -13,3 +13,5 @@ utime01A symlink01 -T utime01
 rename01A symlink01 -T rename01
 splice02 splice02 -s 20
 shell_test01 echo "SUCCESS" | shell_pipe01.sh
+ping01 ping01.sh
+ping602 ping02.sh -6
-- 
2.30.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/2] runtest/smoketest: Remove intermittent failed test case route4-change-dst

[Petr Vorel]

> The test case route4-change-dst fails intermittently creating
> the problem for smoketest results verdict. route4-change-dst
> is a stress test should not be a part of smoketest. because of
> these issues removing route4-change-dst from the smoketest.

> Suggested-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
> Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>

Did 75184c30a ("lib/tst_net.sh: disable ipv6_dad work on test interfaces")
fixed your problem? I'd actually like to route4-change-dst in smoketest to
have it as a detection DAD issue is working.

Kind regards,
Petr

> ---
>  runtest/smoketest | 1 -
>  1 file changed, 1 deletion(-)

> diff --git a/runtest/smoketest b/runtest/smoketest
> index 7f395936e..dd689bd6f 100644
> --- a/runtest/smoketest
> +++ b/runtest/smoketest
> @@ -12,5 +12,4 @@ stat04 symlink01 -T stat04
>  utime01A symlink01 -T utime01
>  rename01A symlink01 -T rename01
>  splice02 splice02 -s 20
> -route4-change-dst route-change-dst.sh
>  shell_test01 echo "SUCCESS" | shell_pipe01.sh

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/2] runtest/smoketest: Remove intermittent failed test case route4-change-dst

[Naresh Kamboju]

On Tue, 14 Sept 2021 at 18:20, Petr Vorel <pvorel@suse.cz> wrote:
>
> > The test case route4-change-dst fails intermittently creating
> > the problem for smoketest results verdict. route4-change-dst
> > is a stress test should not be a part of smoketest. because of
> > these issues removing route4-change-dst from the smoketest.
>
> > Suggested-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
> > Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>
> Did 75184c30a ("lib/tst_net.sh: disable ipv6_dad work on test interfaces")
> fixed your problem? I'd actually like to route4-change-dst in smoketest to
> have it as a detection DAD issue is working.

I will add this patch and test in loop.

- Naresh

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/2] runtest/smoketest: Remove intermittent failed test case route4-change-dst

[Alexey Kodanev]

On 14.09.2021 15:50, Petr Vorel wrote:
>> The test case route4-change-dst fails intermittently creating
>> the problem for smoketest results verdict. route4-change-dst
>> is a stress test should not be a part of smoketest. because of
>> these issues removing route4-change-dst from the smoketest.
> 
>> Suggested-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com>
>> Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> 
> Did 75184c30a ("lib/tst_net.sh: disable ipv6_dad work on test interfaces")
> fixed your problem? I'd actually like to route4-change-dst in smoketest to
> have it as a detection DAD issue is working.

75184c30a is fixing ipv6. From the log, it seems the error happens
in ping, when it once again tried to bind to 10.0.0.2 as a source
address (with -I option)...

> 
> Kind regards,
> Petr
> 
>> ---
>>  runtest/smoketest | 1 -
>>  1 file changed, 1 deletion(-)
> 
>> diff --git a/runtest/smoketest b/runtest/smoketest
>> index 7f395936e..dd689bd6f 100644
>> --- a/runtest/smoketest
>> +++ b/runtest/smoketest
>> @@ -12,5 +12,4 @@ stat04 symlink01 -T stat04
>>  utime01A symlink01 -T utime01
>>  rename01A symlink01 -T rename01
>>  splice02 splice02 -s 20
>> -route4-change-dst route-change-dst.sh
>>  shell_test01 echo "SUCCESS" | shell_pipe01.sh
> 


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/2] runtest/smoketest: Remove intermittent failed test case route4-change-dst

[Petr Vorel]

...
> > Did 75184c30a ("lib/tst_net.sh: disable ipv6_dad work on test interfaces")
> > fixed your problem? I'd actually like to route4-change-dst in smoketest to
> > have it as a detection DAD issue is working.

> 75184c30a is fixing ipv6. From the log, it seems the error happens
> in ping, when it once again tried to bind to 10.0.0.2 as a source
> address (with -I option)...

Ah, right, I'm sorry for overlooking this.
I squashed commits (reason to add ping tests is because we removed route test),
updated commit message and merged.

Thank you both!

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/2] runtest/smoketest: Remove intermittent failed test case route4-change-dst

[Naresh Kamboju]

Hi Petr,

On Thu, 9 Sept 2021 at 15:51, Petr Vorel <pvorel@suse.cz> wrote:
>
> Hi Naresh,
>
> > The test case route4-change-dst fails intermittently creating
> > the problem for smoketest results verdict. route4-change-dst
> > is a stress test should not be a part of smoketest. because of
> > these issues removing route4-change-dst from the smoketest.
> Could you please be more specific about the failure?

Test log,

route-change-dst 1 TINFO: initialize 'lhost' 'ltp_ns_veth2' interface
route-change-dst 1 TINFO: add local addr 10.0.0.2/24
route-change-dst 1 TINFO: add local addr fd00:1:1:1::2/64
route-change-dst 1 TINFO: initialize 'rhost' 'ltp_ns_veth1' interface
[   54.413187] IPv6: ADDRCONF(NETDEV_CHANGE): ltp_ns_veth2: link becomes ready
route-change-dst 1 TINFO: add remote addr 10.0.0.1/24
route-change-dst 1 TINFO: add remote addr fd00:1:1:1::1/64
route-change-dst 1 TINFO: Network config (local -- remote):
route-change-dst 1 TINFO: ltp_ns_veth2 -- ltp_ns_veth1
route-change-dst 1 TINFO: 10.0.0.2/24 -- 10.0.0.1/24
route-change-dst 1 TINFO: fd00:1:1:1::2/64 -- fd00:1:1:1::1/64
route-change-dst 1 TINFO: timeout per run is 0h 15m 0s
route-change-dst 1 TINFO: change IPv4 route destination 100 times
route-change-dst 1 TINFO: testing route '10.23.1.0/24'
bind: Cannot assign requested address
route-change-dst 1 TFAIL: ping -c1 -I 10.0.0.2 10.23.1.1 >/dev/null
failed unexpectedly
route-change-dst 1 TINFO: initialize 'lhost' 'ltp_ns_veth2' interface
route-change-dst 1 TINFO: add local addr 10.0.0.2/24
route-change-dst 1 TINFO: add local addr fd00:1:1:1::2/64
route-change-dst 1 TINFO: initialize 'rhost' 'ltp_ns_veth1' interface
route-change-dst 1 TINFO: add remote addr 10.0.0.1/24
route-change-dst 1 TINFO: add remote addr fd00:1:1:1::1/64

Summary:
passed   0
failed   1


>
> I'm not against adding ping tests into smoketest runtest file,
> although just on might be enough. ping02.sh is the fastest from all 3 tests,
> maybe add it. Also -6 for IPv6 would be good (to detect problems with IPv6 setup).

I will add
ping602 ping02.sh -6

>
> But route-change-dst.sh is quick (actually 2 times faster than ping01) that it's
> not really a stress test in the default configuration, thus I'd prefer to keep it.

The actual problem with route-change-dst.sh is an intermittent failure
test case.

Here is the link showing intermittent failure.  (click on the loadmore button)
https://qa-reports.linaro.org/_/comparetest/?project=136&suite=ltp-smoketest-tests&test=route4-change-dst


- Naresh

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/2] runtest/smoketest: Remove intermittent failed test case route4-change-dst

[Petr Vorel]

Hi Naresh,

> The test case route4-change-dst fails intermittently creating
> the problem for smoketest results verdict. route4-change-dst
> is a stress test should not be a part of smoketest. because of
> these issues removing route4-change-dst from the smoketest.
Could you please be more specific about the failure?

I'm not against adding ping tests into smoketest runtest file,
although just on might be enough. ping02.sh is the fastest from all 3 tests,
maybe add it. Also -6 for IPv6 would be good (to detect problems with IPv6 setup).


But route-change-dst.sh is quick (actually 2 times faster than ping01) that it's
not really a stress test in the default configuration, thus I'd prefer to keep it.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 1/2] runtest/smoketest: Remove intermittent failed test case route4-change-dst

[Naresh Kamboju]

The test case route4-change-dst fails intermittently creating
the problem for smoketest results verdict. route4-change-dst
is a stress test should not be a part of smoketest. because of
these issues removing route4-change-dst from the smoketest.

Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
---
 runtest/smoketest | 1 -
 1 file changed, 1 deletion(-)

diff --git a/runtest/smoketest b/runtest/smoketest
index 7f395936e..dd689bd6f 100644
--- a/runtest/smoketest
+++ b/runtest/smoketest
@@ -12,5 +12,4 @@ stat04 symlink01 -T stat04
 utime01A symlink01 -T utime01
 rename01A symlink01 -T rename01
 splice02 splice02 -s 20
-route4-change-dst route-change-dst.sh
 shell_test01 echo "SUCCESS" | shell_pipe01.sh
-- 
2.30.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 1/2] runtest/smoketest: Remove intermittent failed test case route4-change-dst

[Naresh Kamboju]

The test case route4-change-dst fails intermittently creating
the problem for smoketest results verdict. route4-change-dst
is a stress test should not be a part of smoketest. because of
these issues removing route4-change-dst from the smoketest.

Signed-off-by: Naresh Kamboju <naresh.kamboju@linaro.org>
---
 runtest/smoketest | 1 -
 1 file changed, 1 deletion(-)

diff --git a/runtest/smoketest b/runtest/smoketest
index 7f395936e..dd689bd6f 100644
--- a/runtest/smoketest
+++ b/runtest/smoketest
@@ -12,5 +12,4 @@ stat04 symlink01 -T stat04
 utime01A symlink01 -T utime01
 rename01A symlink01 -T rename01
 splice02 splice02 -s 20
-route4-change-dst route-change-dst.sh
 shell_test01 echo "SUCCESS" | shell_pipe01.sh
-- 
2.30.2


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp