All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] ARM: dts: imx6qdl-pico: Fix Ethernet support
@ 2021-09-14 15:59 Fabio Estevam
  2021-09-14 16:12 ` Andrew Lunn
  0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2021-09-14 15:59 UTC (permalink / raw)
  To: shawnguo
  Cc: linux-arm-kernel, o.rempel, andrew, john.weber, linux, Fabio Estevam

Currently, it is no longer possible to retrieve a DHCP address
on the imx6qdl-pico board.

This issue has been exposed by commit f5d9aa79dfdf ("ARM: imx6q:
remove clk-out fixup for the Atheros AR8031 and AR8035 PHYs").

Fix it by describing the qca,clk-out-frequency property as suggested
by the commit above.

Fixes: 98670a0bb0ef14bbb3 ("ARM: dts: imx6qdl: Add imx6qdl-pico support")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v2:
- Do not move the reset properties (Russell).
 
 arch/arm/boot/dts/imx6qdl-pico.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-pico.dtsi b/arch/arm/boot/dts/imx6qdl-pico.dtsi
index 5de4ccb97916..fe8a93fc65b8 100644
--- a/arch/arm/boot/dts/imx6qdl-pico.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-pico.dtsi
@@ -177,6 +177,16 @@ &fec {
 	phy-mode = "rgmii-id";
 	phy-reset-gpios = <&gpio1 26 GPIO_ACTIVE_LOW>;
 	status = "okay";
+
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		phy: ethernet-phy@1 {
+			reg = <1>;
+			qca,clk-out-frequency = <125000000>;
+		};
+	};
 };
 
 &hdmi {
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v3] ARM: dts: imx6qdl-pico: Fix Ethernet support
  2021-09-14 15:59 [PATCH v3] ARM: dts: imx6qdl-pico: Fix Ethernet support Fabio Estevam
@ 2021-09-14 16:12 ` Andrew Lunn
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Lunn @ 2021-09-14 16:12 UTC (permalink / raw)
  To: Fabio Estevam; +Cc: shawnguo, linux-arm-kernel, o.rempel, john.weber, linux

On Tue, Sep 14, 2021 at 12:59:30PM -0300, Fabio Estevam wrote:
> Currently, it is no longer possible to retrieve a DHCP address
> on the imx6qdl-pico board.
> 
> This issue has been exposed by commit f5d9aa79dfdf ("ARM: imx6q:
> remove clk-out fixup for the Atheros AR8031 and AR8035 PHYs").
> 
> Fix it by describing the qca,clk-out-frequency property as suggested
> by the commit above.
> 
> Fixes: 98670a0bb0ef14bbb3 ("ARM: dts: imx6qdl: Add imx6qdl-pico support")
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Now that you have the PHY listed in DT, you could use a phy-handle to
point to it.

    Andrew

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-09-14 16:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-14 15:59 [PATCH v3] ARM: dts: imx6qdl-pico: Fix Ethernet support Fabio Estevam
2021-09-14 16:12 ` Andrew Lunn

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.