From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B2FEC433EF for ; Tue, 14 Sep 2021 16:37:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C462560EB6 for ; Tue, 14 Sep 2021 16:37:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C462560EB6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:42130 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQBRH-0001iz-1c for qemu-devel@archiver.kernel.org; Tue, 14 Sep 2021 12:37:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQBPE-0008MO-T3 for qemu-devel@nongnu.org; Tue, 14 Sep 2021 12:35:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:43759) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQBPA-0007fT-Il for qemu-devel@nongnu.org; Tue, 14 Sep 2021 12:35:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631637331; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uB/IOM9wvm06euCcwdkC6N9/8Q6PIHGVDPykNlmmfIQ=; b=aK8Fis10zkrq98hGPJeKiJRfAocQZ7ezWSJ/JIUUosv0YX+vFSwgilgf64DRcu/nOooKoD JbfAQ7Sedo+fLKzzuxuI5cj2sz1nYDncmK0xh2olU284HAIjMwgON+VQqCNZNgCBxDVliu XYXDNZpDYjYrTb4oMt7KYHQw4sZaj18= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-tGaUdgfPPR61IwJzSKKHAQ-1; Tue, 14 Sep 2021 12:35:30 -0400 X-MC-Unique: tGaUdgfPPR61IwJzSKKHAQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5B5F9104FC26; Tue, 14 Sep 2021 16:35:10 +0000 (UTC) Received: from redhat.com (unknown [10.39.193.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8D2205DF2F; Tue, 14 Sep 2021 16:34:27 +0000 (UTC) Date: Tue, 14 Sep 2021 17:34:24 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH v2 42/53] hw/core: introduce a 'format_tlb' callback Message-ID: References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-43-berrange@redhat.com> <818d439f-337e-a73c-9e22-fbf8a119435f@redhat.com> MIME-Version: 1.0 In-Reply-To: <818d439f-337e-a73c-9e22-fbf8a119435f@redhat.com> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.398, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , Cornelia Huck , David Hildenbrand , Bin Meng , Mark Cave-Ayland , qemu-devel@nongnu.org, Max Filippov , Taylor Simpson , Alistair Francis , Gerd Hoffmann , Eric Blake , Marek Vasut , Yoshinori Sato , Markus Armbruster , Halil Pasic , Christian Borntraeger , qemu-ppc@nongnu.org, Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , Yuval Shaia , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Peter Xu , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Chris Wulff , Laurent Vivier , Palmer Dabbelt , Aurelien Jarno , Paolo Bonzini , Aleksandar Rikalo , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Tue, Sep 14, 2021 at 05:56:09PM +0200, Philippe Mathieu-Daudé wrote: > On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > > This will allow us to reduce duplication between the different targets > > implementing the 'info tlb' command. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > hw/core/cpu-common.c | 9 +++++++++ > > include/hw/core/cpu.h | 11 +++++++++++ > > 2 files changed, 20 insertions(+) > > > diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h > > index 4c47e1df18..64fc57c8d9 100644 > > --- a/include/hw/core/cpu.h > > +++ b/include/hw/core/cpu.h > > * @has_work: Callback for checking if there is work to do. > > * @memory_rw_debug: Callback for GDB memory access. > > * @format_state: Callback for formatting state. > > + * @format_tlb: Callback for formatting memory mappings > > * @get_arch_id: Callback for getting architecture-dependent CPU ID. > > * @set_pc: Callback for setting the Program Counter register. This > > * should have the semantics used by the target architecture when > > @@ -136,6 +137,7 @@ struct CPUClass { > > int (*memory_rw_debug)(CPUState *cpu, vaddr addr, > > uint8_t *buf, int len, bool is_write); > > void (*format_state)(CPUState *cpu, GString *buf, int flags); > > + void (*format_tlb)(CPUState *cpu, GString *buf); > > Doesn't this belong to SysemuCPUOps? I can't really answer, since my knowledge of this area of QEMU code is fairly mimimal. I put it here because it is basically serving the same purpose as the "format_state" callback immediately above it, which was a rename of the existing "dump_state" callback. I assumed whatever was there already was a good practice to follow[1]... Regards, Daniel [1] yes assuming these things is often foolish in QEMU :-) -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mQBPK-0008Q4-0J for mharc-qemu-riscv@gnu.org; Tue, 14 Sep 2021 12:35:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQBPD-0008Lc-UK for qemu-riscv@nongnu.org; Tue, 14 Sep 2021 12:35:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:52388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQBPB-0007fR-7d for qemu-riscv@nongnu.org; Tue, 14 Sep 2021 12:35:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631637331; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uB/IOM9wvm06euCcwdkC6N9/8Q6PIHGVDPykNlmmfIQ=; b=aK8Fis10zkrq98hGPJeKiJRfAocQZ7ezWSJ/JIUUosv0YX+vFSwgilgf64DRcu/nOooKoD JbfAQ7Sedo+fLKzzuxuI5cj2sz1nYDncmK0xh2olU284HAIjMwgON+VQqCNZNgCBxDVliu XYXDNZpDYjYrTb4oMt7KYHQw4sZaj18= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-564-tGaUdgfPPR61IwJzSKKHAQ-1; Tue, 14 Sep 2021 12:35:30 -0400 X-MC-Unique: tGaUdgfPPR61IwJzSKKHAQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5B5F9104FC26; Tue, 14 Sep 2021 16:35:10 +0000 (UTC) Received: from redhat.com (unknown [10.39.193.47]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8D2205DF2F; Tue, 14 Sep 2021 16:34:27 +0000 (UTC) Date: Tue, 14 Sep 2021 17:34:24 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Peter Maydell , Chris Wulff , David Hildenbrand , Bin Meng , Mark Cave-Ayland , Yuval Shaia , Jiaxun Yang , Laurent Vivier , Max Filippov , Taylor Simpson , Alistair Francis , Gerd Hoffmann , Eric Blake , Marek Vasut , Yoshinori Sato , Markus Armbruster , Halil Pasic , Christian Borntraeger , Marcel Apfelbaum , Palmer Dabbelt , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , "Dr. David Alan Gilbert" , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Peter Xu , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Cornelia Huck , qemu-ppc@nongnu.org, Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Subject: Re: [PATCH v2 42/53] hw/core: introduce a 'format_tlb' callback Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-43-berrange@redhat.com> <818d439f-337e-a73c-9e22-fbf8a119435f@redhat.com> MIME-Version: 1.0 In-Reply-To: <818d439f-337e-a73c-9e22-fbf8a119435f@redhat.com> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.398, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2021 16:35:39 -0000 On Tue, Sep 14, 2021 at 05:56:09PM +0200, Philippe Mathieu-Daudé wrote: > On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > > This will allow us to reduce duplication between the different targets > > implementing the 'info tlb' command. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > hw/core/cpu-common.c | 9 +++++++++ > > include/hw/core/cpu.h | 11 +++++++++++ > > 2 files changed, 20 insertions(+) > > > diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h > > index 4c47e1df18..64fc57c8d9 100644 > > --- a/include/hw/core/cpu.h > > +++ b/include/hw/core/cpu.h > > * @has_work: Callback for checking if there is work to do. > > * @memory_rw_debug: Callback for GDB memory access. > > * @format_state: Callback for formatting state. > > + * @format_tlb: Callback for formatting memory mappings > > * @get_arch_id: Callback for getting architecture-dependent CPU ID. > > * @set_pc: Callback for setting the Program Counter register. This > > * should have the semantics used by the target architecture when > > @@ -136,6 +137,7 @@ struct CPUClass { > > int (*memory_rw_debug)(CPUState *cpu, vaddr addr, > > uint8_t *buf, int len, bool is_write); > > void (*format_state)(CPUState *cpu, GString *buf, int flags); > > + void (*format_tlb)(CPUState *cpu, GString *buf); > > Doesn't this belong to SysemuCPUOps? I can't really answer, since my knowledge of this area of QEMU code is fairly mimimal. I put it here because it is basically serving the same purpose as the "format_state" callback immediately above it, which was a rename of the existing "dump_state" callback. I assumed whatever was there already was a good practice to follow[1]... Regards, Daniel [1] yes assuming these things is often foolish in QEMU :-) -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|